[ObjC ARC] Converts ios/chrome/browser/ui/settings:settings to ARC.

ios/chrome/browser/ui/settings/settings_navigation_controller.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/settings/settings_navigation_controller.h"
 
 #include "base/ios/ios_util.h"
-#import "base/ios/weak_nsobject.h"
 #include "base/mac/foundation_util.h"
-#import "base/mac/scoped_nsobject.h"
 #include "components/strings/grit/components_strings.h"
 #include "ios/chrome/browser/browser_state/chrome_browser_state.h"
 #include "ios/chrome/browser/sync/sync_setup_service.h"
 #include "ios/chrome/browser/sync/sync_setup_service_factory.h"
 #import "ios/chrome/browser/ui/commands/UIKit+ChromeExecuteCommand.h"
 #import "ios/chrome/browser/ui/commands/clear_browsing_data_command.h"
 #include "ios/chrome/browser/ui/commands/ios_command_ids.h"
 #import "ios/chrome/browser/ui/commands/show_signin_command.h"
 #import "ios/chrome/browser/ui/icons/chrome_icon.h"
 #import "ios/chrome/browser/ui/keyboard/UIKeyCommand+Chrome.h"
@@ skipping 12 matching lines @@
 #import "ios/chrome/browser/ui/settings/sync_settings_collection_view_controller.h"
 #include "ios/chrome/browser/ui/ui_util.h"
 #import "ios/chrome/browser/ui/uikit_ui_util.h"
 #include "ios/chrome/grit/ios_strings.h"
 #import "ios/public/provider/chrome/browser/chrome_browser_provider.h"
 #import "ios/public/provider/chrome/browser/user_feedback/user_feedback_provider.h"
 #import "ios/third_party/material_components_ios/src/components/AppBar/src/MaterialAppBar.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/l10n/l10n_util_mac.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
 // TODO(crbug.com/620361): Remove the entire class when iOS 9 is dropped.
 @interface SettingsAppBarContainerViewController
     : MDCAppBarContainerViewController
 @end
 
 @implementation SettingsAppBarContainerViewController
 
 #pragma mark - Status bar
 
 - (UIViewController*)childViewControllerForStatusBarHidden {
@@ skipping 40 matching lines @@
 // Intercepts the chrome command |sender|. If |sender| is an
 // |IDC_CLOSE_SETTINGS_AND_OPEN_URL| and |delegate_| is not nil, then it
 // calls [delegate closeSettingsAndOpenUrl:sender], otherwise it forwards the
 // command up the responder chain.
 - (void)chromeExecuteCommand:(id)sender;
 
 @end
 
 @implementation SettingsNavigationController {
   ios::ChromeBrowserState* mainBrowserState_;  // weak
-  base::WeakNSProtocol<id<SettingsNavigationControllerDelegate>> delegate_;
+  __weak id<SettingsNavigationControllerDelegate> delegate_;
   // Keeps a mapping between the view controllers that are wrapped to display an
   // app bar and the containers that wrap them.
-  base::scoped_nsobject<NSMutableDictionary> appBarContainedViewControllers_;
+  NSMutableDictionary* appBarContainedViewControllers_;
 }
 
 @synthesize shouldCommitSyncChangesOnDismissal =
     shouldCommitSyncChangesOnDismissal_;
 
 #pragma mark - SettingsNavigationController methods.
 
 // clang-format off
 + (SettingsNavigationController*)newSettingsMainControllerWithMainBrowserState:
     (ios::ChromeBrowserState*)browserState
                                                            currentBrowserState:
     (ios::ChromeBrowserState*)currentBrowserState
                                                                       delegate:
     (id<SettingsNavigationControllerDelegate>)delegate {
   // clang-format on
-  base::scoped_nsobject<UIViewController> controller(
-      [[SettingsCollectionViewController alloc]
-          initWithBrowserState:browserState
-           currentBrowserState:currentBrowserState]);
+  UIViewController* controller = [[SettingsCollectionViewController alloc]
+      initWithBrowserState:browserState
+       currentBrowserState:currentBrowserState];
   SettingsNavigationController* nc = [[SettingsNavigationController alloc]
       initWithRootViewController:controller
                     browserState:browserState
                         delegate:delegate];
   [controller navigationItem].rightBarButtonItem = [nc doneButton];
   return nc;
 }
 
 + (SettingsNavigationController*)
 newAccountsController:(ios::ChromeBrowserState*)browserState
              delegate:(id<SettingsNavigationControllerDelegate>)delegate {
-  base::scoped_nsobject<UIViewController> controller([
-      [AccountsCollectionViewController alloc] initWithBrowserState:browserState
-                                          closeSettingsOnAddAccount:YES]);
+  UIViewController* controller = [[AccountsCollectionViewController alloc]
+           initWithBrowserState:browserState
+      closeSettingsOnAddAccount:YES];
   SettingsNavigationController* nc = [[SettingsNavigationController alloc]
       initWithRootViewController:controller
                     browserState:browserState
                         delegate:delegate];
   [controller navigationItem].leftBarButtonItem = [nc closeButton];
   return nc;
 }
 
 + (SettingsNavigationController*)
      newSyncController:(ios::ChromeBrowserState*)browserState
 allowSwitchSyncAccount:(BOOL)allowSwitchSyncAccount
               delegate:(id<SettingsNavigationControllerDelegate>)delegate {
-  base::scoped_nsobject<UIViewController> controller(
-      [[SyncSettingsCollectionViewController alloc]
-            initWithBrowserState:browserState
-          allowSwitchSyncAccount:allowSwitchSyncAccount]);
+  UIViewController* controller = [[SyncSettingsCollectionViewController alloc]
+        initWithBrowserState:browserState
+      allowSwitchSyncAccount:allowSwitchSyncAccount];
   SettingsNavigationController* nc = [[SettingsNavigationController alloc]
       initWithRootViewController:controller
                     browserState:browserState
                         delegate:delegate];
   [controller navigationItem].rightBarButtonItem = [nc doneButton];
   return nc;
 }
 
 + (SettingsNavigationController*)
 newUserFeedbackController:(ios::ChromeBrowserState*)browserState
                  delegate:(id<SettingsNavigationControllerDelegate>)delegate
        feedbackDataSource:(id<UserFeedbackDataSource>)dataSource {
   DCHECK(ios::GetChromeBrowserProvider()
              ->GetUserFeedbackProvider()
              ->IsUserFeedbackEnabled());
-  base::scoped_nsobject<UIViewController> controller(
-      ios::GetChromeBrowserProvider()
-          ->GetUserFeedbackProvider()
-          ->CreateViewController(dataSource));
+  UIViewController* controller = ios::GetChromeBrowserProvider()
+                                     ->GetUserFeedbackProvider()
+                                     ->CreateViewController(dataSource);
   DCHECK(controller);
   SettingsNavigationController* nc = [[SettingsNavigationController alloc]
       initWithRootViewController:controller
                     browserState:browserState
                         delegate:delegate];
   [controller navigationItem].rightBarButtonItem = [nc cancelButton];
   return nc;
 }
 
 + (SettingsNavigationController*)
 newClearBrowsingDataController:(ios::ChromeBrowserState*)browserState
                       delegate:
                           (id<SettingsNavigationControllerDelegate>)delegate {
-  base::scoped_nsobject<UIViewController> controller(
+  UIViewController* controller =
       [[ClearBrowsingDataCollectionViewController alloc]
-          initWithBrowserState:browserState]);
+          initWithBrowserState:browserState];
   SettingsNavigationController* nc = [[SettingsNavigationController alloc]
       initWithRootViewController:controller
                     browserState:browserState
                         delegate:delegate];
   [controller navigationItem].rightBarButtonItem = [nc doneButton];
   return nc;
 }
 
 + (SettingsNavigationController*)
 newContextualSearchController:(ios::ChromeBrowserState*)browserState
                      delegate:
                          (id<SettingsNavigationControllerDelegate>)delegate {
-  base::scoped_nsobject<UIViewController> controller(
+  UIViewController* controller =
       [[ContextualSearchCollectionViewController alloc]
-          initWithBrowserState:browserState]);
+          initWithBrowserState:browserState];
   SettingsNavigationController* nc = [[SettingsNavigationController alloc]
       initWithRootViewController:controller
                     browserState:browserState
                         delegate:delegate];
   [controller navigationItem].rightBarButtonItem = [nc doneButton];
   return nc;
 }
 
 + (SettingsNavigationController*)
 newSyncEncryptionPassphraseController:(ios::ChromeBrowserState*)browserState
                              delegate:(id<SettingsNavigationControllerDelegate>)
                                           delegate {
-  base::scoped_nsobject<UIViewController> controller(
+  UIViewController* controller =
       [[SyncEncryptionPassphraseCollectionViewController alloc]
-          initWithBrowserState:browserState]);
+          initWithBrowserState:browserState];
   SettingsNavigationController* nc = [[SettingsNavigationController alloc]
       initWithRootViewController:controller
                     browserState:browserState
                         delegate:delegate];
   [controller navigationItem].leftBarButtonItem = [nc closeButton];
   return nc;
 }
 
 + (SettingsNavigationController*)
 newNativeAppsController:(ios::ChromeBrowserState*)browserState
                delegate:(id<SettingsNavigationControllerDelegate>)delegate {
-  base::scoped_nsobject<UIViewController> controller(
-      [[NativeAppsCollectionViewController alloc]
-          initWithURLRequestContextGetter:browserState->GetRequestContext()]);
+  UIViewController* controller = [[NativeAppsCollectionViewController alloc]
+      initWithURLRequestContextGetter:browserState->GetRequestContext()];
   SettingsNavigationController* nc = [[SettingsNavigationController alloc]
       initWithRootViewController:controller
                     browserState:browserState
                         delegate:delegate];
   return nc;
 }
 
 + (SettingsNavigationController*)
 newSavePasswordsController:(ios::ChromeBrowserState*)browserState
                   delegate:(id<SettingsNavigationControllerDelegate>)delegate {
-  base::scoped_nsobject<UIViewController> controller(
-      [[SavePasswordsCollectionViewController alloc]
-          initWithBrowserState:browserState]);
+  UIViewController* controller = [[SavePasswordsCollectionViewController alloc]
+      initWithBrowserState:browserState];
 
   SettingsNavigationController* nc = [[SettingsNavigationController alloc]
       initWithRootViewController:controller
                     browserState:browserState
                         delegate:delegate];
   [controller navigationItem].rightBarButtonItem = [nc doneButton];
 
   // Make sure the close button is always present, as the Save Passwords screen
   // isn't just shown from Settings.
   [controller navigationItem].leftBarButtonItem = [nc closeButton];
   return nc;
 }
 
 + (SettingsNavigationController*)
 newImportDataController:(ios::ChromeBrowserState*)browserState
                delegate:(id<SettingsNavigationControllerDelegate>)delegate
      importDataDelegate:(id<ImportDataControllerDelegate>)importDataDelegate
               fromEmail:(NSString*)fromEmail
                 toEmail:(NSString*)toEmail
              isSignedIn:(BOOL)isSignedIn {
-  base::scoped_nsobject<UIViewController> controller(
-      [[ImportDataCollectionViewController alloc]
-          initWithDelegate:importDataDelegate
-                 fromEmail:fromEmail
-                   toEmail:toEmail
-                isSignedIn:isSignedIn]);
+  UIViewController* controller = [[ImportDataCollectionViewController alloc]
+      initWithDelegate:importDataDelegate
+             fromEmail:fromEmail
+               toEmail:toEmail
+            isSignedIn:isSignedIn];
 
   SettingsNavigationController* nc = [[SettingsNavigationController alloc]
       initWithRootViewController:controller
                     browserState:browserState
                         delegate:delegate];
 
   // Make sure the close button is always present, as the Save Passwords screen
   // isn't just shown from Settings.
   [controller navigationItem].leftBarButtonItem = [nc closeButton];
   return nc;
 }
 
 + (SettingsNavigationController*)
 newAutofillController:(ios::ChromeBrowserState*)browserState
              delegate:(id<SettingsNavigationControllerDelegate>)delegate {
-  base::scoped_nsobject<UIViewController> controller(
-      [[AutofillCollectionViewController alloc]
-          initWithBrowserState:browserState]);
+  UIViewController* controller = [[AutofillCollectionViewController alloc]
+      initWithBrowserState:browserState];
 
   SettingsNavigationController* nc = [[SettingsNavigationController alloc]
       initWithRootViewController:controller
                     browserState:browserState
                         delegate:delegate];
   [controller navigationItem].rightBarButtonItem = [nc doneButton];
 
   // Make sure the close button is always present, as the Autofill screen
   // isn't just shown from Settings.
   [controller navigationItem].leftBarButtonItem = [nc closeButton];
   return nc;
 }
 
 #pragma mark - Lifecycle
 
 - (instancetype)
 initWithRootViewController:(UIViewController*)rootViewController
               browserState:(ios::ChromeBrowserState*)browserState
                   delegate:(id<SettingsNavigationControllerDelegate>)delegate {
   DCHECK(browserState);
   DCHECK(!browserState->IsOffTheRecord());
   self = [super initWithRootViewController:rootViewController];
   if (self) {
     mainBrowserState_ = browserState;
-    delegate_.reset(delegate);
+    delegate_ = delegate;
     shouldCommitSyncChangesOnDismissal_ = YES;
     [self configureUI];
   }
   return self;
 }
 
 - (void)settingsWillBeDismissed {
   // Notify all controllers that settings are about to be dismissed.
   for (UIViewController* controller in [self viewControllers]) {
     if ([controller respondsToSelector:@selector(settingsWillBeDismissed)]) {
       [controller performSelector:@selector(settingsWillBeDismissed)];
     }
   }
 
   // Sync changes cannot be cancelled and they must always be commited when
   // existing settings.
   if (shouldCommitSyncChangesOnDismissal_) {
     SyncSetupServiceFactory::GetForBrowserState([self mainBrowserState])
         ->CommitChanges();
   }
 
   // Reset the delegate to prevent any queued transitions from attempting to
   // close the settings.
-  delegate_.reset();
+  delegate_ = nil;
 }
 
 - (void)closeSettings {
   [delegate_ closeSettings];
 }
 
 - (void)back {
   [self popViewControllerAnimated:YES];
 }
 
@@ skipping 17 matching lines @@
   // https://github.com/material-components/material-components-ios/issues/720
   [self setNavigationBarHidden:YES];
   [self.interactivePopGestureRecognizer setDelegate:self];
 }
 
 - (BOOL)hasRightDoneButton {
   UIBarButtonItem* rightButton =
       self.topViewController.navigationItem.rightBarButtonItem;
   if (!rightButton)
     return NO;
-  base::scoped_nsobject<UIBarButtonItem> doneButton([self doneButton]);
+  UIBarButtonItem* doneButton = [self doneButton];
   return [rightButton style] == [doneButton style] &&
          [[rightButton title] compare:[doneButton title]] == NSOrderedSame;
 }
 
 - (UIBarButtonItem*)backButton {
   // Create a custom Back bar button item, as Material Navigation Bar deprecated
   // the back arrow with a shaft.
   return [ChromeIcon templateBarButtonItemWithImage:[ChromeIcon backIcon]
                                              target:self
                                              action:@selector(back)];
 }
 
 - (UIBarButtonItem*)doneButton {
   // Create a custom Done bar button item, as Material Navigation Bar does not
   // handle a system UIBarButtonSystemItemDone item.
-  return [[[UIBarButtonItem alloc]
+  return [[UIBarButtonItem alloc]
       initWithTitle:l10n_util::GetNSString(IDS_IOS_NAVIGATION_BAR_DONE_BUTTON)
               style:UIBarButtonItemStyleDone
              target:self
-             action:@selector(closeSettings)] autorelease];
+             action:@selector(closeSettings)];
 }
 
 - (UIBarButtonItem*)closeButton {
   UIBarButtonItem* closeButton =
       [ChromeIcon templateBarButtonItemWithImage:[ChromeIcon closeIcon]
                                           target:self
                                           action:@selector(closeSettings)];
   closeButton.accessibilityLabel = l10n_util::GetNSString(IDS_ACCNAME_CLOSE);
   return closeButton;
 }
 
 - (UIBarButtonItem*)cancelButton {
   // Create a custom Cancel bar button item, as Material Navigation Bar does not
   // handle a system UIBarButtonSystemItemCancel item.
-  return [[[UIBarButtonItem alloc]
+  return [[UIBarButtonItem alloc]
       initWithTitle:l10n_util::GetNSString(IDS_IOS_NAVIGATION_BAR_CANCEL_BUTTON)
               style:UIBarButtonItemStyleDone
              target:self
-             action:@selector(closeSettings)] autorelease];
+             action:@selector(closeSettings)];
 }
 
 - (UIInterfaceOrientationMask)supportedInterfaceOrientations {
   return [self.topViewController supportedInterfaceOrientations];
 }
 
 - (BOOL)shouldAutorotate {
   return [self.topViewController shouldAutorotate];
 }
 
@@ skipping 94 matching lines @@
       // Executing it on the wrong profile is a privacy issue. Kill the
       // app if this ever happens.
       CHECK_EQ(commandBrowserState, [self mainBrowserState]);
       break;
     }
     case IDC_RESET_ALL_WEBVIEWS:
       // The command to reset all webview is not related to the browser state so
       // it can just be forwarded it up the responder chain.
       break;
     case IDC_SHOW_ACCOUNTS_SETTINGS: {
-      base::scoped_nsobject<UIViewController> controller(
-          [[AccountsCollectionViewController alloc]
-                   initWithBrowserState:mainBrowserState_
-              closeSettingsOnAddAccount:NO]);
+      UIViewController* controller = [[AccountsCollectionViewController alloc]
+               initWithBrowserState:mainBrowserState_
+          closeSettingsOnAddAccount:NO];
       [self pushViewController:controller animated:YES];
       return;
     }
     case IDC_SHOW_SYNC_SETTINGS: {
-      base::scoped_nsobject<UIViewController> controller(
+      UIViewController* controller =
           [[SyncSettingsCollectionViewController alloc]
                 initWithBrowserState:mainBrowserState_
-              allowSwitchSyncAccount:YES]);
+              allowSwitchSyncAccount:YES];
       [self pushViewController:controller animated:YES];
       return;
     }
     case IDC_SHOW_SYNC_PASSPHRASE_SETTINGS: {
-      base::scoped_nsobject<UIViewController> controller(
+      UIViewController* controller =
           [[SyncEncryptionPassphraseCollectionViewController alloc]
-              initWithBrowserState:mainBrowserState_]);
+              initWithBrowserState:mainBrowserState_];
       [self pushViewController:controller animated:YES];
       return;
     }
     default:
       NOTREACHED()
           << "Unexpected command " << [sender tag]
           << " Settings commands must execute on the main browser state.";
   }
   [[self nextResponder] chromeExecuteCommand:sender];
 }
 
 #pragma mark - UIResponder
 
 - (NSArray*)keyCommands {
   if ([self presentedViewController]) {
     return nil;
   }
-  base::WeakNSObject<SettingsNavigationController> weakSelf(self);
+  __weak SettingsNavigationController* weakSelf = self;
   return @[
     [UIKeyCommand cr_keyCommandWithInput:UIKeyInputEscape
                            modifierFlags:Cr_UIKeyModifierNone
                                    title:nil
                                   action:^{
                                     [weakSelf closeSettings];
                                   }],
   ];
 }
 
@@ skipping 27 matching lines @@
 #pragma mark - AppBar Containment
 
 // If viewController doesn't implement the AppBarPresenting protocol, it is
 // wrapped in an MDCAppBarContainerViewController, which is returned. Otherwise,
 // viewController is returned.
 - (UIViewController*)wrappedControllerIfNeeded:(UIViewController*)controller {
   // If the controller can't be presented with an app bar, it needs to be
   // wrapped in an MDCAppBarContainerViewController.
   if (![controller conformsToProtocol:@protocol(AppBarPresenting)]) {
     MDCAppBarContainerViewController* appBarContainer =
-        [[[SettingsAppBarContainerViewController alloc]
-            initWithContentViewController:controller] autorelease];
+        [[SettingsAppBarContainerViewController alloc]
+            initWithContentViewController:controller];
 
     // Configure the style.
     ConfigureAppBarWithCardStyle(appBarContainer.appBar);
 
     // Adjust the frame of the contained view controller's view to be below the
     // app bar.
     CGRect contentFrame = controller.view.frame;
     CGSize headerSize = [appBarContainer.appBar.headerViewController.headerView
         sizeThatFits:contentFrame.size];
     contentFrame = UIEdgeInsetsInsetRect(
@@ skipping 19 matching lines @@
     return [potentialAppBarController contentViewController];
   } else {
     return controller;
   }
 }
 
 // Adds an app bar container in a dictionary mapping its content view
 // controller's pointer to itself.
 - (void)registerAppBarContainer:(MDCAppBarContainerViewController*)container {
   if (!appBarContainedViewControllers_) {
-    appBarContainedViewControllers_.reset([[NSMutableDictionary alloc] init]);
+    appBarContainedViewControllers_ = [[NSMutableDictionary alloc] init];
   }
   NSValue* key = [self keyForController:[container contentViewController]];
   [appBarContainedViewControllers_ setObject:container forKey:key];
 }
 
 // Removes the app bar container entry from the aforementioned dictionary.
 - (void)unregisterAppBarContainer:(MDCAppBarContainerViewController*)container {
   NSValue* key = [self keyForController:[container contentViewController]];
   [appBarContainedViewControllers_ removeObjectForKey:key];
 }
 
 // Returns the app bar container containing |controller| if it is contained.
 // Otherwise, returns nil.
 - (MDCAppBarContainerViewController*)appBarContainerForController:
     (UIViewController*)controller {
   NSValue* key = [self keyForController:controller];
   return [appBarContainedViewControllers_ objectForKey:key];
 }
 
 // Returns the dictionary key to use when dealing with |controller|.
 - (NSValue*)keyForController:(UIViewController*)controller {
-  return [NSValue valueWithPointer:controller];
+  return [NSValue valueWithNonretainedObject:controller];
 }
 
 #pragma mark - UIResponder
 
 - (BOOL)canBecomeFirstResponder {
   return YES;
 }
 
 @end