[ObjC ARC] Converts ios/chrome/browser/ui/settings:settings to ARC.

ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller.mm

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller.h"
 
 #include <memory>
 
 #include "base/i18n/time_formatting.h"
 #include "base/mac/foundation_util.h"
-#import "base/mac/objc_property_releaser.h"
-#import "base/mac/scoped_nsobject.h"
+
 #include "base/strings/sys_string_conversions.h"
 #include "components/browser_sync/profile_sync_service.h"
 #include "components/google/core/browser/google_util.h"
 #include "components/signin/core/browser/profile_oauth2_token_service.h"
 #import "components/signin/ios/browser/oauth2_token_service_observer_bridge.h"
 #include "components/strings/grit/components_strings.h"
 #include "ios/chrome/browser/application_context.h"
 #include "ios/chrome/browser/browser_state/chrome_browser_state.h"
 #include "ios/chrome/browser/chrome_url_constants.h"
 #import "ios/chrome/browser/signin/authentication_service.h"
@@ skipping 15 matching lines @@
 #import "ios/chrome/browser/ui/sync/sync_util.h"
 #import "ios/chrome/browser/ui/uikit_ui_util.h"
 #include "ios/chrome/grit/ios_strings.h"
 #import "ios/public/provider/chrome/browser/signin/chrome_identity.h"
 #import "ios/third_party/material_components_ios/src/components/Typography/src/MaterialTypography.h"
 #import "ios/third_party/material_roboto_font_loader_ios/src/src/MaterialRobotoFontLoader.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/l10n/l10n_util_mac.h"
 #include "url/gurl.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
 using namespace ios_internal::sync_encryption_passphrase;
 
 namespace {
 
 const CGFloat kSpinnerButtonCustomViewSize = 48;
 const CGFloat kSpinnerButtonPadding = 18;
 
 }  // namespace
 
 @interface SyncEncryptionPassphraseCollectionViewController ()<
     OAuth2TokenServiceObserverBridgeDelegate,
     SettingsControllerProtocol> {
   ios::ChromeBrowserState* browserState_;
   // Whether the decryption progress is currently being shown.
   BOOL isDecryptionProgressShown_;
-  base::scoped_nsobject<NSString> savedTitle_;
-  base::scoped_nsobject<UIBarButtonItem> savedLeftButton_;
+  NSString* savedTitle_;
+  UIBarButtonItem* savedLeftButton_;
   std::unique_ptr<SyncObserverBridge> syncObserver_;
   std::unique_ptr<OAuth2TokenServiceObserverBridge> tokenServiceObserver_;
-  base::scoped_nsobject<UITextField> passphrase_;
-  base::mac::ObjCPropertyReleaser
-      propertyReleaser_SyncEncryptionPassphraseCollectionViewController_;
+  UITextField* passphrase_;
 }
 
 // Sets up the navigation bar's right button. The button will be enabled iff
 // |-areAllFieldsFilled| returns YES.
 - (void)setRightNavBarItem;
 
 // Returns a passphrase message item.
 - (CollectionViewItem*)passphraseMessageItem;
 
 // Returns a passphrase item.
@@ skipping 49 matching lines @@
       } else {
         self.headerMessage = l10n_util::GetNSStringF(
             IDS_IOS_SYNC_ENTER_PASSPHRASE_BODY_WITH_EMAIL,
             base::SysNSStringToUTF16(userEmail));
       }
     } else {
       self.headerMessage =
           l10n_util::GetNSString(IDS_SYNC_ENTER_GOOGLE_PASSPHRASE_BODY);
     }
     self.processingMessage = l10n_util::GetNSString(IDS_SYNC_LOGIN_SETTING_UP);
-    footerMessage_ =
-        [l10n_util::GetNSString(IDS_IOS_SYNC_PASSPHRASE_RECOVER) retain];
+    footerMessage_ = l10n_util::GetNSString(IDS_IOS_SYNC_PASSPHRASE_RECOVER);
 
     tokenServiceObserver_.reset(new OAuth2TokenServiceObserverBridge(
         OAuth2TokenServiceFactory::GetForBrowserState(browserState_), self));
 
-    propertyReleaser_SyncEncryptionPassphraseCollectionViewController_.Init(
-        self, [SyncEncryptionPassphraseCollectionViewController class]);
-
     [self loadModel];
   }
   return self;
 }
 
 - (UITextField*)passphrase {
   return passphrase_;
 }
 
 - (NSString*)syncErrorMessage {
@@ skipping 15 matching lines @@
 #pragma mark - View lifecycle
 
 - (void)viewDidLoad {
   [super viewDidLoad];
   [self setRightNavBarItem];
 }
 
 - (void)didReceiveMemoryWarning {
   [super didReceiveMemoryWarning];
   if (![self isViewLoaded]) {
-    passphrase_.reset();
+    passphrase_ = nil;
   }
 }
 
 - (void)viewWillDisappear:(BOOL)animated {
   [super viewWillDisappear:animated];
   [self.passphrase resignFirstResponder];
 }
 
 - (void)viewDidDisappear:(BOOL)animated {
   [super viewDidDisappear:animated];
@@ skipping 25 matching lines @@
   // section, to work around a drawing bug in MDC.
   [model addSectionWithIdentifier:SectionIdentifierFooter];
   [model addItem:[self footerItem]
       toSectionWithIdentifier:SectionIdentifierFooter];
 }
 
 #pragma mark - Items
 
 - (CollectionViewItem*)passphraseMessageItem {
   CardMultilineItem* item =
-      [[[CardMultilineItem alloc] initWithType:ItemTypeMessage] autorelease];
+      [[CardMultilineItem alloc] initWithType:ItemTypeMessage];
   item.text = headerMessage_;
   return item;
 }
 
 - (CollectionViewItem*)passphraseItem {
   if (passphrase_) {
     [self unregisterTextField:passphrase_];
   }
-  passphrase_.reset([[UITextField alloc] init]);
+  passphrase_ = [[UITextField alloc] init];
   [passphrase_ setFont:[MDCTypography body1Font]];
   [passphrase_ setSecureTextEntry:YES];
   [passphrase_ setBackgroundColor:[UIColor clearColor]];
   [passphrase_ setAutoresizingMask:UIViewAutoresizingFlexibleWidth];
   [passphrase_ setAutocorrectionType:UITextAutocorrectionTypeNo];
   [passphrase_
       setPlaceholder:l10n_util::GetNSString(IDS_SYNC_PASSPHRASE_LABEL)];
   [self registerTextField:passphrase_];
 
-  BYOTextFieldItem* item = [[[BYOTextFieldItem alloc]
-      initWithType:ItemTypeEnterPassphrase] autorelease];
+  BYOTextFieldItem* item =
+      [[BYOTextFieldItem alloc] initWithType:ItemTypeEnterPassphrase];
   item.textField = passphrase_;
   return item;
 }
 
 - (CollectionViewItem*)passphraseErrorItemWithMessage:(NSString*)errorMessage {
   PassphraseErrorItem* item =
-      [[[PassphraseErrorItem alloc] initWithType:ItemTypeError] autorelease];
+      [[PassphraseErrorItem alloc] initWithType:ItemTypeError];
   item.text = errorMessage;
   return item;
 }
 
 - (CollectionViewItem*)footerItem {
-  CollectionViewFooterItem* footerItem = [[[CollectionViewFooterItem alloc]
-      initWithType:ItemTypeFooter] autorelease];
+  CollectionViewFooterItem* footerItem =
+      [[CollectionViewFooterItem alloc] initWithType:ItemTypeFooter];
   footerItem.text = self.footerMessage;
   footerItem.linkURL = google_util::AppendGoogleLocaleParam(
       GURL(kSyncGoogleDashboardURL),
       GetApplicationContext()->GetApplicationLocale());
   footerItem.linkDelegate = self;
   return footerItem;
 }
 
 #pragma mark - MDCCollectionViewStylingDelegate
 
@@ skipping 109 matching lines @@
     service->EnableEncryptEverything();
     service->SetEncryptionPassphrase(
         passphrase, browser_sync::ProfileSyncService::EXPLICIT);
   }
   [self reloadData];
 }
 
 - (void)setRightNavBarItem {
   UIBarButtonItem* submitButtonItem = self.navigationItem.rightBarButtonItem;
   if (!submitButtonItem) {
-    submitButtonItem = [[[UIBarButtonItem alloc]
+    submitButtonItem = [[UIBarButtonItem alloc]
         initWithTitle:l10n_util::GetNSString(IDS_IOS_SYNC_DECRYPT_BUTTON)
                 style:UIBarButtonItemStylePlain
                target:self
-               action:@selector(signInPressed)] autorelease];
+               action:@selector(signInPressed)];
   }
   submitButtonItem.enabled = [self areAllFieldsFilled];
 
   // Only setting the enabled state doesn't make the item redraw. As a
   // workaround, set it again.
   self.navigationItem.rightBarButtonItem = submitButtonItem;
 }
 
 - (BOOL)areAllFieldsFilled {
   return [self.passphrase text].length > 0;
 }
 
 - (void)clearFieldsOnError:(NSString*)errorMessage {
   self.syncErrorMessage = errorMessage;
   [self.passphrase setText:@""];
 }
 
 - (void)showDecryptionProgress {
   if (isDecryptionProgressShown_)
     return;
   isDecryptionProgressShown_ = YES;
 
   // Hide the button.
   self.navigationItem.rightBarButtonItem = nil;
 
   // Custom title view with spinner.
   DCHECK(!savedTitle_);
   DCHECK(!savedLeftButton_);
-  savedLeftButton_.reset([self.navigationItem.leftBarButtonItem retain]);
+  savedLeftButton_ = self.navigationItem.leftBarButtonItem;
   self.navigationItem.leftBarButtonItem = [self spinnerButton];
-  savedTitle_.reset([self.title copy]);
+  savedTitle_ = [self.title copy];
   self.title = processingMessage_;
 }
 
 - (void)hideDecryptionProgress {
   if (!isDecryptionProgressShown_)
     return;
   isDecryptionProgressShown_ = NO;
 
-  self.navigationItem.leftBarButtonItem = savedLeftButton_.autorelease();
-  self.title = savedTitle_.autorelease();
+  self.navigationItem.leftBarButtonItem = savedLeftButton_ = nil;

[lpromero, 2017/06/15 08:31:49]

Wow. That's a bad one (idem below). We should make a pass on the entire code
base to see if this happened somewhere else.

+  self.title = savedTitle_ = nil;
   [self setRightNavBarItem];
 }
 
 - (void)registerTextField:(UITextField*)textField {
   [textField addTarget:self
                 action:@selector(textFieldDidBeginEditing:)
       forControlEvents:UIControlEventEditingDidBegin];
   [textField addTarget:self
                 action:@selector(textFieldDidChange:)
       forControlEvents:UIControlEventEditingChanged];
@@ skipping 10 matching lines @@
                    action:@selector(textFieldDidChange:)
          forControlEvents:UIControlEventEditingChanged];
   [textField removeTarget:self
                    action:@selector(textFieldDidEndEditing:)
          forControlEvents:UIControlEventEditingDidEndOnExit];
 }
 
 - (UIBarButtonItem*)spinnerButton {
   CGRect customViewFrame = CGRectMake(0, 0, kSpinnerButtonCustomViewSize,
                                       kSpinnerButtonCustomViewSize);
-  base::scoped_nsobject<UIView> customView(
-      [[UIView alloc] initWithFrame:customViewFrame]);
+  UIView* customView = [[UIView alloc] initWithFrame:customViewFrame];
 
-  base::scoped_nsobject<UIActivityIndicatorView> spinner(
-      [[UIActivityIndicatorView alloc]
-          initWithActivityIndicatorStyle:UIActivityIndicatorViewStyleGray]);
+  UIActivityIndicatorView* spinner = [[UIActivityIndicatorView alloc]
+      initWithActivityIndicatorStyle:UIActivityIndicatorViewStyleGray];
 
   CGRect spinnerFrame = [spinner bounds];
   spinnerFrame.origin.x = kSpinnerButtonPadding;
   spinnerFrame.origin.y = kSpinnerButtonPadding;
   [spinner setFrame:spinnerFrame];
   [customView addSubview:spinner];
 
-  base::scoped_nsobject<UIBarButtonItem> leftBarButtonItem(
-      [[UIBarButtonItem alloc] initWithCustomView:customView]);
+  UIBarButtonItem* leftBarButtonItem =
+      [[UIBarButtonItem alloc] initWithCustomView:customView];
 
   [spinner setHidesWhenStopped:NO];
   [spinner startAnimating];
 
-  return leftBarButtonItem.autorelease();
+  return leftBarButtonItem = nil;
 }
 
 - (void)stopObserving {
   // Stops observing the sync service. This is required during the shutdown
   // phase to avoid observing sync events for a browser state that is being
   // killed.
   syncObserver_.reset();
   tokenServiceObserver_.reset();
 }
 
@@ skipping 72 matching lines @@
       self.navigationController) popViewControllerOrCloseSettingsAnimated:NO];
 }
 
 #pragma mark - SettingsControllerProtocol callbacks
 
 - (void)settingsWillBeDismissed {
   [self stopObserving];
 }
 
 @end