Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControlElements.h

Issue 2813103006: Media Controls: move last buttons to modules/. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
index 1b2bbde01771d9b37f78295f2f93af5b83550fd9..de59f4bbd31cee6d865ec248e8cb2696dc7de11c 100644
--- a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
+++ b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
@@ -32,52 +32,9 @@
#include "core/html/shadow/MediaControlElementTypes.h"
#include "core/html/shadow/MediaControlTimelineMetrics.h"
-#include "public/platform/WebLocalizedString.h"
namespace blink {
-// Represents a button that allows users to download media if the file is
-// downloadable.
-class CORE_EXPORT MediaControlDownloadButtonElement final
- : public MediaControlInputElement {
- public:
- static MediaControlDownloadButtonElement* Create(MediaControls&);
-
- WebLocalizedString::Name GetOverflowStringName() override;
-
- bool HasOverflowButton() override { return true; }
-
- // Returns true if the download button should be shown. We should
- // show the button for only non-MSE, non-EME, and non-MediaStream content.
- bool ShouldDisplayDownloadButton();
-
- void SetIsWanted(bool) override;
-
- DECLARE_VIRTUAL_TRACE();
-
- private:
- explicit MediaControlDownloadButtonElement(MediaControls&);
-
- void DefaultEventHandler(Event*) override;
-
- // Points to an anchor element that contains the URL of the media file.
- Member<HTMLAnchorElement> anchor_;
-
- // This is used for UMA histogram (Media.Controls.Download). New values should
- // be appended only and must be added before |Count|.
- enum class DownloadActionMetrics {
- kShown = 0,
- kClicked,
- kCount // Keep last.
- };
- void RecordMetrics(DownloadActionMetrics);
-
- // UMA related boolean. They are used to prevent counting something twice
- // for the same media element.
- bool click_use_counted_ = false;
- bool show_use_counted_ = false;
-};
-
class CORE_EXPORT MediaControlTimelineElement final
: public MediaControlInputElement {
public:
@@ -107,51 +64,6 @@ class CORE_EXPORT MediaControlTimelineElement final
// ----------------------------
-class CORE_EXPORT MediaControlCastButtonElement final
- : public MediaControlInputElement {
- public:
- static MediaControlCastButtonElement* Create(MediaControls&,
- bool is_overlay_button);
-
- bool WillRespondToMouseClickEvents() override { return true; }
-
- void SetIsPlayingRemotely(bool);
-
- WebLocalizedString::Name GetOverflowStringName() override;
-
- bool HasOverflowButton() override { return true; }
-
- // This will show a cast button if it is not covered by another element.
- // This MUST be called for cast button elements that are overlay elements.
- void TryShowOverlay();
-
- private:
- explicit MediaControlCastButtonElement(MediaControls&,
- bool is_overlay_button);
-
- void DefaultEventHandler(Event*) override;
- bool KeepEventInNode(Event*) override;
-
- bool is_overlay_button_;
-
- // This is used for UMA histogram (Cast.Sender.Overlay). New values should
- // be appended only and must be added before |Count|.
- enum class CastOverlayMetrics {
- kCreated = 0,
- kShown,
- kClicked,
- kCount // Keep last.
- };
- void RecordMetrics(CastOverlayMetrics);
-
- // UMA related boolean. They are used to prevent counting something twice
- // for the same media element.
- bool click_use_counted_ = false;
- bool show_use_counted_ = false;
-};
-
-// ----------------------------
-
class CORE_EXPORT MediaControlVolumeSliderElement final
: public MediaControlInputElement {
public:
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698