Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5801)

Unified Diff: chrome/browser/ui/webui/extensions/extension_loader_handler.cc

Issue 2812953002: Stop passing raw pointers to base::Value API in c/b/ui (Closed)
Patch Set: Rebased Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/extension_loader_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/extension_loader_handler.cc b/chrome/browser/ui/webui/extensions/extension_loader_handler.cc
index f85d09dcae0c8da2418ede3428ef9248f182f48b..1ff867077b1f4bc79cda1c57bbde6fa1cd171633 100644
--- a/chrome/browser/ui/webui/extensions/extension_loader_handler.cc
+++ b/chrome/browser/ui/webui/extensions/extension_loader_handler.cc
@@ -9,12 +9,14 @@
#include "base/bind.h"
#include "base/files/file_util.h"
#include "base/logging.h"
+#include "base/memory/ptr_util.h"
#include "base/memory/ref_counted.h"
#include "base/strings/string16.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "base/task_scheduler/post_task.h"
+#include "base/values.h"
#include "chrome/browser/extensions/path_util.h"
#include "chrome/browser/extensions/unpacked_installer.h"
#include "chrome/browser/profiles/profile.h"
@@ -205,9 +207,11 @@ void ExtensionLoaderHandler::AddFailure(
highlighter.SetHighlightedRegions(manifest_value.get());
std::unique_ptr<base::DictionaryValue> failure(new base::DictionaryValue());
- failure->Set("path", new base::Value(prettified_path.LossyDisplayName()));
- failure->Set("error", new base::Value(base::UTF8ToUTF16(error)));
- failure->Set("manifest", manifest_value.release());
+ failure->Set("path", base::MakeUnique<base::Value>(
jdoerrie 2017/04/13 09:08:51 SetString
vabr (Chromium) 2017/04/13 12:03:14 Done.
+ prettified_path.LossyDisplayName()));
+ failure->Set("error",
jdoerrie 2017/04/13 09:08:51 SetString
vabr (Chromium) 2017/04/13 12:03:14 Done.
+ base::MakeUnique<base::Value>(base::UTF8ToUTF16(error)));
+ failure->Set("manifest", std::move(manifest_value));
failures_.Append(std::move(failure));
// Only notify the frontend if the frontend UI is ready.

Powered by Google App Engine
This is Rietveld 408576698