Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/webui/flags_ui.cc

Issue 2812953002: Stop passing raw pointers to base::Value API in c/b/ui (Closed)
Patch Set: Rebased Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/webui/extensions/extension_loader_handler.cc ('K') | « chrome/browser/ui/webui/extensions/extension_loader_handler.cc ('k') | chrome/browser/ui/webui/flash_ui.cc » ('j') | chrome/browser/ui/webui/instant_ui.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/flags_ui.cc
diff --git a/chrome/browser/ui/webui/flags_ui.cc b/chrome/browser/ui/webui/flags_ui.cc
index 5a892e39f2ed465ae4e9be87b5f44dd526909d36..75eae5aeb3cd3650ca4a0606a6daab0df7878c73 100644
--- a/chrome/browser/ui/webui/flags_ui.cc
+++ b/chrome/browser/ui/webui/flags_ui.cc
@@ -192,8 +192,8 @@ void FlagsDOMHandler::HandleRequestExperimentalFeatures(
access_,
supported_features.get(),
unsupported_features.get());
- results.Set(flags_ui::kSupportedFeatures, supported_features.release());
- results.Set(flags_ui::kUnsupportedFeatures, unsupported_features.release());
+ results.Set(flags_ui::kSupportedFeatures, std::move(supported_features));
+ results.Set(flags_ui::kUnsupportedFeatures, std::move(unsupported_features));
results.SetBoolean(flags_ui::kNeedsRestart,
about_flags::IsRestartNeededToCommitChanges());
results.SetBoolean(flags_ui::kShowOwnerWarning,
« chrome/browser/ui/webui/extensions/extension_loader_handler.cc ('K') | « chrome/browser/ui/webui/extensions/extension_loader_handler.cc ('k') | chrome/browser/ui/webui/flash_ui.cc » ('j') | chrome/browser/ui/webui/instant_ui.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698