Stop passing raw pointers to base::Value API in c/b/ui

chrome/browser/ui/webui/extensions/extension_loader_handler.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/extensions/extension_loader_handler.h"
 
 #include <utility>

[jdoerrie, 2017/04/13 09:08:51]

#include <memory>

[vabr (Chromium), 2017/04/13 12:03:14]

Done.

 
 #include "base/bind.h"
 #include "base/files/file_util.h"
 #include "base/logging.h"
+#include "base/memory/ptr_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/task_scheduler/post_task.h"
+#include "base/values.h"
 #include "chrome/browser/extensions/path_util.h"
 #include "chrome/browser/extensions/unpacked_installer.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/grit/generated_resources.h"
 #include "content/public/browser/navigation_handle.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_ui.h"
 #include "content/public/browser/web_ui_data_source.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/browser/file_highlighter.h"
@@ skipping 170 matching lines @@
   base::FilePath prettified_path = path_util::PrettifyPath(file_path);
 
   std::unique_ptr<base::DictionaryValue> manifest_value(
       new base::DictionaryValue());
   SourceHighlighter highlighter(manifest, line_number);
   // If the line number is 0, this highlights no regions, but still adds the
   // full manifest.
   highlighter.SetHighlightedRegions(manifest_value.get());
 
   std::unique_ptr<base::DictionaryValue> failure(new base::DictionaryValue());
-  failure->Set("path", new base::Value(prettified_path.LossyDisplayName()));
-  failure->Set("error", new base::Value(base::UTF8ToUTF16(error)));
-  failure->Set("manifest", manifest_value.release());
+  failure->Set("path", base::MakeUnique<base::Value>(

[jdoerrie, 2017/04/13 09:08:51]

SetString

[vabr (Chromium), 2017/04/13 12:03:14]

Done.

+                           prettified_path.LossyDisplayName()));
+  failure->Set("error",

[jdoerrie, 2017/04/13 09:08:51]

SetString

[vabr (Chromium), 2017/04/13 12:03:14]

Done.

+               base::MakeUnique<base::Value>(base::UTF8ToUTF16(error)));
+  failure->Set("manifest", std::move(manifest_value));
   failures_.Append(std::move(failure));
 
   // Only notify the frontend if the frontend UI is ready.
   if (ui_ready_)
     NotifyFrontendOfFailure();
 }
 
 void ExtensionLoaderHandler::NotifyFrontendOfFailure() {
   web_ui()->CallJavascriptFunctionUnsafe(
       "extensions.ExtensionLoader.notifyLoadFailed", failures_);
   failures_.Clear();
 }
 
 }  // namespace extensions