chrome/browser/ui/webui/chromeos/power_ui.cc - Issue 2812953002: Stop passing raw pointers to base::Value API in c/b/ui

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chromeos/power_ui.cc

Issue 2812953002: Stop passing raw pointers to base::Value API in c/b/ui (Closed)

Patch Set: Rebased Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/chromeos/power_ui.cc

diff --git a/chrome/browser/ui/webui/chromeos/power_ui.cc b/chrome/browser/ui/webui/chromeos/power_ui.cc

index 70cfa00108876ab2e416f9e6f5860fbc79b7adf5..523a169b9486bd541352b7405f7985e1c415d202 100644

--- a/chrome/browser/ui/webui/chromeos/power_ui.cc

+++ b/chrome/browser/ui/webui/chromeos/power_ui.cc

@@ -177,7 +177,7 @@ void PowerMessageHandler::GetJsStateOccupancyData(

state_dict->SetDouble(state_names[index],

static_cast<double>(sample.time_in_state[index]));

}

- js_sample->Set("timeInState", state_dict.release());

+ js_sample->Set("timeInState", std::move(state_dict));

js_sample_list->Append(std::move(js_sample));

}