Revert of [scheduler] Add TaskQueue::Observer

Revert of [scheduler] Add TaskQueue::Observer (patchset #6 id:100001 of https://codereview.chromium.org/2798563003/ )

Reason for revert:
This regresses loading of some websites.

Original issue's description:
> [scheduler] Add TaskQueue::Observer
> 
> Remove TimeDomain::Observer and replace it with TaskQueue::Observer,
> which provides notifications about change of wakeups.
> 
> R=skyostil@chromium.org
> CC=skyostil@chromium.org
> BUG=699541
> 
> Review-Url: https://codereview.chromium.org/2798563003
> Cr-Commit-Position: refs/heads/master@{#462129}
> Committed: https://chromium.googlesource.com/chromium/src/+/eafdfdb6623fccf2b2733d286f1e9a29d9784f66

TBR=skyostil@chromium.org,dgozman@chromium.org,alexclarke@chromium.org,altimin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=699541, 710095
Review-Url: https://codereview.chromium.org/2812703002
Cr-Commit-Position: refs/heads/master@{#463445}
Committed: https://chromium.googlesource.com/chromium/src/+/ba9363ef7982baf4624b1c9e88cb691e7ce5eed3

[robliao, 2017-04-10 19:16:37]

Created Revert of [scheduler] Add TaskQueue::Observer

[robliao, 2017-04-10 19:16:49]

Description was changed from

==========
Revert of [scheduler] Add TaskQueue::Observer (patchset #6 id:100001 of
https://codereview.chromium.org/2798563003/ )

Reason for revert:
This regresses loading of some websites.

Original issue's description:
> [scheduler] Add TaskQueue::Observer
> 
> Remove TimeDomain::Observer and replace it with TaskQueue::Observer,
> which provides notifications about change of wakeups.
> 
> R=skyostil@chromium.org
> CC=skyostil@chromium.org
> BUG=699541
> 
> Review-Url: https://codereview.chromium.org/2798563003
> Cr-Commit-Position: refs/heads/master@{#462129}
> Committed:
https://chromium.googlesource.com/chromium/src/+/eafdfdb6623fccf2b2733d286f1e...

TBR=skyostil@chromium.org,dgozman@chromium.org,alexclarke@chromium.org,altimi...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=699541
==========

to

==========
Revert of [scheduler] Add TaskQueue::Observer (patchset #6 id:100001 of
https://codereview.chromium.org/2798563003/ )

Reason for revert:
This regresses loading of some websites.

Original issue's description:
> [scheduler] Add TaskQueue::Observer
> 
> Remove TimeDomain::Observer and replace it with TaskQueue::Observer,
> which provides notifications about change of wakeups.
> 
> R=skyostil@chromium.org
> CC=skyostil@chromium.org
> BUG=699541
> 
> Review-Url: https://codereview.chromium.org/2798563003
> Cr-Commit-Position: refs/heads/master@{#462129}
> Committed:
https://chromium.googlesource.com/chromium/src/+/eafdfdb6623fccf2b2733d286f1e...

TBR=skyostil@chromium.org,dgozman@chromium.org,alexclarke@chromium.org,altimi...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=699541,710095
==========

[robliao, 2017-04-10 19:16:59]

The CQ bit was checked by robliao@chromium.org

[commit-bot: I haz the power, 2017-04-10 19:17:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 19:20:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 19:20:49]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[robliao, 2017-04-10 19:22:33]

On 2017/04/10 19:20:49, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   ios-device on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
>   ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
>   ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
>   mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Well that's exciting. The patch reverted successfully for me locally.

[robliao, 2017-04-10 19:49:57]

On 2017/04/10 19:22:33, robliao wrote:
> On 2017/04/10 19:20:49, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   ios-device on master.tryserver.chromium.mac (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
> >   ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
> >   ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
> >   mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
> 
> Well that's exciting. The patch reverted successfully for me locally.

Manual revert in progress (building the world). Looks like I got unlucky.
This took place which created most of the conflicts (Large blink rename)
https://chromium.googlesource.com/chromium/src/+/1c4d759e44259650dfb2c426a7f9...

For future changes, please separate refactors from the actual change.

This prevents conflicts like this:
<<<<<<< HEAD
 thread_->PostIdleTask(BLINK_FROM_HERE, task.release());
 // We need to post a wake-up task or idle work will never happen.
 thread_->GetWebTaskRunner()->PostDelayedTask(BLINK_FROM_HERE,
                                              WTF::Bind([] {}), 50ll);
=======
 thread_->postIdleTask(BLINK_FROM_HERE, task.release());
 // We need to post a wakeup task or idle work will never happen.
 thread_->getWebTaskRunner()->postDelayedTask(BLINK_FROM_HERE,
                                              WTF::bind([] {}), 50ll);
>>>>>>> Revert "[scheduler] Add TaskQueue::Observer"

<<<<<<< HEAD
  // If |queue| is the first wake-up then request the wake-up.
  if (delayed_wake_up_queue_.Min().queue == queue)
    RequestWakeUpAt(now, wake_up.time);
=======
  // If |queue| is the first wakeup then request the wakeup.
  if (delayed_wakeup_queue_.min().queue == queue)
    RequestWakeupAt(now, wake_up.time);

  if (observer_)
    observer_->OnTimeDomainHasDelayedWork(queue);
}

void TimeDomain::OnQueueHasImmediateWork(internal::TaskQueueImpl* queue) {
  if (observer_)
    observer_->OnTimeDomainHasImmediateWork(queue);
>>>>>>> Revert "[scheduler] Add TaskQueue::Observer"

<<<<<<< HEAD
  *out_task_queue = delayed_wake_up_queue_.Min().queue;
=======
  *out_task_queue = delayed_wakeup_queue_.min().queue;
>>>>>>> Revert "[scheduler] Add TaskQueue::Observer"

And many more.

[altimin, 2017-04-10 20:08:14]

On 2017/04/10 19:49:57, robliao wrote:
> On 2017/04/10 19:22:33, robliao wrote:
> > On 2017/04/10 19:20:49, commit-bot: I haz the power wrote:
> > > Try jobs failed on following builders:
> > >   ios-device on master.tryserver.chromium.mac (JOB_FAILED,
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
> > >   ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
> > >   ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
> > >   mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
> > 
> > Well that's exciting. The patch reverted successfully for me locally.
> 
> Manual revert in progress (building the world). Looks like I got unlucky.
> This took place which created most of the conflicts (Large blink rename)
>
https://chromium.googlesource.com/chromium/src/+/1c4d759e44259650dfb2c426a7f9...
> 
> For future changes, please separate refactors from the actual change.
> 
> This prevents conflicts like this:
> <<<<<<< HEAD
>  thread_->PostIdleTask(BLINK_FROM_HERE, task.release());
>  // We need to post a wake-up task or idle work will never happen.
>  thread_->GetWebTaskRunner()->PostDelayedTask(BLINK_FROM_HERE,
>                                               WTF::Bind([] {}), 50ll);
> =======
>  thread_->postIdleTask(BLINK_FROM_HERE, task.release());
>  // We need to post a wakeup task or idle work will never happen.
>  thread_->getWebTaskRunner()->postDelayedTask(BLINK_FROM_HERE,
>                                               WTF::bind([] {}), 50ll);
> >>>>>>> Revert "[scheduler] Add TaskQueue::Observer"
> 
> <<<<<<< HEAD
>   // If |queue| is the first wake-up then request the wake-up.
>   if (delayed_wake_up_queue_.Min().queue == queue)
>     RequestWakeUpAt(now, wake_up.time);
> =======
>   // If |queue| is the first wakeup then request the wakeup.
>   if (delayed_wakeup_queue_.min().queue == queue)
>     RequestWakeupAt(now, wake_up.time);
> 
>   if (observer_)
>     observer_->OnTimeDomainHasDelayedWork(queue);
> }
> 
> void TimeDomain::OnQueueHasImmediateWork(internal::TaskQueueImpl* queue) {
>   if (observer_)
>     observer_->OnTimeDomainHasImmediateWork(queue);
> >>>>>>> Revert "[scheduler] Add TaskQueue::Observer"
> 
> <<<<<<< HEAD
>   *out_task_queue = delayed_wake_up_queue_.Min().queue;
> =======
>   *out_task_queue = delayed_wakeup_queue_.min().queue;
> >>>>>>> Revert "[scheduler] Add TaskQueue::Observer"
> 
> And many more.

Yeah, sorry, did that as a response to a comment in the review.

[robliao, 2017-04-10 22:03:20]

The CQ bit was checked by robliao@chromium.org

[commit-bot: I haz the power, 2017-04-10 22:04:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 23:40:26]

CQ is committing da patch.

Bot data: {"patchset_id": 280001, "attempt_start_ts": 1491861800915320,
"parent_rev": "11cf8db913c11ee87ed08bdd853427fc7c23fe67", "commit_rev":
"ba9363ef7982baf4624b1c9e88cb691e7ce5eed3"}

[commit-bot: I haz the power, 2017-04-10 23:41:27]

Description was changed from

==========
Revert of [scheduler] Add TaskQueue::Observer (patchset #6 id:100001 of
https://codereview.chromium.org/2798563003/ )

Reason for revert:
This regresses loading of some websites.

Original issue's description:
> [scheduler] Add TaskQueue::Observer
> 
> Remove TimeDomain::Observer and replace it with TaskQueue::Observer,
> which provides notifications about change of wakeups.
> 
> R=skyostil@chromium.org
> CC=skyostil@chromium.org
> BUG=699541
> 
> Review-Url: https://codereview.chromium.org/2798563003
> Cr-Commit-Position: refs/heads/master@{#462129}
> Committed:
https://chromium.googlesource.com/chromium/src/+/eafdfdb6623fccf2b2733d286f1e...

TBR=skyostil@chromium.org,dgozman@chromium.org,alexclarke@chromium.org,altimi...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=699541,710095
==========

to

==========
Revert of [scheduler] Add TaskQueue::Observer (patchset #6 id:100001 of
https://codereview.chromium.org/2798563003/ )

Reason for revert:
This regresses loading of some websites.

Original issue's description:
> [scheduler] Add TaskQueue::Observer
> 
> Remove TimeDomain::Observer and replace it with TaskQueue::Observer,
> which provides notifications about change of wakeups.
> 
> R=skyostil@chromium.org
> CC=skyostil@chromium.org
> BUG=699541
> 
> Review-Url: https://codereview.chromium.org/2798563003
> Cr-Commit-Position: refs/heads/master@{#462129}
> Committed:
https://chromium.googlesource.com/chromium/src/+/eafdfdb6623fccf2b2733d286f1e...

TBR=skyostil@chromium.org,dgozman@chromium.org,alexclarke@chromium.org,altimi...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=699541,710095

Review-Url: https://codereview.chromium.org/2812703002
Cr-Commit-Position: refs/heads/master@{#463445}
Committed:
https://chromium.googlesource.com/chromium/src/+/ba9363ef7982baf4624b1c9e88cb...
==========

[commit-bot: I haz the power, 2017-04-10 23:41:28]

Committed patchset #2 (id:280001) as
https://chromium.googlesource.com/chromium/src/+/ba9363ef7982baf4624b1c9e88cb...