Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: content/browser/devtools/protocol/devtools_protocol_browsertest.cc

Issue 2812703002: Revert of [scheduler] Add TaskQueue::Observer (Closed)
Patch Set: Manual Revert Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/scheduler/base/real_time_domain.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/protocol/devtools_protocol_browsertest.cc
diff --git a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
index cf39c7ac1b76a9dee426520e51fec4e983b43215..dc2881488aa79188e496bacc0dc50d72213f4e35 100644
--- a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
+++ b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
@@ -1316,7 +1316,13 @@ IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest,
.size());
}
-IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, VirtualTimeTest) {
+// TODO(701223): Enable this on android.
+#if defined(OS_ANDROID)
+#define MAYBE_VirtualTimeTest DISABLED_VirtualTimeTest
+#else
+#define MAYBE_VirtualTimeTest VirtualTimeTest
+#endif
+IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, MAYBE_VirtualTimeTest) {
NavigateToURLBlockUntilNavigationsComplete(shell(), GURL("about:blank"), 1);
Attach();
@@ -1324,18 +1330,16 @@ IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, VirtualTimeTest) {
params->SetString("policy", "pause");
SendCommand("Emulation.setVirtualTimePolicy", std::move(params), true);
- // TODO(scheduler-dev): Revisit timing when we have strict ordering
- // guarantees.
params.reset(new base::DictionaryValue());
params->SetString("expression",
"setTimeout(function(){console.log('before')}, 1000);"
- "setTimeout(function(){console.log('after')}, 1002);");
+ "setTimeout(function(){console.log('after')}, 1001);");
SendCommand("Runtime.evaluate", std::move(params), true);
// Let virtual time advance for one second.
params.reset(new base::DictionaryValue());
params->SetString("policy", "advance");
- params->SetInteger("budget", 1001);
+ params->SetInteger("budget", 1000);
SendCommand("Emulation.setVirtualTimePolicy", std::move(params), true);
WaitForNotification("Emulation.virtualTimeBudgetExpired");
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/scheduler/base/real_time_domain.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698