[scheduler] Add TaskQueue::Observer

[scheduler] Add TaskQueue::Observer

Remove TimeDomain::Observer and replace it with TaskQueue::Observer,
which provides notifications about change of wakeups.

R=skyostil@chromium.org
CC=skyostil@chromium.org
BUG=699541
Review-Url: https://codereview.chromium.org/2798563003
Cr-Original-Commit-Position: refs/heads/master@{#462129}
Committed: https://chromium.googlesource.com/chromium/src/+/eafdfdb6623fccf2b2733d286f1e9a29d9784f66
Review-Url: https://codereview.chromium.org/2798563003
Cr-Commit-Position: refs/heads/master@{#463755}
Committed: https://chromium.googlesource.com/chromium/src/+/68875cc7e32820645c9cbc8795d98486565848f4

[altimin, 2017-04-04 18:25:56]

PTAL

[altimin, 2017-04-04 18:26:03]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 18:26:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 18:49:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 18:49:03]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[altimin, 2017-04-04 19:00:52]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 19:01:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sami, 2017-04-04 19:07:30]

https://codereview.chromium.org/2798563003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc
(right):

https://codereview.chromium.org/2798563003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc:871: void
TaskQueueImpl::AddObserver(Observer* observer) {
These should probably be just SetObserver since you can't add multiple ones.

https://codereview.chromium.org/2798563003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc:884: void
TaskQueueImpl::TimeDomainScheduleDelayedWork(base::TimeTicks now) {
ScheduleDelayedWorkInTimeDomain to make this read a bit better?

https://codereview.chromium.org/2798563003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc:894: if
(!HasPendingImmediateWork())
nit: braces please

https://codereview.chromium.org/2798563003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.h
(right):

https://codereview.chromium.org/2798563003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.h:344: void
NotifyWakeupChangedOnMainThread(base::TimeTicks wakeup);
nit: s/Wakeup/WakeUp/

https://codereview.chromium.org/2798563003/diff/1/third_party/WebKit/Source/p...
File
third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc
(left):

https://codereview.chromium.org/2798563003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc:198:
// We don't expect this to get called for disabled queues, but we can't DCHECK
Still relevant?

https://codereview.chromium.org/2798563003/diff/1/third_party/WebKit/Source/p...
File
third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc
(right):

https://codereview.chromium.org/2798563003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc:191:
// NOTE: Observer is automatically deleted when unregistering task queue.
s/deleted/unregistered/?

https://codereview.chromium.org/2798563003/diff/1/third_party/WebKit/public/p...
File third_party/WebKit/public/platform/scheduler/base/task_queue.h (right):

https://codereview.chromium.org/2798563003/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/scheduler/base/task_queue.h:36: // work.
Mention which thread this is called on.

[commit-bot: I haz the power, 2017-04-04 19:37:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 19:37:07]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Sami, 2017-04-05 11:24:00]

https://codereview.chromium.org/2798563003/diff/1/third_party/WebKit/public/p...
File third_party/WebKit/public/platform/scheduler/base/task_queue.h (right):

https://codereview.chromium.org/2798563003/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/scheduler/base/task_queue.h:36: // work.
On 2017/04/04 19:07:30, Sami wrote:
> Mention which thread this is called on.

Also, did we wanna specify which functions can be called in the callback (or is
it now everything except for adding/removing observers?)

[altimin, 2017-04-05 11:35:53]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[altimin, 2017-04-05 11:35:58]

PTAL

https://codereview.chromium.org/2798563003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc
(right):

https://codereview.chromium.org/2798563003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc:871: void
TaskQueueImpl::AddObserver(Observer* observer) {
On 2017/04/04 19:07:29, Sami wrote:
> These should probably be just SetObserver since you can't add multiple ones.

Done.

https://codereview.chromium.org/2798563003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc:884: void
TaskQueueImpl::TimeDomainScheduleDelayedWork(base::TimeTicks now) {
On 2017/04/04 19:07:30, Sami wrote:
> ScheduleDelayedWorkInTimeDomain to make this read a bit better?

Done.

https://codereview.chromium.org/2798563003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc:894: if
(!HasPendingImmediateWork())
On 2017/04/04 19:07:29, Sami wrote:
> nit: braces please

Done.

https://codereview.chromium.org/2798563003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.h
(right):

https://codereview.chromium.org/2798563003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.h:344: void
NotifyWakeupChangedOnMainThread(base::TimeTicks wakeup);
On 2017/04/04 19:07:30, Sami wrote:
> nit: s/Wakeup/WakeUp/

Done.

https://codereview.chromium.org/2798563003/diff/1/third_party/WebKit/Source/p...
File
third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc
(left):

https://codereview.chromium.org/2798563003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc:198:
// We don't expect this to get called for disabled queues, but we can't DCHECK
On 2017/04/04 19:07:30, Sami wrote:
> Still relevant?

Done.

https://codereview.chromium.org/2798563003/diff/1/third_party/WebKit/Source/p...
File
third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc
(right):

https://codereview.chromium.org/2798563003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc:191:
// NOTE: Observer is automatically deleted when unregistering task queue.
On 2017/04/04 19:07:30, Sami wrote:
> s/deleted/unregistered/?

Done.

https://codereview.chromium.org/2798563003/diff/1/third_party/WebKit/public/p...
File third_party/WebKit/public/platform/scheduler/base/task_queue.h (right):

https://codereview.chromium.org/2798563003/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/scheduler/base/task_queue.h:36: // work.
On 2017/04/04 19:07:30, Sami wrote:
> Mention which thread this is called on.

Done.

https://codereview.chromium.org/2798563003/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/scheduler/base/task_queue.h:36: // work.
On 2017/04/05 11:24:00, Sami wrote:
> On 2017/04/04 19:07:30, Sami wrote:
> > Mention which thread this is called on.
> 
> Also, did we wanna specify which functions can be called in the callback (or
is
> it now everything except for adding/removing observers?)

Done.

[commit-bot: I haz the power, 2017-04-05 11:36:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[altimin, 2017-04-05 12:04:48]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 12:04:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sami, 2017-04-05 13:16:52]

Thanks!

https://codereview.chromium.org/2798563003/diff/60001/content/browser/devtool...
File content/browser/devtools/protocol/devtools_protocol_browsertest.cc (right):

https://codereview.chromium.org/2798563003/diff/60001/content/browser/devtool...
content/browser/devtools/protocol/devtools_protocol_browsertest.cc:1333: //
TODO(scheduler-dev): Revisit timing when we have strict ordering
Can we now also enable this for Android?

https://codereview.chromium.org/2798563003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc
(right):

https://codereview.chromium.org/2798563003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc:107: <<
"TaskQueue::Observer must be unregistered manually!";
The above DCHECK covers this, right? Looks like this can be removed.

https://codereview.chromium.org/2798563003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc:293: if
(wake_up.time == new_wake_up.time &&
This could use a comment saying what we're doing here. Also, of we already have
a wake-up at |time|, why do we need to schedule another one if just the sequence
number changed?

https://codereview.chromium.org/2798563003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc:428: //
Note we don't scheduled a wake_up for disabled queues.
s/scheduled/schedule/ since you're changing this :)

https://codereview.chromium.org/2798563003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc:873: if
(observer)
nit: braces

https://codereview.chromium.org/2798563003/diff/60001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/scheduler/base/task_queue.h (right):

https://codereview.chromium.org/2798563003/diff/60001/third_party/WebKit/publ...
third_party/WebKit/public/platform/scheduler/base/task_queue.h:34: // Notify
observer that wake_up has changed. |next_wakeup| can be in the
s/wake_up/the time at which this queue wants to run the next task/

https://codereview.chromium.org/2798563003/diff/60001/third_party/WebKit/publ...
third_party/WebKit/public/platform/scheduler/base/task_queue.h:35: // past (e.g.
base::TimeTicks() can be used to notify about immediate
Missing ')'

https://codereview.chromium.org/2798563003/diff/60001/third_party/WebKit/publ...
third_party/WebKit/public/platform/scheduler/base/task_queue.h:167: // Returns
requested run time of next scheduled wake_up for a delayed task
nit: no underscore

https://codereview.chromium.org/2798563003/diff/60001/third_party/WebKit/publ...
File
third_party/WebKit/public/platform/scheduler/child/single_thread_idle_task_runner.h
(right):

https://codereview.chromium.org/2798563003/diff/60001/third_party/WebKit/publ...
third_party/WebKit/public/platform/scheduler/child/single_thread_idle_task_runner.h:74:
// after |delay|.  Note this has after wake_up semantics, i.e. unless
Ditto.

[commit-bot: I haz the power, 2017-04-05 13:21:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 13:21:40]

Dry run: This issue passed the CQ dry run.

[altimin, 2017-04-05 13:55:19]

PTAL

https://codereview.chromium.org/2798563003/diff/60001/content/browser/devtool...
File content/browser/devtools/protocol/devtools_protocol_browsertest.cc (right):

https://codereview.chromium.org/2798563003/diff/60001/content/browser/devtool...
content/browser/devtools/protocol/devtools_protocol_browsertest.cc:1333: //
TODO(scheduler-dev): Revisit timing when we have strict ordering
On 2017/04/05 13:16:51, Sami wrote:
> Can we now also enable this for Android?

Let's ask Alex when he's back.

https://codereview.chromium.org/2798563003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc
(right):

https://codereview.chromium.org/2798563003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc:107: <<
"TaskQueue::Observer must be unregistered manually!";
On 2017/04/05 13:16:51, Sami wrote:
> The above DCHECK covers this, right? Looks like this can be removed.

Done.

https://codereview.chromium.org/2798563003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc:293: if
(wake_up.time == new_wake_up.time &&
On 2017/04/05 13:16:51, Sami wrote:
> This could use a comment saying what we're doing here. Also, of we already
have
> a wake-up at |time|, why do we need to schedule another one if just the
sequence
> number changed?

Done. We need it because we need to update TimeDomain with the latest wakeup or
a DCHECK will fail if we try to replace an old wakeup with the new same one.

https://codereview.chromium.org/2798563003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc:428: //
Note we don't scheduled a wake_up for disabled queues.
On 2017/04/05 13:16:51, Sami wrote:
> s/scheduled/schedule/ since you're changing this :)

Done.

https://codereview.chromium.org/2798563003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc:873: if
(observer)
On 2017/04/05 13:16:51, Sami wrote:
> nit: braces

Done.

https://codereview.chromium.org/2798563003/diff/60001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/scheduler/base/task_queue.h (right):

https://codereview.chromium.org/2798563003/diff/60001/third_party/WebKit/publ...
third_party/WebKit/public/platform/scheduler/base/task_queue.h:34: // Notify
observer that wake_up has changed. |next_wakeup| can be in the
On 2017/04/05 13:16:52, Sami wrote:
> s/wake_up/the time at which this queue wants to run the next task/

Done.

https://codereview.chromium.org/2798563003/diff/60001/third_party/WebKit/publ...
third_party/WebKit/public/platform/scheduler/base/task_queue.h:35: // past (e.g.
base::TimeTicks() can be used to notify about immediate
On 2017/04/05 13:16:51, Sami wrote:
> Missing ')'

Done.

https://codereview.chromium.org/2798563003/diff/60001/third_party/WebKit/publ...
third_party/WebKit/public/platform/scheduler/base/task_queue.h:167: // Returns
requested run time of next scheduled wake_up for a delayed task
On 2017/04/05 13:16:52, Sami wrote:
> nit: no underscore

Done.

https://codereview.chromium.org/2798563003/diff/60001/third_party/WebKit/publ...
File
third_party/WebKit/public/platform/scheduler/child/single_thread_idle_task_runner.h
(right):

https://codereview.chromium.org/2798563003/diff/60001/third_party/WebKit/publ...
third_party/WebKit/public/platform/scheduler/child/single_thread_idle_task_runner.h:74:
// after |delay|.  Note this has after wake_up semantics, i.e. unless
On 2017/04/05 13:16:52, Sami wrote:
> Ditto.

Done.

[altimin, 2017-04-05 13:55:57]

altimin@chromium.org changed reviewers:
+ dgozman@chromium.org

[altimin, 2017-04-05 13:55:58]

+dgozman@ for changing test in content/browser/devtools

[Sami, 2017-04-05 14:38:15]

https://codereview.chromium.org/2798563003/diff/60001/content/browser/devtool...
File content/browser/devtools/protocol/devtools_protocol_browsertest.cc (right):

https://codereview.chromium.org/2798563003/diff/60001/content/browser/devtool...
content/browser/devtools/protocol/devtools_protocol_browsertest.cc:1333: //
TODO(scheduler-dev): Revisit timing when we have strict ordering
On 2017/04/05 13:55:18, altimin wrote:
> On 2017/04/05 13:16:51, Sami wrote:
> > Can we now also enable this for Android?
> 
> Let's ask Alex when he's back.

I'm pretty sure we can -- this was the bug I was fixing with my EnqueueOrder
change. Could you turn this on here please?

https://codereview.chromium.org/2798563003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc
(right):

https://codereview.chromium.org/2798563003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc:293: if
(wake_up.time == new_wake_up.time &&
On 2017/04/05 13:55:18, altimin wrote:
> On 2017/04/05 13:16:51, Sami wrote:
> > This could use a comment saying what we're doing here. Also, of we already
> have
> > a wake-up at |time|, why do we need to schedule another one if just the
> sequence
> > number changed?
> 
> Done. We need it because we need to update TimeDomain with the latest wakeup
or
> a DCHECK will fail if we try to replace an old wakeup with the new same one.

Does this cause a new wake-up to be scheduled at the message loop level? I'm
concerned this might be a perf regression since we can't yet cancel delayed
tasks at that level. (Admittedly identical run times don't really happen in
practice but still I'd prefer to keep the optimization Alex added.)

[altimin, 2017-04-05 15:10:23]

PTAL

https://codereview.chromium.org/2798563003/diff/60001/content/browser/devtool...
File content/browser/devtools/protocol/devtools_protocol_browsertest.cc (right):

https://codereview.chromium.org/2798563003/diff/60001/content/browser/devtool...
content/browser/devtools/protocol/devtools_protocol_browsertest.cc:1333: //
TODO(scheduler-dev): Revisit timing when we have strict ordering
On 2017/04/05 14:38:15, Sami wrote:
> On 2017/04/05 13:55:18, altimin wrote:
> > On 2017/04/05 13:16:51, Sami wrote:
> > > Can we now also enable this for Android?
> > 
> > Let's ask Alex when he's back.
> 
> I'm pretty sure we can -- this was the bug I was fixing with my EnqueueOrder
> change. Could you turn this on here please?

I'll try it in a separate CL.

https://codereview.chromium.org/2798563003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc
(right):

https://codereview.chromium.org/2798563003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc:293: if
(wake_up.time == new_wake_up.time &&
On 2017/04/05 14:38:15, Sami wrote:
> On 2017/04/05 13:55:18, altimin wrote:
> > On 2017/04/05 13:16:51, Sami wrote:
> > > This could use a comment saying what we're doing here. Also, of we already
> > have
> > > a wake-up at |time|, why do we need to schedule another one if just the
> > sequence
> > > number changed?
> > 
> > Done. We need it because we need to update TimeDomain with the latest wakeup
> or
> > a DCHECK will fail if we try to replace an old wakeup with the new same one.
> 
> Does this cause a new wake-up to be scheduled at the message loop level? I'm
> concerned this might be a perf regression since we can't yet cancel delayed
> tasks at that level. (Admittedly identical run times don't really happen in
> practice but still I'd prefer to keep the optimization Alex added.)

No, TQM::MaybeScheduleDelayedWork tracks that for us.

[Sami, 2017-04-05 15:16:55]

https://codereview.chromium.org/2798563003/diff/60001/content/browser/devtool...
File content/browser/devtools/protocol/devtools_protocol_browsertest.cc (right):

https://codereview.chromium.org/2798563003/diff/60001/content/browser/devtool...
content/browser/devtools/protocol/devtools_protocol_browsertest.cc:1333: //
TODO(scheduler-dev): Revisit timing when we have strict ordering
On 2017/04/05 15:10:22, altimin wrote:
> On 2017/04/05 14:38:15, Sami wrote:
> > On 2017/04/05 13:55:18, altimin wrote:
> > > On 2017/04/05 13:16:51, Sami wrote:
> > > > Can we now also enable this for Android?
> > > 
> > > Let's ask Alex when he's back.
> > 
> > I'm pretty sure we can -- this was the bug I was fixing with my EnqueueOrder
> > change. Could you turn this on here please?
> 
> I'll try it in a separate CL.

Let's do it here since this is actually the patch that fixes the test. The
trybots will tell us if I'm wrong -- at that point we can split.

[altimin, 2017-04-05 15:22:40]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 15:23:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[altimin, 2017-04-05 15:23:33]

https://codereview.chromium.org/2798563003/diff/60001/content/browser/devtool...
File content/browser/devtools/protocol/devtools_protocol_browsertest.cc (right):

https://codereview.chromium.org/2798563003/diff/60001/content/browser/devtool...
content/browser/devtools/protocol/devtools_protocol_browsertest.cc:1333: //
TODO(scheduler-dev): Revisit timing when we have strict ordering
On 2017/04/05 15:16:55, Sami wrote:
> On 2017/04/05 15:10:22, altimin wrote:
> > On 2017/04/05 14:38:15, Sami wrote:
> > > On 2017/04/05 13:55:18, altimin wrote:
> > > > On 2017/04/05 13:16:51, Sami wrote:
> > > > > Can we now also enable this for Android?
> > > > 
> > > > Let's ask Alex when he's back.
> > > 
> > > I'm pretty sure we can -- this was the bug I was fixing with my
EnqueueOrder
> > > change. Could you turn this on here please?
> > 
> > I'll try it in a separate CL.
> 
> Let's do it here since this is actually the patch that fixes the test. The
> trybots will tell us if I'm wrong -- at that point we can split.

Done.

[Sami, 2017-04-05 15:33:54]

Thanks, lgtm

[dgozman, 2017-04-05 15:36:14]

content lgtm

[commit-bot: I haz the power, 2017-04-05 17:03:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 17:03:04]

Dry run: This issue passed the CQ dry run.

[altimin, 2017-04-05 17:15:23]

The CQ bit was checked by altimin@chromium.org

[commit-bot: I haz the power, 2017-04-05 17:15:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 17:22:58]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1491412523126680,
"parent_rev": "0f199cb0e21263e0ce09146c4763c0a99be6b190", "commit_rev":
"eafdfdb6623fccf2b2733d286f1e9a29d9784f66"}

[commit-bot: I haz the power, 2017-04-05 17:23:45]

Description was changed from

==========
[scheduler] Add TaskQueue::Observer

Remove TimeDomain::Observer and replace it with TaskQueue::Observer,
which provides notifications about change of wakeups.

R=skyostil@chromium.org
CC=skyostil@chromium.org
BUG=699541
==========

to

==========
[scheduler] Add TaskQueue::Observer

Remove TimeDomain::Observer and replace it with TaskQueue::Observer,
which provides notifications about change of wakeups.

R=skyostil@chromium.org
CC=skyostil@chromium.org
BUG=699541

Review-Url: https://codereview.chromium.org/2798563003
Cr-Commit-Position: refs/heads/master@{#462129}
Committed:
https://chromium.googlesource.com/chromium/src/+/eafdfdb6623fccf2b2733d286f1e...
==========

[commit-bot: I haz the power, 2017-04-05 17:23:46]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/eafdfdb6623fccf2b2733d286f1e...

[alex clarke (OOO till 29th), 2017-04-10 10:16:32]

alexclarke@chromium.org changed reviewers:
+ alexclarke@chromium.org

[alex clarke (OOO till 29th), 2017-04-10 10:16:33]

https://codereview.chromium.org/2798563003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc
(right):

https://codereview.chromium.org/2798563003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc:901: void
TaskQueueImpl::NotifyWakeUpChangedOnMainThread(base::TimeTicks wake_up) {
Did you consider doing this in 
TaskQueueImpl::set_scheduled_time_domain_wake_up?

[robliao, 2017-04-10 19:16:36]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/2812703002/ by robliao@chromium.org.

The reason for reverting is: This regresses loading of some websites..

[altimin, 2017-04-11 14:09:16]

Description was changed from

==========
[scheduler] Add TaskQueue::Observer

Remove TimeDomain::Observer and replace it with TaskQueue::Observer,
which provides notifications about change of wakeups.

R=skyostil@chromium.org
CC=skyostil@chromium.org
BUG=699541

Review-Url: https://codereview.chromium.org/2798563003
Cr-Commit-Position: refs/heads/master@{#462129}
Committed:
https://chromium.googlesource.com/chromium/src/+/eafdfdb6623fccf2b2733d286f1e...
==========

to

==========
[scheduler] Add TaskQueue::Observer

Remove TimeDomain::Observer and replace it with TaskQueue::Observer,
which provides notifications about change of wakeups.

R=skyostil@chromium.org
CC=skyostil@chromium.org
BUG=699541

Review-Url: https://codereview.chromium.org/2798563003
Cr-Commit-Position: refs/heads/master@{#462129}
Committed:
https://chromium.googlesource.com/chromium/src/+/eafdfdb6623fccf2b2733d286f1e...
==========

[altimin, 2017-04-11 15:09:25]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 15:10:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 16:52:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 16:52:40]

Dry run: This issue passed the CQ dry run.

[altimin, 2017-04-11 20:27:12]

The CQ bit was checked by altimin@chromium.org

[altimin, 2017-04-11 20:27:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/2798563003/#ps120001
(title: "Rebased")

[commit-bot: I haz the power, 2017-04-11 20:27:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 20:40:33]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1491942432844460,
"parent_rev": "8e011e166f270942ff5b40dc4e1db25ba42d3a10", "commit_rev":
"68875cc7e32820645c9cbc8795d98486565848f4"}

[commit-bot: I haz the power, 2017-04-11 20:41:31]

Description was changed from

==========
[scheduler] Add TaskQueue::Observer

Remove TimeDomain::Observer and replace it with TaskQueue::Observer,
which provides notifications about change of wakeups.

R=skyostil@chromium.org
CC=skyostil@chromium.org
BUG=699541

Review-Url: https://codereview.chromium.org/2798563003
Cr-Commit-Position: refs/heads/master@{#462129}
Committed:
https://chromium.googlesource.com/chromium/src/+/eafdfdb6623fccf2b2733d286f1e...
==========

to

==========
[scheduler] Add TaskQueue::Observer

Remove TimeDomain::Observer and replace it with TaskQueue::Observer,
which provides notifications about change of wakeups.

R=skyostil@chromium.org
CC=skyostil@chromium.org
BUG=699541

Review-Url: https://codereview.chromium.org/2798563003
Cr-Original-Commit-Position: refs/heads/master@{#462129}
Committed:
https://chromium.googlesource.com/chromium/src/+/eafdfdb6623fccf2b2733d286f1e...
Review-Url: https://codereview.chromium.org/2798563003
Cr-Commit-Position: refs/heads/master@{#463755}
Committed:
https://chromium.googlesource.com/chromium/src/+/68875cc7e32820645c9cbc8795d9...
==========

[commit-bot: I haz the power, 2017-04-11 20:41:33]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/68875cc7e32820645c9cbc8795d9...