Fix names of local constants after blink rename.

Fix names of local constants after blink rename.

The blink rename script renamed some constant const kFoos to k_foos.
Undo that again manually.

No intended behavior change.

BUG=578344, 675877
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng

Review-Url: https://codereview.chromium.org/2812643002
Cr-Commit-Position: refs/heads/master@{#463281}
Committed: https://chromium.googlesource.com/chromium/src/+/9b0611279ba80484dfe17163519cabbd5939c935

[Nico, 2017-04-10 14:30:29]

Description was changed from

==========
Fix names of local constants after blink rename.

The blink rename script renamed some constant const kFoos to k_foos.
Undo that again manually.

No intended behavior change.

BUG=578344
==========

to

==========
Fix names of local constants after blink rename.

The blink rename script renamed some constant const kFoos to k_foos.
Undo that again manually.

No intended behavior change.

BUG=578344
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[Nico, 2017-04-10 14:30:34]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[Nico, 2017-04-10 14:30:44]

thakis@chromium.org changed reviewers:
+ dcheng@chromium.org

[commit-bot: I haz the power, 2017-04-10 14:30:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dglazkov, 2017-04-10 14:32:46]

dglazkov@chromium.org changed reviewers:
+ dglazkov@chromium.org

[dglazkov, 2017-04-10 14:32:46]

lgtm

[Nico, 2017-04-10 14:33:07]

The CQ bit was unchecked by thakis@chromium.org

[Nico, 2017-04-10 14:33:10]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2017-04-10 14:33:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Elphick, 2017-04-10 14:55:43]

delphick@chromium.org changed reviewers:
+ delphick@chromium.org

[Dan Elphick, 2017-04-10 14:55:43]

https://codereview.chromium.org/2812643002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/DOMTimerTest.cpp (right):

https://codereview.chromium.org/2812643002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/DOMTimerTest.cpp:96: const char*
g_k_set_interval_script_text =
There's also this constant that got renamed.

Sorry the constants in this file are my fault due to failure to notice which
directory I was in while writing the test.

I'm going to fix this in a change I'm about to land so don't worry about fixing
this one, but it's worth looking to see if there are other cases like this.

[Nico, 2017-04-10 15:18:21]

Description was changed from

==========
Fix names of local constants after blink rename.

The blink rename script renamed some constant const kFoos to k_foos.
Undo that again manually.

No intended behavior change.

BUG=578344
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
Fix names of local constants after blink rename.

The blink rename script renamed some constant const kFoos to k_foos.
Undo that again manually.

No intended behavior change.

BUG=578344,675877
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[Nico, 2017-04-10 15:21:40]

https://codereview.chromium.org/2812643002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/DOMTimerTest.cpp (right):

https://codereview.chromium.org/2812643002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/DOMTimerTest.cpp:96: const char*
g_k_set_interval_script_text =
On 2017/04/10 14:55:43, Dan Elphick wrote:
> There's also this constant that got renamed.
> 
> Sorry the constants in this file are my fault due to failure to notice which
> directory I was in while writing the test.

Can you expand on this? The idea behind all this renaming is that it shouldn't
be necessary any more to be aware of which directory you're in since style is
(roughly) the same everywhere now.

> 
> I'm going to fix this in a change I'm about to land so don't worry about
fixing
> this one, but it's worth looking to see if there are other cases like this.

Thanks!

Looks like there are a few more:
https://cs.chromium.org/search/?q=g_k_+file:webkit+package:%5Echromium$&type=cs

But many of those, while called kFoo, aren't actually constant.

(This one isn't either -- it needs to be either `const char
kSetIntervalScriptText[]` or `const char* const kSet...` -- else it does point
to constant memory but the pointer itself isn't constant. Right now, doing
`g_k_set_... = "asdf"` will compile fine and make the pointer point to another
constant string.)

[Dan Elphick, 2017-04-10 15:33:58]

https://codereview.chromium.org/2812643002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/DOMTimerTest.cpp (right):

https://codereview.chromium.org/2812643002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/DOMTimerTest.cpp:96: const char*
g_k_set_interval_script_text =
On 2017/04/10 15:21:40, Nico wrote:
> On 2017/04/10 14:55:43, Dan Elphick wrote:
> > There's also this constant that got renamed.
> > 
> > Sorry the constants in this file are my fault due to failure to notice which
> > directory I was in while writing the test.
> 
> Can you expand on this? The idea behind all this renaming is that it shouldn't
> be necessary any more to be aware of which directory you're in since style is
> (roughly) the same everywhere now.

I just meant I created these constants before you renamed them using the new
style and not the old style, which resulted in this extra CL. I'm very happy
with your change as now I only need to remember one style!

> > I'm going to fix this in a change I'm about to land so don't worry about
> fixing
> > this one, but it's worth looking to see if there are other cases like this.
> 
> Thanks!
> 
> Looks like there are a few more:
>
https://cs.chromium.org/search/?q=g_k_+file:webkit+package:%5Echromium$&type=cs
> 
> But many of those, while called kFoo, aren't actually constant.
> 
> (This one isn't either -- it needs to be either `const char
> kSetIntervalScriptText[]` or `const char* const kSet...` -- else it does point
> to constant memory but the pointer itself isn't constant. Right now, doing
> `g_k_set_... = "asdf"` will compile fine and make the pointer point to another
> constant string.)

You're right. I'll fix this as well.

[commit-bot: I haz the power, 2017-04-10 15:54:56]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491834790942150, "parent_rev":
"8b2491697f386b054dd28549f0c66d717f020d0d", "commit_rev":
"9b0611279ba80484dfe17163519cabbd5939c935"}

[commit-bot: I haz the power, 2017-04-10 15:55:53]

Description was changed from

==========
Fix names of local constants after blink rename.

The blink rename script renamed some constant const kFoos to k_foos.
Undo that again manually.

No intended behavior change.

BUG=578344,675877
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
Fix names of local constants after blink rename.

The blink rename script renamed some constant const kFoos to k_foos.
Undo that again manually.

No intended behavior change.

BUG=578344,675877
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng

Review-Url: https://codereview.chromium.org/2812643002
Cr-Commit-Position: refs/heads/master@{#463281}
Committed:
https://chromium.googlesource.com/chromium/src/+/9b0611279ba80484dfe17163519c...
==========

[commit-bot: I haz the power, 2017-04-10 15:55:55]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9b0611279ba80484dfe17163519c...

[dcheng, 2017-04-10 17:30:46]

LGTM

https://codereview.chromium.org/2812643002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/tests/WebFrameTest.cpp (right):

https://codereview.chromium.org/2812643002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/tests/WebFrameTest.cpp:5104: static const char*
kFindString = "foo";
Btw, the reason the tool thought that this (and several other things like this)
wasn't a constant is because it wasn't: it's missing a const after char*, so
this can actually be assigned.