Fix names of local constants after blink rename.

third_party/WebKit/Source/core/frame/DOMTimerTest.cpp

Index: third_party/WebKit/Source/core/frame/DOMTimerTest.cpp
diff --git a/third_party/WebKit/Source/core/frame/DOMTimerTest.cpp b/third_party/WebKit/Source/core/frame/DOMTimerTest.cpp
index e37c6d7e04fd2de33062ed1829e50495ab116224..aa9d2e0fb4dd077e1304ae88115b34c269a1ea21 100644
--- a/third_party/WebKit/Source/core/frame/DOMTimerTest.cpp
+++ b/third_party/WebKit/Source/core/frame/DOMTimerTest.cpp
@@ -30,7 +30,7 @@ class DOMTimerTest : public RenderingTest {
   // Expected time between each iterator for setInterval(..., 1) or nested
   // setTimeout(..., 1) are 1, 1, 1, 1, 4, 4, ... as a minumum clamp of 4m
   // is applied from the 5th iteration onwards.
-  const std::vector<Matcher<double>> k_expected_timings = {
+  const std::vector<Matcher<double>> kExpectedTimings = {
       DoubleNear(1., 0.000001), DoubleNear(1., 0.000001),
       DoubleNear(1., 0.000001), DoubleNear(1., 0.000001),
       DoubleNear(4., 0.000001), DoubleNear(4., 0.000001),
@@ -90,7 +90,7 @@ TEST_F(DOMTimerTest, setTimeout_ClampsAfter4Nestings) {
 
   auto times(ToDoubleArray(EvalExpression("times"), scope));
 
-  EXPECT_THAT(times, ElementsAreArray(k_expected_timings));
+  EXPECT_THAT(times, ElementsAreArray(kExpectedTimings));
 }
 
 const char* g_k_set_interval_script_text =

[Dan Elphick, 2017/04/10 14:55:43]

There's also this constant that got renamed.

Sorry the constants in this file are my fault due to failure to notice which
directory I was in while writing the test.

I'm going to fix this in a change I'm about to land so don't worry about fixing
this one, but it's worth looking to see if there are other cases like this.

[Nico, 2017/04/10 15:21:40]

Can you expand on this? The idea behind all this renaming is that it shouldn't
be necessary any more to be aware of which directory you're in since style is
(roughly) the same everywhere now.
Thanks!

Looks like there are a few more:
https://cs.chromium.org/search/?q=g_k_+file:webkit+package:%5Echromium$&type=cs

But many of those, while called kFoo, aren't actually constant.

(This one isn't either -- it needs to be either `const char
kSetIntervalScriptText[]` or `const char* const kSet...` -- else it does point
to constant memory but the pointer itself isn't constant. Right now, doing
`g_k_set_... = "asdf"` will compile fine and make the pointer point to another
constant string.)

[Dan Elphick, 2017/04/10 15:33:58]

I just meant I created these constants before you renamed them using the new
style and not the old style, which resulted in this extra CL. I'm very happy
with your change as now I only need to remember one style!
You're right. I'll fix this as well.

@@ -113,7 +113,7 @@ TEST_F(DOMTimerTest, setInterval_ClampsAfter4Iterations) {
 
   auto times(ToDoubleArray(EvalExpression("times"), scope));
 
-  EXPECT_THAT(times, ElementsAreArray(k_expected_timings));
+  EXPECT_THAT(times, ElementsAreArray(kExpectedTimings));
 }
 
 TEST_F(DOMTimerTest, setInterval_NestingResetsForLaterCalls) {
@@ -128,7 +128,7 @@ TEST_F(DOMTimerTest, setInterval_NestingResetsForLaterCalls) {
 
   auto times(ToDoubleArray(EvalExpression("times"), scope));
 
-  EXPECT_THAT(times, ElementsAreArray(k_expected_timings));
+  EXPECT_THAT(times, ElementsAreArray(kExpectedTimings));
 }
 
 }  // namespace