Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2812643002: Fix names of local constants after blink rename. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
index 98c6f8b90e05059df1efe72f6a65b46bb4b59d8d..91bb12aa3655a317b619448984efdb37be7bd5ff 100644
--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
@@ -4835,12 +4835,12 @@ TEST_F(WebFrameTest, FindInPageActiveIndex) {
web_view_helper.WebView()->Resize(WebSize(640, 480));
RunPendingTasks();
- const char* k_find_string = "a";
+ const char* kFindString = "a";
const int kFindIdentifier = 7777;
const int kActiveIndex = 1;
WebFindOptions options;
- WebString search_text = WebString::FromUTF8(k_find_string);
+ WebString search_text = WebString::FromUTF8(kFindString);
WebLocalFrameImpl* main_frame = web_view_helper.WebView()->MainFrameImpl();
EXPECT_TRUE(main_frame->Find(kFindIdentifier, search_text, options, false));
main_frame->EnsureTextFinder().ResetMatchCount();
@@ -4865,8 +4865,8 @@ TEST_F(WebFrameTest, FindInPageActiveIndex) {
EXPECT_TRUE(client.FindResultsAreReady());
EXPECT_EQ(kActiveIndex, client.ActiveIndex());
- const char* k_find_string_new = "e";
- WebString search_text_new = WebString::FromUTF8(k_find_string_new);
+ const char* kFindStringNew = "e";
+ WebString search_text_new = WebString::FromUTF8(kFindStringNew);
EXPECT_TRUE(
main_frame->Find(kFindIdentifier, search_text_new, options, false));
@@ -5101,8 +5101,8 @@ TEST_P(ParameterizedWebFrameTest, FindInPageJavaScriptUpdatesDOM) {
WebLocalFrameImpl* frame = web_view_helper.WebView()->MainFrameImpl();
const int kFindIdentifier = 12345;
- static const char* k_find_string = "foo";
- WebString search_text = WebString::FromUTF8(k_find_string);
+ static const char* kFindString = "foo";
dcheng 2017/04/10 17:30:45 Btw, the reason the tool thought that this (and se
+ WebString search_text = WebString::FromUTF8(kFindString);
WebFindOptions options;
bool active_now;

Powered by Google App Engine
This is Rietveld 408576698