Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 281223002: Removed LOG_GETLASTERROR and LOG_ERRNO macros. (Closed)

Created:
6 years, 7 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chromoting-reviews_chromium.org, tfarina, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, ben+corewm_chromium.org
Visibility:
Public.

Description

Removed LOG_GETLASTERROR and LOG_ERRNO macros. Most code uses PLOG with the same effect. TBR=bradchen NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271949

Patch Set 1 : Wed 05/14/2014 11:20:03.21 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -227 lines) Patch
M base/file_util_win.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M base/logging.h View 1 chunk +0 lines, -9 lines 0 comments Download
M base/mac/os_crash_dumps.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/power_monitor/power_monitor_device_source_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process/kill_win.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M base/sha1_win.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M base/synchronization/waitable_event_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/worker_pool_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/time/time_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/win/message_window.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/win/object_watcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/nacl/loader/nonsfi/irt_memory.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_main_loop.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gamepad/raw_input_data_fetcher_win.cc View 13 chunks +13 lines, -15 lines 0 comments Download
M device/hid/hid_service_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/audio_low_latency_output_win.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M media/base/user_input_monitor_win.cc View 5 chunks +5 lines, -7 lines 0 comments Download
M remoting/host/curtain_mode_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/daemon_process_win.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M remoting/host/desktop_session_proxy.cc View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/host/desktop_shape_tracker_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/host_event_logger_win.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M remoting/host/host_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/input_injector_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/ipc_util_win.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M remoting/host/local_input_monitor_win.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M remoting/host/sas_injector_win.cc View 5 chunks +8 lines, -14 lines 0 comments Download
M remoting/host/setup/daemon_controller_delegate_win.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M remoting/host/setup/me2me_native_messaging_host.cc View 6 chunks +7 lines, -11 lines 0 comments Download
M remoting/host/setup/me2me_native_messaging_host_main.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M remoting/host/usage_stats_consent_win.cc View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/host/win/com_security.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/win/elevated_controller.cc View 11 chunks +19 lines, -27 lines 0 comments Download
M remoting/host/win/host_service.cc View 6 chunks +6 lines, -10 lines 0 comments Download
M remoting/host/win/launch_process_with_token.cc View 12 chunks +16 lines, -20 lines 0 comments Download
M remoting/host/win/rdp_client_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/win/unprivileged_process_delegate.cc View 9 chunks +11 lines, -13 lines 0 comments Download
M remoting/host/win/worker_process_launcher.cc View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/host/win/wts_session_process_delegate.cc View 7 chunks +8 lines, -10 lines 0 comments Download
M remoting/host/win/wts_terminal_monitor.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/tools/breakpad_tester_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/win/hwnd_util.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/views/corewm/tooltip_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 27 (0 generated)
Vitaly Buka (NO REVIEWS)
+thakis for base/ and ui/ +dcaiafa for remoting/ +scherkus for media/
6 years, 7 months ago (2014-05-14 18:14:54 UTC) #1
Vitaly Buka (NO REVIEWS)
+brettw for base/ and content/ +sky for ui/ +keybuk for device/ +bradchen for components/nacl/
6 years, 7 months ago (2014-05-14 18:19:54 UTC) #2
Vitaly Buka (NO REVIEWS)
+brettw for base/ and content/ +sky for ui/ +keybuk for device/ +bradchen for components/nacl/
6 years, 7 months ago (2014-05-14 18:21:22 UTC) #3
dcaiafa
remoting lgtm
6 years, 7 months ago (2014-05-14 20:53:21 UTC) #4
scherkus (not reviewing)
media/ lgtm
6 years, 7 months ago (2014-05-14 20:56:03 UTC) #5
keybuk
device/ lgtm
6 years, 7 months ago (2014-05-14 21:07:55 UTC) #6
sky
ui/ LGTM
6 years, 7 months ago (2014-05-14 23:21:10 UTC) #7
brettw
lgtm
6 years, 7 months ago (2014-05-20 19:38:20 UTC) #8
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 7 months ago (2014-05-20 19:41:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/281223002/40001
6 years, 7 months ago (2014-05-20 19:41:49 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 21:09:58 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-20 21:14:14 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/29120)
6 years, 7 months ago (2014-05-20 21:14:15 UTC) #13
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 7 months ago (2014-05-20 22:00:24 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/281223002/40001
6 years, 7 months ago (2014-05-20 22:04:32 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 23:30:42 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-20 23:37:53 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/68804)
6 years, 7 months ago (2014-05-20 23:37:53 UTC) #18
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 7 months ago (2014-05-20 23:58:46 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/281223002/40001
6 years, 7 months ago (2014-05-21 00:00:42 UTC) #20
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-21 01:01:41 UTC) #21
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 7 months ago (2014-05-21 06:02:30 UTC) #22
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 7 months ago (2014-05-21 19:04:25 UTC) #23
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 7 months ago (2014-05-21 19:31:46 UTC) #24
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 7 months ago (2014-05-21 19:31:55 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/281223002/40001
6 years, 7 months ago (2014-05-21 19:57:25 UTC) #26
commit-bot: I haz the power
6 years, 7 months ago (2014-05-21 20:06:26 UTC) #27
Message was sent while issue was closed. 
Change committed as 271949

Powered by Google App Engine
This is Rietveld 408576698