Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: base/logging.h

Issue 281223002: Removed LOG_GETLASTERROR and LOG_ERRNO macros. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Wed 05/14/2014 11:20:03.21 Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/file_util_win.cc ('k') | base/mac/os_crash_dumps.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/logging.h
diff --git a/base/logging.h b/base/logging.h
index dd17bcedb8ed72e6a55c4400c90112a170f58f43..5027ce7328dd80f6caca107e43ff186308d12405 100644
--- a/base/logging.h
+++ b/base/logging.h
@@ -613,15 +613,6 @@ enum { DEBUG_MODE = ENABLE_DLOG };
#define DVPLOG(verboselevel) DVPLOG_IF(verboselevel, VLOG_IS_ON(verboselevel))
-// TODO(vitalybuka): following should be removed and replaced with PLOG.
-#if defined(OS_WIN)
-#define LOG_GETLASTERROR(severity) PLOG(severity)
-#define DLOG_GETLASTERROR(severity) DPLOG(severity)
-#elif defined(OS_POSIX)
-#define LOG_ERRNO(severity) PLOG(severity)
-#define DLOG_ERRNO(severity) DPLOG(severity)
-#endif
-
// Definitions for DCHECK et al.
#if DCHECK_IS_ON
« no previous file with comments | « base/file_util_win.cc ('k') | base/mac/os_crash_dumps.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698