MD Settings: Fix md-select alignment in passwords and forms section dialogs.

MD Settings: Fix md-select alignment in passwords and forms section dialogs.

BUG=711169
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2812223007
Cr-Commit-Position: refs/heads/master@{#464525}
Committed: https://chromium.googlesource.com/chromium/src/+/b5f4c9ef3c4ee3f316de7dacc5bee73bef98c4bc

[dpapad, 2017-04-13 17:30:09]

Description was changed from

==========
MD Settings: Fix md-select alignment in passwords and forms section dialogs.

BUG=711169
==========

to

==========
MD Settings: Fix md-select alignment in passwords and forms section dialogs.

BUG=711169
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-04-13 17:31:16]

dpapad@chromium.org changed reviewers:
+ tommycli@chromium.org

[dpapad, 2017-04-13 17:31:17]

Before/after screenshots at http://imgur.com/a/xd0c9.

[tommycli, 2017-04-13 17:38:29]

lgtm thanks

[dpapad, 2017-04-13 17:44:31]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2017-04-13 17:45:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 18:38:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 18:38:53]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[dpapad, 2017-04-13 18:50:18]

Had to update tests.

https://codereview.chromium.org/2812223007/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js
(right):

https://codereview.chromium.org/2812223007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js:116:
var inputs = this.$.dialog.querySelectorAll('.address-column, select');
Had to update this selector, now that the <select> does no longer have the
address-column class.

[dpapad, 2017-04-13 18:52:03]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 18:52:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2017-04-13 18:55:17]

np thanks for the circleback

https://codereview.chromium.org/2812223007/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js
(right):

https://codereview.chromium.org/2812223007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js:116:
var inputs = this.$.dialog.querySelectorAll('.address-column, select');
On 2017/04/13 18:50:18, dpapad wrote:
> Had to update this selector, now that the <select> does no longer have the
> address-column class.

Acknowledged.

[dpapad, 2017-04-13 18:57:03]

The CQ bit was unchecked by dpapad@chromium.org

[dpapad, 2017-04-13 18:57:05]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2017-04-13 18:57:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2812223007/#ps20001
(title: "Fix test.")

[commit-bot: I haz the power, 2017-04-13 18:57:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 20:24:03]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492109825239440,
"parent_rev": "98f1927737cd1c3fd5d471b74cc94333e9e37972", "commit_rev":
"b5f4c9ef3c4ee3f316de7dacc5bee73bef98c4bc"}

[commit-bot: I haz the power, 2017-04-13 20:24:49]

Description was changed from

==========
MD Settings: Fix md-select alignment in passwords and forms section dialogs.

BUG=711169
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix md-select alignment in passwords and forms section dialogs.

BUG=711169
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2812223007
Cr-Commit-Position: refs/heads/master@{#464525}
Committed:
https://chromium.googlesource.com/chromium/src/+/b5f4c9ef3c4ee3f316de7dacc5be...
==========

[commit-bot: I haz the power, 2017-04-13 20:24:51]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b5f4c9ef3c4ee3f316de7dacc5be...