Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3447)

Unified Diff: chrome/test/data/webui/settings/settings_autofill_section_browsertest.js

Issue 2812223007: MD Settings: Fix md-select alignment in passwords and forms section dialogs. (Closed)
Patch Set: Fix test. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
diff --git a/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js b/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
index 1cff256a875b588a647238175b0892b073bcf42e..7c6e217de1d2d711db89ddd016af5a314150fd48 100644
--- a/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
+++ b/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
@@ -773,9 +773,8 @@ TEST_F('SettingsAutofillSectionBrowserTest', 'AddressLocaleTests', function() {
assertEquals(address.postalCode, cols[2].value);
// Country
row = rows[4];
- cols = row.querySelectorAll('.address-column');
- assertEquals(1, cols.length);
- var countrySelect = /** @type {!HTMLSelectElement} */ (cols[0]);
+ var countrySelect = row.querySelector('select');
+ assertTrue(!!countrySelect);
assertEquals(
'United States',
countrySelect.selectedOptions[0].textContent.trim());
@@ -832,10 +831,11 @@ TEST_F('SettingsAutofillSectionBrowserTest', 'AddressLocaleTests', function() {
assertEquals(address.postalCode, cols[0].value);
// Country
row = rows[5];
- cols = row.querySelectorAll('.address-column');
- assertEquals(1, cols.length);
+ var countrySelect = row.querySelector('select');
+ assertTrue(!!countrySelect);
assertEquals(
- 'United Kingdom', cols[0].selectedOptions[0].textContent.trim());
+ 'United Kingdom',
+ countrySelect.selectedOptions[0].textContent.trim());
// Phone, Email
row = rows[6];
cols = row.querySelectorAll('.address-column');
@@ -886,10 +886,10 @@ TEST_F('SettingsAutofillSectionBrowserTest', 'AddressLocaleTests', function() {
assertEquals(address.postalCode, cols[1].value);
// Country
row = rows[4];
- cols = row.querySelectorAll('.address-column');
- assertEquals(1, cols.length);
+ var countrySelect = row.querySelector('select');
+ assertTrue(!!countrySelect);
assertEquals(
- 'Israel', cols[0].selectedOptions[0].textContent.trim());
+ 'Israel', countrySelect.selectedOptions[0].textContent.trim());
// Phone, Email
row = rows[5];
cols = row.querySelectorAll('.address-column');

Powered by Google App Engine
This is Rietveld 408576698