chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js - Issue 2812223007: MD Settings: Fix md-select alignment in passwords and forms section dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js

Issue 2812223007: MD Settings: Fix md-select alignment in passwords and forms section dialogs. (Closed)

Patch Set: Fix test. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html ('k') | chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js

diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js b/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js

index 502d07a6a1911e58ef73c8c3c6b34b573e876101..06e84498c4728e62209068e2c135f003df6665ce 100644

--- a/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js

+++ b/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js

@@ -113,7 +113,7 @@ Polymer({

updateCanSave_: function() {

- var inputs = this.$.dialog.querySelectorAll('.address-column');

+ var inputs = this.$.dialog.querySelectorAll('.address-column, select');

dpapad 2017/04/13 18:50:18 Had to update this selector, now that the <select>

tommycli 2017/04/13 18:55:16 Acknowledged.

for (var i = 0; i < inputs.length; ++i) {

if (inputs[i].value) {