Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2812223002: Fixed comments for GetLastCommittedNonRedirectedItem unit tests. (Closed)

Created:
3 years, 8 months ago by pkl (ping after 24h if needed)
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed comments for GetLastCommittedNonRedirectedItem unit tests. Review-Url: https://codereview.chromium.org/2812223002 Cr-Commit-Position: refs/heads/master@{#464260} Committed: https://chromium.googlesource.com/chromium/src/+/543bc6771d83910de493d55a7eccc546c68269e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ios/chrome/browser/web/navigation_manager_util.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/web/navigation_manager_util_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (10 generated)
pkl (ping after 24h if needed)
Fixing comments only.
3 years, 8 months ago (2017-04-12 05:14:50 UTC) #2
liaoyuke
lgtm! Thanks for fixing it!
3 years, 8 months ago (2017-04-12 16:07:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812223002/1
3 years, 8 months ago (2017-04-12 16:36:21 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/409332)
3 years, 8 months ago (2017-04-12 16:46:29 UTC) #7
pkl (ping after 24h if needed)
+eugenebut for OWNERS review
3 years, 8 months ago (2017-04-12 16:51:13 UTC) #9
Eugene But (OOO till 7-30)
lgtm
3 years, 8 months ago (2017-04-12 16:54:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812223002/1
3 years, 8 months ago (2017-04-12 16:54:55 UTC) #12
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 8 months ago (2017-04-12 18:39:48 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812223002/1
3 years, 8 months ago (2017-04-13 00:54:36 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 02:52:10 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/543bc6771d83910de493d55a7ecc...

Powered by Google App Engine
This is Rietveld 408576698