Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Side by Side Diff: ios/chrome/browser/web/navigation_manager_util_unittest.mm

Issue 2812223002: Fixed comments for GetLastCommittedNonRedirectedItem unit tests. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ios/chrome/browser/web/navigation_manager_util.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ios/chrome/browser/web/navigation_manager_util.h" 5 #import "ios/chrome/browser/web/navigation_manager_util.h"
6 6
7 #import "ios/web/public/navigation_item.h" 7 #import "ios/web/public/navigation_item.h"
8 #import "ios/web/public/test/fakes/test_navigation_manager.h" 8 #import "ios/web/public/test/fakes/test_navigation_manager.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 #import "testing/gtest_mac.h" 10 #import "testing/gtest_mac.h"
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 nav_manager_.AddItem(GURL("http://bar.com/redir1"), 47 nav_manager_.AddItem(GURL("http://bar.com/redir1"),
48 ui::PAGE_TRANSITION_CLIENT_REDIRECT); 48 ui::PAGE_TRANSITION_CLIENT_REDIRECT);
49 nav_manager_.AddItem(GURL("http://bar.com/redir2"), 49 nav_manager_.AddItem(GURL("http://bar.com/redir2"),
50 ui::PAGE_TRANSITION_CLIENT_REDIRECT); 50 ui::PAGE_TRANSITION_CLIENT_REDIRECT);
51 web::NavigationItem* item = GetLastCommittedNonRedirectedItem(&nav_manager_); 51 web::NavigationItem* item = GetLastCommittedNonRedirectedItem(&nav_manager_);
52 ASSERT_TRUE(item); 52 ASSERT_TRUE(item);
53 EXPECT_TRUE(ui::PageTransitionTypeIncludingQualifiersIs( 53 EXPECT_TRUE(ui::PageTransitionTypeIncludingQualifiersIs(
54 item->GetTransitionType(), ui::PAGE_TRANSITION_LINK)); 54 item->GetTransitionType(), ui::PAGE_TRANSITION_LINK));
55 } 55 }
56 56
57 // Tests that when all items are redirects, the first one is returned. 57 // Tests that when all items are redirects, nullptr is returned.
58 TEST_F(NavigationManagerUtilTest, TestLastNonRedirectedItemAllRedirects) { 58 TEST_F(NavigationManagerUtilTest, TestLastNonRedirectedItemAllRedirects) {
59 nav_manager_.AddItem(GURL("http://bar.com/redir0"), 59 nav_manager_.AddItem(GURL("http://bar.com/redir0"),
60 ui::PAGE_TRANSITION_CLIENT_REDIRECT); 60 ui::PAGE_TRANSITION_CLIENT_REDIRECT);
61 nav_manager_.AddItem(GURL("http://bar.com/redir1"), 61 nav_manager_.AddItem(GURL("http://bar.com/redir1"),
62 ui::PAGE_TRANSITION_CLIENT_REDIRECT); 62 ui::PAGE_TRANSITION_CLIENT_REDIRECT);
63 nav_manager_.AddItem(GURL("http://bar.com/redir2"), 63 nav_manager_.AddItem(GURL("http://bar.com/redir2"),
64 ui::PAGE_TRANSITION_CLIENT_REDIRECT); 64 ui::PAGE_TRANSITION_CLIENT_REDIRECT);
65 web::NavigationItem* item = GetLastCommittedNonRedirectedItem(&nav_manager_); 65 web::NavigationItem* item = GetLastCommittedNonRedirectedItem(&nav_manager_);
66 EXPECT_FALSE(item); 66 EXPECT_FALSE(item);
67 } 67 }
68 68
69 // Tests that earlier redirects are not found. 69 // Tests that earlier redirects are not found.
70 TEST_F(NavigationManagerUtilTest, TestLastNonRedirectedItemNotEarliest) { 70 TEST_F(NavigationManagerUtilTest, TestLastNonRedirectedItemNotEarliest) {
71 nav_manager_.AddItem(GURL("http://foo.com/bookmark"), 71 nav_manager_.AddItem(GURL("http://foo.com/bookmark"),
72 ui::PAGE_TRANSITION_AUTO_BOOKMARK); 72 ui::PAGE_TRANSITION_AUTO_BOOKMARK);
73 nav_manager_.AddItem(GURL("http://foo.com/page0"), ui::PAGE_TRANSITION_TYPED); 73 nav_manager_.AddItem(GURL("http://foo.com/page0"), ui::PAGE_TRANSITION_TYPED);
74 nav_manager_.AddItem(GURL("http://bar.com/redir1"), 74 nav_manager_.AddItem(GURL("http://bar.com/redir1"),
75 ui::PAGE_TRANSITION_CLIENT_REDIRECT); 75 ui::PAGE_TRANSITION_CLIENT_REDIRECT);
76 nav_manager_.AddItem(GURL("http://bar.com/redir2"), 76 nav_manager_.AddItem(GURL("http://bar.com/redir2"),
77 ui::PAGE_TRANSITION_CLIENT_REDIRECT); 77 ui::PAGE_TRANSITION_CLIENT_REDIRECT);
78 web::NavigationItem* item = GetLastCommittedNonRedirectedItem(&nav_manager_); 78 web::NavigationItem* item = GetLastCommittedNonRedirectedItem(&nav_manager_);
79 ASSERT_TRUE(item); 79 ASSERT_TRUE(item);
80 EXPECT_TRUE(ui::PageTransitionTypeIncludingQualifiersIs( 80 EXPECT_TRUE(ui::PageTransitionTypeIncludingQualifiersIs(
81 item->GetTransitionType(), ui::PAGE_TRANSITION_TYPED)); 81 item->GetTransitionType(), ui::PAGE_TRANSITION_TYPED));
82 } 82 }
OLDNEW
« no previous file with comments | « ios/chrome/browser/web/navigation_manager_util.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698