ios/chrome/browser/web/navigation_manager_util_unittest.mm - Issue 2812223002: Fixed comments for GetLastCommittedNonRedirectedItem unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/web/navigation_manager_util_unittest.mm

Issue 2812223002: Fixed comments for GetLastCommittedNonRedirectedItem unit tests. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/web/navigation_manager_util_unittest.mm

diff --git a/ios/chrome/browser/web/navigation_manager_util_unittest.mm b/ios/chrome/browser/web/navigation_manager_util_unittest.mm

index 74ff9f3fce458e3f25e7a52326c71f8c929bac1f..8d7d0b7df8e573d370208184ba28eabd30b081e8 100644

--- a/ios/chrome/browser/web/navigation_manager_util_unittest.mm

+++ b/ios/chrome/browser/web/navigation_manager_util_unittest.mm

@@ -54,7 +54,7 @@ TEST_F(NavigationManagerUtilTest, TestLastNonRedirectedItemLinkMultiRedirects) {

item->GetTransitionType(), ui::PAGE_TRANSITION_LINK));

}

-// Tests that when all items are redirects, the first one is returned.

+// Tests that when all items are redirects, nullptr is returned.

TEST_F(NavigationManagerUtilTest, TestLastNonRedirectedItemAllRedirects) {

nav_manager_.AddItem(GURL("http://bar.com/redir0"),

ui::PAGE_TRANSITION_CLIENT_REDIRECT);

« no previous file with comments | « ios/chrome/browser/web/navigation_manager_util.h ('k') | no next file » | no next file with comments »