Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2811903003: Don't depend on base::win in PartitionAlloc. (Closed)

Created:
3 years, 8 months ago by palmer
Modified:
3 years, 8 months ago
Reviewers:
haraken, Tom Sepez
CC:
Mads Ager (chromium), chromium-reviews, danakj+watch_chromium.org, Dai Mikurube (NOT FULLTIME), kouhei+heap_chromium.org, oilpan-reviews, vmpstr+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't depend on base::win in PartitionAlloc. It seemed like a good idea, but we want to be able to use PA in other projects (like PDFium) without pulling in even more base dependencies. Instead, use the plain Windows API for getting the version. BUG=672219, 695274 TBR=haraken Review-Url: https://codereview.chromium.org/2811903003 Cr-Commit-Position: refs/heads/master@{#463776} Committed: https://chromium.googlesource.com/chromium/src/+/136d94d61e825232fccd78145cd94f86f5c20aae

Patch Set 1 #

Patch Set 2 : Fix the #including ordering. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M base/allocator/partition_allocator/address_space_randomization.cc View 1 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
palmer
TBRing you, haraken, since it's a minor tweak on https://codereview.chromium.org/2780733002 which LGTY before the base::win::Version ...
3 years, 8 months ago (2017-04-11 19:58:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811903003/20001
3 years, 8 months ago (2017-04-11 19:59:24 UTC) #5
Tom Sepez
lgtm
3 years, 8 months ago (2017-04-11 20:02:30 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/136d94d61e825232fccd78145cd94f86f5c20aae
3 years, 8 months ago (2017-04-11 21:29:55 UTC) #9
haraken
3 years, 8 months ago (2017-04-11 23:10:56 UTC) #10
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698