Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2780733002:
Use the full 47 bits of address space on Windows >= 8.1. (Closed)
|
Created:
3 years, 8 months ago by palmer Modified:
3 years, 8 months ago CC:
Mads Ager (chromium), chromium-reviews, Dai Mikurube (NOT FULLTIME), kouhei+heap_chromium.org, oilpan-reviews, vmpstr+watch_chromium.org, wfh+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse the full 47 bits of address space on Windows >= 8.1.
Improves our ASLR on systems that support it.
BUG=672219
Review-Url: https://codereview.chromium.org/2780733002
Cr-Commit-Position: refs/heads/master@{#460204}
Committed: https://chromium.googlesource.com/chromium/src/+/d406a54b2a677132a79f9da2c9624bb8c3ab07c8
Patch Set 1 #Patch Set 2 : `git cl format` is bad and should feel bad. #
Total comments: 2
Patch Set 3 : Use base::win::GetVersion. #Messages
Total messages: 18 (12 generated)
The CQ bit was checked by palmer@chromium.org to run a CQ dry run
palmer@chromium.org changed reviewers: + haraken@chromium.org, wfh@chromium.org
PTAL. Nice and small CL. :)
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM
The CQ bit was unchecked by palmer@chromium.org
The CQ bit was checked by palmer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2780733002/diff/20001/base/allocator/partitio... File base/allocator/partition_allocator/address_space_randomization.cc (right): https://codereview.chromium.org/2780733002/diff/20001/base/allocator/partitio... base/allocator/partition_allocator/address_space_randomization.cc:98: windows_81 = IsWindows8Point1OrGreater(); can this code use base::win::GetVersion - by convention we prefer to use these base apis rather than the windows ones. Also, it takes care of the lazy initialization.
https://codereview.chromium.org/2780733002/diff/20001/base/allocator/partitio... File base/allocator/partition_allocator/address_space_randomization.cc (right): https://codereview.chromium.org/2780733002/diff/20001/base/allocator/partitio... base/allocator/partition_allocator/address_space_randomization.cc:98: windows_81 = IsWindows8Point1OrGreater(); > can this code use base::win::GetVersion - by convention we prefer to use these base apis rather than the windows ones. > > Also, it takes care of the lazy initialization. Thanks. Using it now, although I might have to go back to IsWindows8Point1OrGreater if we end up needing to further reduces PA's base dependencies.
The CQ bit was checked by palmer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org Link to the patchset: https://codereview.chromium.org/2780733002/#ps40001 (title: "Use base::win::GetVersion.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490727987409730,
"parent_rev": "b5d44bb49fd4dc5e544f4312de6b00b1a1eb625c", "commit_rev":
"d406a54b2a677132a79f9da2c9624bb8c3ab07c8"}
Message was sent while issue was closed.
Description was changed from ========== Use the full 47 bits of address space on Windows >= 8.1. Improves our ASLR on systems that support it. BUG=672219 ========== to ========== Use the full 47 bits of address space on Windows >= 8.1. Improves our ASLR on systems that support it. BUG=672219 Review-Url: https://codereview.chromium.org/2780733002 Cr-Commit-Position: refs/heads/master@{#460204} Committed: https://chromium.googlesource.com/chromium/src/+/d406a54b2a677132a79f9da2c962... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/d406a54b2a677132a79f9da2c962... |
