Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2811863002: Move ScriptState::GetExecutionContext (Part 4) (Closed)

Created:
3 years, 8 months ago by adithyas
Modified:
3 years, 8 months ago
Reviewers:
haraken, jbroman
CC:
Aaron Boodman, abarth-chromium, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-frames_chromium.org, blink-reviews-html_chromium.org, blink-worker-reviews_chromium.org, caseq+blink_chromium.org, chasej+watch_chromium.org, chromium-reviews, darin (slow to review), dcheng, devtools-reviews_chromium.org, dglazkov+blink, dominicc+watchlist_chromium.org, eae+blinkwatch, Eric Willigers, falken+watch_chromium.org, horo+watch_chromium.org, iclelland+watch_chromuim.org, kinuko+fileapi, kinuko+worker_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, nhiroki, pfeldman+blink_chromium.org, qsr+mojo_chromium.org, rjwright, rwlbuis, shans, shimazu+worker_chromium.org, sof, tyoshino+watch_chromium.org, tzik, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ScriptState::GetExecutionContext (Part 4) This CL replaces all uses of ScriptState::GetExecutionContext in Source/core with ExecutionContext::From BUG=682322 Review-Url: https://codereview.chromium.org/2811863002 Cr-Commit-Position: refs/heads/master@{#463657} Committed: https://chromium.googlesource.com/chromium/src/+/fbb8b20231db093fffa5b3a361bac806c1920e82

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix Document.cpp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -45 lines) Patch
M third_party/WebKit/Source/core/animation/Animation.cpp View 3 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/ElementAnimation.h View 4 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/clipboard/DataTransferItem.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/FontFace.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/MessagePort.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/TaskRunnerHelper.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/Event.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/Blob.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp View 1 5 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/URLFileAPI.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/History.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/FormData.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/mojo/MojoHandle.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/streams/UnderlyingSourceBase.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/DictionaryTest.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/OriginTrialsTest.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/WorkerInternals.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceObserverTest.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/timing/SharedWorkerPerformance.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScope.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/DocumentXSLT.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Issue 2816543002 Patch 1

Messages

Total messages: 12 (6 generated)
adithyas
3 years, 8 months ago (2017-04-10 21:40:05 UTC) #2
haraken
LGTM
3 years, 8 months ago (2017-04-11 00:01:14 UTC) #3
jbroman
lgtm too https://codereview.chromium.org/2811863002/diff/1/third_party/WebKit/Source/core/dom/Document.cpp File third_party/WebKit/Source/core/dom/Document.cpp (right): https://codereview.chromium.org/2811863002/diff/1/third_party/WebKit/Source/core/dom/Document.cpp#newcode264 third_party/WebKit/Source/core/dom/Document.cpp:264: #include "core/dom/ExecutionContext.h" nit: this should be in ...
3 years, 8 months ago (2017-04-11 00:07:58 UTC) #5
adithyas
https://codereview.chromium.org/2811863002/diff/1/third_party/WebKit/Source/core/dom/Document.cpp File third_party/WebKit/Source/core/dom/Document.cpp (right): https://codereview.chromium.org/2811863002/diff/1/third_party/WebKit/Source/core/dom/Document.cpp#newcode264 third_party/WebKit/Source/core/dom/Document.cpp:264: #include "core/dom/ExecutionContext.h" On 2017/04/11 at 00:07:57, jbroman wrote: > ...
3 years, 8 months ago (2017-04-11 15:13:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811863002/20001
3 years, 8 months ago (2017-04-11 15:14:12 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 16:59:37 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fbb8b20231db093fffa5b3a361ba...

Powered by Google App Engine
This is Rietveld 408576698