Move ScriptState::GetExecutionContext (Part 4)

third_party/WebKit/Source/core/dom/Document.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All
  * rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
  * (http://www.torchmobile.com/)
  * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
@@ skipping 243 matching lines @@
 #include "wtf/DateMath.h"
 #include "wtf/Functional.h"
 #include "wtf/HashFunctions.h"
 #include "wtf/PtrUtil.h"
 #include "wtf/StdLibExtras.h"
 #include "wtf/text/CharacterNames.h"
 #include "wtf/text/StringBuffer.h"
 #include "wtf/text/TextEncodingRegistry.h"
 
 #include <memory>
+#include "core/dom/ExecutionContext.h"

[jbroman, 2017/04/11 00:07:57]

nit: this should be in the list of includes above, among the other core/dom
includes...except that it's not needed at all, as Document.h includes it
(because Document extends ExecutionContext)

[adithyas, 2017/04/11 15:13:47]

Ah good catch, my script didn't really account for this include style and the
fact that the include could already be in a header file... I should make it
smarter :)

 
 #ifndef NDEBUG
 using WeakDocumentSet =
     blink::PersistentHeapHashSet<blink::WeakMember<blink::Document>>;
 static WeakDocumentSet& liveDocumentSet();
 #endif
 
 namespace blink {
 
 using namespace HTMLNames;
@@ skipping 4241 matching lines @@
 void Document::RegisterEventFactory(
     std::unique_ptr<EventFactoryBase> event_factory) {
   DCHECK(!EventFactories().Contains(event_factory.get()));
   EventFactories().insert(std::move(event_factory));
 }
 
 Event* Document::createEvent(ScriptState* script_state,
                              const String& event_type,
                              ExceptionState& exception_state) {
   Event* event = nullptr;
-  ExecutionContext* execution_context = script_state->GetExecutionContext();
+  ExecutionContext* execution_context = ExecutionContext::From(script_state);
   for (const auto& factory : EventFactories()) {
     event = factory->Create(execution_context, event_type);
     if (event) {
       // createEvent for TouchEvent should throw DOM exception if touch event
       // feature detection is not enabled. See crbug.com/392584#c22
       if (EqualIgnoringCase(event_type, "TouchEvent") &&
           !RuntimeEnabledFeatures::touchEventFeatureDetectionEnabled())
         break;
       return event;
     }
@@ skipping 2124 matching lines @@
 }
 
 void showLiveDocumentInstances() {
   WeakDocumentSet& set = liveDocumentSet();
   fprintf(stderr, "There are %u documents currently alive:\n", set.size());
   for (blink::Document* document : set)
     fprintf(stderr, "- Document %p URL: %s\n", document,
             document->Url().GetString().Utf8().Data());
 }
 #endif