reland: mash: Remove ChromeLauncherController's |id_to_item_controller_map_|.

reland: mash: Remove ChromeLauncherController's |id_to_item_controller_map_|.

The original CL was reverted due to a unit_tests debug failure:
  https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/24583
This is the same (just sync'ed & rebased), but depends on a related fix:
  https://codereview.chromium.org/2812693002

=====================================================================
ORIGINAL DESCRIPTION from https://codereview.chromium.org/2798173002:

mash: Remove ChromeLauncherController's |id_to_item_controller_map_|.

Remove CLC::id_to_item_controller_map_; rely on ShelfModel instead.
Skip removing shelf items in CLC destruction; rely on ~ShelfModel instead.

Remove CLC::[Get|Set]ShelfItemDelegate helpers; inline ShelfModel calls.
Remove moot ShelfModelObserver::OnSetShelfItemDelegate.

Rename CLC::LauncherItemClosed -> RemoveShelfItem.
Rename test helper GetAppLaunchers -> GetPinnedAppIds.

Inline ShelfModel::RemoveShelfItemDelegate helper function.
Avoid GetItemIndexForType, use GetShelfIDForAppID instead.
Use ItemTypeIsPinned helper function.

BUG=557406
TEST=Automated; no Chrome OS shelf behavior changes.
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2811853002
Cr-Commit-Position: refs/heads/master@{#463383}
Committed: https://chromium.googlesource.com/chromium/src/+/56f79410ed4c847b056e853b5d0bae0b5e34aac1

[msw, 2017-04-10 19:06:58]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 19:07:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2017-04-10 19:22:14]

Hey James, please take a look; thanks!

[James Cook, 2017-04-10 19:31:07]

LGTM

[commit-bot: I haz the power, 2017-04-10 19:39:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 19:39:34]

Dry run: This issue passed the CQ dry run.

[msw, 2017-04-10 19:53:24]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2017-04-10 19:53:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 20:01:37]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491854004737090, "parent_rev":
"df8adb91c84b27c993e955497b2a50ea18ee9abb", "commit_rev":
"6fc1840a70eb4ec5864d3ff57447e175f044235b"}

[commit-bot: I haz the power, 2017-04-10 20:10:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 20:10:59]

Prior attempt to commit was detected, but we were not able to check whether the
issue was successfully committed. Please check Git history manually and re-check
CQ or close this issue as needed.

[msw, 2017-04-10 20:22:53]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2017-04-10 20:23:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 20:31:36]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491855773162890, "parent_rev":
"45abc2fca3b7649facd60cc64efd6d9e3db3b1b2", "commit_rev":
"56f79410ed4c847b056e853b5d0bae0b5e34aac1"}

[commit-bot: I haz the power, 2017-04-10 20:32:32]

Description was changed from

==========
reland: mash: Remove ChromeLauncherController's |id_to_item_controller_map_|.

The original CL was reverted due to a unit_tests debug failure:
 
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
This is the same (just sync'ed & rebased), but depends on a related fix:
  https://codereview.chromium.org/2812693002

=====================================================================
ORIGINAL DESCRIPTION from https://codereview.chromium.org/2798173002:

mash: Remove ChromeLauncherController's |id_to_item_controller_map_|.

Remove CLC::id_to_item_controller_map_; rely on ShelfModel instead.
Skip removing shelf items in CLC destruction; rely on ~ShelfModel instead.

Remove CLC::[Get|Set]ShelfItemDelegate helpers; inline ShelfModel calls.
Remove moot ShelfModelObserver::OnSetShelfItemDelegate.

Rename CLC::LauncherItemClosed -> RemoveShelfItem.
Rename test helper GetAppLaunchers -> GetPinnedAppIds.

Inline ShelfModel::RemoveShelfItemDelegate helper function.
Avoid GetItemIndexForType, use GetShelfIDForAppID instead.
Use ItemTypeIsPinned helper function.

BUG=557406
TEST=Automated; no Chrome OS shelf behavior changes.
R=jamescook@chromium.org
==========

to

==========
reland: mash: Remove ChromeLauncherController's |id_to_item_controller_map_|.

The original CL was reverted due to a unit_tests debug failure:
 
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
This is the same (just sync'ed & rebased), but depends on a related fix:
  https://codereview.chromium.org/2812693002

=====================================================================
ORIGINAL DESCRIPTION from https://codereview.chromium.org/2798173002:

mash: Remove ChromeLauncherController's |id_to_item_controller_map_|.

Remove CLC::id_to_item_controller_map_; rely on ShelfModel instead.
Skip removing shelf items in CLC destruction; rely on ~ShelfModel instead.

Remove CLC::[Get|Set]ShelfItemDelegate helpers; inline ShelfModel calls.
Remove moot ShelfModelObserver::OnSetShelfItemDelegate.

Rename CLC::LauncherItemClosed -> RemoveShelfItem.
Rename test helper GetAppLaunchers -> GetPinnedAppIds.

Inline ShelfModel::RemoveShelfItemDelegate helper function.
Avoid GetItemIndexForType, use GetShelfIDForAppID instead.
Use ItemTypeIsPinned helper function.

BUG=557406
TEST=Automated; no Chrome OS shelf behavior changes.
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2811853002
Cr-Commit-Position: refs/heads/master@{#463383}
Committed:
https://chromium.googlesource.com/chromium/src/+/56f79410ed4c847b056e853b5d0b...
==========

[commit-bot: I haz the power, 2017-04-10 20:32:34]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/56f79410ed4c847b056e853b5d0b...