mash: Fix controller ownership in LauncherContextMenuTest.

mash: Fix controller ownership in LauncherContextMenuTest.

Similar to https://codereview.chromium.org/2804913002/
Tests should create, but not own the ChromeLauncherControllerImpl.
Instead, install the CLC as Shell's ShelfDelegate.

Also cleanup: expose command enum, remove friend tests.

Fixes the test from https://codereview.chromium.org/2798173002

BUG=557406, 709729
TEST=Automated tests still pass; more closely match production.
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2812693002
Cr-Commit-Position: refs/heads/master@{#463363}
Committed: https://chromium.googlesource.com/chromium/src/+/b88cc04e9b44a1738e3628835338077f49667675

[msw, 2017-04-10 18:36:47]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 18:37:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2017-04-10 18:56:55]

Description was changed from

==========
mash: Fix controller ownership in LauncherContextMenuTest.

BUG=

mash: Fix controller ownership in LauncherContextMenuTest.
==========

to

==========
mash: Fix controller ownership in LauncherContextMenuTest.

Similar to https://codereview.chromium.org/2804913002/
Tests should create, but not own the ChromeLauncherControllerImpl.
Instead, install the CLC as Shell's ShelfDelegate.

Also cleanup: expose command enum, remove friend tests.

BUG=557406
TEST=Automated tests still pass; more closely match production.
R=jamescook@chromium.org
==========

[msw, 2017-04-10 18:56:56]

msw@chromium.org changed reviewers:
+ jamescook@chromium.org

[msw, 2017-04-10 19:02:58]

Hey James, please take a look; thanks!

[commit-bot: I haz the power, 2017-04-10 19:07:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 19:07:01]

Dry run: This issue passed the CQ dry run.

[msw, 2017-04-10 19:13:32]

Description was changed from

==========
mash: Fix controller ownership in LauncherContextMenuTest.

Similar to https://codereview.chromium.org/2804913002/
Tests should create, but not own the ChromeLauncherControllerImpl.
Instead, install the CLC as Shell's ShelfDelegate.

Also cleanup: expose command enum, remove friend tests.

BUG=557406
TEST=Automated tests still pass; more closely match production.
R=jamescook@chromium.org
==========

to

==========
mash: Fix controller ownership in LauncherContextMenuTest.

Similar to https://codereview.chromium.org/2804913002/
Tests should create, but not own the ChromeLauncherControllerImpl.
Instead, install the CLC as Shell's ShelfDelegate.

Also cleanup: expose command enum, remove friend tests.

Fixes the test from https://codereview.chromium.org/2798173002

BUG=557406,709729
TEST=Automated tests still pass; more closely match production.
R=jamescook@chromium.org
==========

[James Cook, 2017-04-10 19:26:37]

LGTM

[msw, 2017-04-10 19:27:51]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2017-04-10 19:28:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 19:35:02]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491852471736210, "parent_rev":
"007754f7d6f8116be3dc08b553e262156966706c", "commit_rev":
"b88cc04e9b44a1738e3628835338077f49667675"}

[commit-bot: I haz the power, 2017-04-10 19:35:49]

Description was changed from

==========
mash: Fix controller ownership in LauncherContextMenuTest.

Similar to https://codereview.chromium.org/2804913002/
Tests should create, but not own the ChromeLauncherControllerImpl.
Instead, install the CLC as Shell's ShelfDelegate.

Also cleanup: expose command enum, remove friend tests.

Fixes the test from https://codereview.chromium.org/2798173002

BUG=557406,709729
TEST=Automated tests still pass; more closely match production.
R=jamescook@chromium.org
==========

to

==========
mash: Fix controller ownership in LauncherContextMenuTest.

Similar to https://codereview.chromium.org/2804913002/
Tests should create, but not own the ChromeLauncherControllerImpl.
Instead, install the CLC as Shell's ShelfDelegate.

Also cleanup: expose command enum, remove friend tests.

Fixes the test from https://codereview.chromium.org/2798173002

BUG=557406,709729
TEST=Automated tests still pass; more closely match production.
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2812693002
Cr-Commit-Position: refs/heads/master@{#463363}
Committed:
https://chromium.googlesource.com/chromium/src/+/b88cc04e9b44a1738e3628835338...
==========

[commit-bot: I haz the power, 2017-04-10 19:35:50]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b88cc04e9b44a1738e3628835338...