Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h

Issue 2811853002: reland: mash: Remove ChromeLauncherController's |id_to_item_controller_map_|. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h
diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h
index a17c948889830611706aa3eb3baf164e561f1cde..e9a67927248383a783afe11e3ed886aa01f0e50a 100644
--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h
+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h
@@ -67,9 +67,6 @@ class ChromeLauncherControllerImpl
const ash::ShelfItem* GetItem(ash::ShelfID id) const override;
void SetItemType(ash::ShelfID id, ash::ShelfItemType type) override;
void SetItemStatus(ash::ShelfID id, ash::ShelfItemStatus status) override;
- void SetShelfItemDelegate(
- ash::ShelfID id,
- std::unique_ptr<ash::ShelfItemDelegate> item_delegate) override;
void CloseLauncherItem(ash::ShelfID id) override;
bool IsPinned(ash::ShelfID id) override;
void SetV1AppStatus(const std::string& app_id,
@@ -107,7 +104,6 @@ class ChromeLauncherControllerImpl
content::WebContents* web_contents) const override;
BrowserShortcutLauncherItemController*
GetBrowserShortcutLauncherItemController() override;
- ash::ShelfItemDelegate* GetShelfItemDelegate(const ash::ShelfID id) override;
bool ShelfBoundsChangesProbablyWithUser(
ash::WmShelf* shelf,
const AccountId& account_id) const override;
@@ -161,7 +157,6 @@ class ChromeLauncherControllerImpl
friend class TestChromeLauncherControllerImpl;
FRIEND_TEST_ALL_PREFIXES(ChromeLauncherControllerImplTest, AppPanels);
- typedef std::map<ash::ShelfID, ash::ShelfItemDelegate*> IDToItemControllerMap;
typedef std::map<content::WebContents*, std::string> WebContentsToAppIDMap;
// Remembers / restores list of running applications.
@@ -171,7 +166,7 @@ class ChromeLauncherControllerImpl
void RestoreUnpinnedRunningApplicationOrder(const std::string& user_id);
// Invoked when the associated browser or app is closed.
- void LauncherItemClosed(ash::ShelfID id);
+ void RemoveShelfItem(ash::ShelfID id);
// Internal helpers for pinning and unpinning that handle both
// client-triggered and internal pinning operations.
@@ -237,8 +232,6 @@ class ChromeLauncherControllerImpl
void ShelfItemRemoved(int index, const ash::ShelfItem& old_item) override;
void ShelfItemMoved(int start_index, int target_index) override;
void ShelfItemChanged(int index, const ash::ShelfItem& old_item) override;
- void OnSetShelfItemDelegate(ash::ShelfID id,
- ash::ShelfItemDelegate* item_delegate) override;
// ash::WindowTreeHostManager::Observer:
void OnDisplayConfigurationChanged() override;
@@ -261,9 +254,6 @@ class ChromeLauncherControllerImpl
ash::ShelfModel* model_;
- // Controller items in this map are owned by |ShelfModel|.
- IDToItemControllerMap id_to_item_controller_map_;
-
// Direct access to app_id for a web contents.
WebContentsToAppIDMap web_contents_to_app_id_;

Powered by Google App Engine
This is Rietveld 408576698