Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2811793005: Rename LocalFrame::Script() to GetScriptController() (Closed)

Created:
3 years, 8 months ago by hiroshige
Modified:
3 years, 8 months ago
CC:
chromium-reviews, devtools-reviews_chromium.org, caseq+blink_chromium.org, blink-reviews-html_chromium.org, blink-reviews-style_chromium.org, pfeldman+blink_chromium.org, sof, eae+blinkwatch, Yoav Weiss, lushnikov+blink_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, dominicc+watchlist_chromium.org, blink-reviews-bindings_chromium.org, jbroman+watch_chromium.org, blink-reviews, apavlov+blink_chromium.org, blink-reviews-frames_chromium.org, kozyatinskiy+blink_chromium.org, kinuko+watch, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename LocalFrame::Script() to GetScriptController() To avoid naming conflict between Script() and a new class Script that will be introduced by https://codereview.chromium.org/2780463002/. BUG=686281 Review-Url: https://codereview.chromium.org/2811793005 Cr-Commit-Position: refs/heads/master@{#463650} Committed: https://chromium.googlesource.com/chromium/src/+/2e93942b9e38b017648e248b79f60bbaceb5809d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -69 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptEventListener.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptLoader.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/EventTargetTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMTimerTest.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLDocument.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormElement.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/ImageLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/Page.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/DocumentXMLTreeViewer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/SuspendableScriptExecutor.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsFrontendImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 6 chunks +12 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ResizeObserverTest.cpp View 3 chunks +6 lines, -5 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (10 generated)
hiroshige
PTAL.
3 years, 8 months ago (2017-04-11 00:42:15 UTC) #5
hiroshige
+japhet@ (bindings/ and web/ OWNER)
3 years, 8 months ago (2017-04-11 00:50:06 UTC) #7
kouhei (in TOK)
lgtm
3 years, 8 months ago (2017-04-11 00:50:26 UTC) #8
haraken
LGTM
3 years, 8 months ago (2017-04-11 00:52:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811793005/1
3 years, 8 months ago (2017-04-11 15:55:49 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 16:22:13 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2e93942b9e38b017648e248b79f6...

Powered by Google App Engine
This is Rietveld 408576698