Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2807343002: Rename ScriptResource/WorkerScriptLoader::Script() to SourceText() (Closed)

Created:
3 years, 8 months ago by hiroshige
Modified:
3 years, 8 months ago
CC:
chromium-reviews, kinuko+worker_chromium.org, caseq+blink_chromium.org, horo+watch_chromium.org, lushnikov+blink_chromium.org, shimazu+worker_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, falken+watch_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename ScriptResource/WorkerScriptLoader::Script() to SourceText() To avoid naming conflict between Script() and a new class Script that will be introduced by https://codereview.chromium.org/2780463002/. BUG=686281 Review-Url: https://codereview.chromium.org/2807343002 Cr-Commit-Position: refs/heads/master@{#463641} Committed: https://chromium.googlesource.com/chromium/src/+/ffc3b8b65470e1a2fe1e27e7f3e75227a46ddddf

Patch Set 1 #

Messages

Total messages: 16 (10 generated)
hiroshige
PTAL.
3 years, 8 months ago (2017-04-11 00:42:10 UTC) #5
kouhei (in TOK)
lgtm +japhet
3 years, 8 months ago (2017-04-11 00:50:06 UTC) #7
haraken
LGTM
3 years, 8 months ago (2017-04-11 00:52:28 UTC) #8
yhirano
lgtm
3 years, 8 months ago (2017-04-11 03:44:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807343002/1
3 years, 8 months ago (2017-04-11 15:44:25 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 15:50:00 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ffc3b8b65470e1a2fe1e27e7f3e7...

Powered by Google App Engine
This is Rietveld 408576698