Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2811783002: [LayoutNG] Move inline files to the inline directory (Closed)

Created:
3 years, 8 months ago by kojii
Modified:
3 years, 8 months ago
Reviewers:
eae
CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, dgrogan+ng_chromium.org, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Move inline files to the inline directory BUG=636993 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng Review-Url: https://codereview.chromium.org/2811783002 Cr-Commit-Position: refs/heads/master@{#463492} Committed: https://chromium.googlesource.com/chromium/src/+/49f2af88a8984e00c20730a9257493f5c8b40d88

Patch Set 1 #

Patch Set 2 : Fix unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -3863 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/BUILD.gn View 4 chunks +25 lines, -25 lines 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/inline/ng_bidi_paragraph.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/inline/ng_bidi_paragraph.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/inline/ng_inline_break_token.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/inline/ng_inline_break_token.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc View 2 chunks +9 lines, -9 lines 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm_test.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.cc View 1 chunk +7 lines, -7 lines 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node_test.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/inline/ng_layout_inline_items_builder.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/inline/ng_layout_inline_items_builder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/inline/ng_layout_inline_items_builder_test.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment.cc View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/inline/ng_line_height_metrics.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/inline/ng_line_height_metrics.cc View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/inline/ng_physical_line_box_fragment.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/inline/ng_physical_line_box_fragment.cc View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/inline/ng_physical_text_fragment.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/inline/ng_text_fragment.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/inline/ng_text_fragment.cc View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/inline/ng_text_fragment_builder.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/inline/ng_text_fragment_builder.cc View 1 chunk +3 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_bidi_paragraph.h View 1 chunk +0 lines, -57 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_bidi_paragraph.cc View 1 chunk +0 lines, -54 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_node.cc View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_inline_break_token.h View 1 chunk +0 lines, -53 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_inline_break_token.cc View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.h View 1 chunk +0 lines, -175 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.cc View 1 chunk +0 lines, -666 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm_test.cc View 1 chunk +0 lines, -303 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_inline_node.h View 1 chunk +0 lines, -254 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc View 1 chunk +0 lines, -378 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc View 1 chunk +0 lines, -334 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder.h View 1 chunk +0 lines, -118 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder.cc View 1 chunk +0 lines, -371 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder_test.cc View 1 chunk +0 lines, -338 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_line_box_fragment.h View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_line_box_fragment.cc View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_line_box_fragment_builder.h View 1 chunk +0 lines, -64 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_line_box_fragment_builder.cc View 1 chunk +0 lines, -79 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_line_breaker.h View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_line_breaker.cc View 1 chunk +0 lines, -97 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_line_height_metrics.h View 1 chunk +0 lines, -53 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_line_height_metrics.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_physical_line_box_fragment.h View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_physical_line_box_fragment.cc View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_physical_text_fragment.h View 1 chunk +0 lines, -56 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_text_fragment.h View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_text_fragment.cc View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_text_fragment_builder.h View 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_text_fragment_builder.cc View 1 chunk +0 lines, -48 lines 0 comments Download
M third_party/WebKit/Source/web/tests/NGInlineLayoutTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (14 generated)
kojii
PTAL.
3 years, 8 months ago (2017-04-10 16:21:10 UTC) #6
eae
LGTM Awesome, thanks for doing this!
3 years, 8 months ago (2017-04-10 18:55:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811783002/20001
3 years, 8 months ago (2017-04-11 01:34:34 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 01:50:20 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/49f2af88a8984e00c20730a92574...

Powered by Google App Engine
This is Rietveld 408576698