Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc

Issue 2811783002: [LayoutNG] Move inline files to the inline directory (Closed)
Patch Set: Fix unit tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc
deleted file mode 100644
index 52ce8fcebca4dc72bd34a521585d6b87969ef94a..0000000000000000000000000000000000000000
--- a/third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc
+++ /dev/null
@@ -1,334 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "core/layout/ng/ng_inline_node.h"
-
-#include "core/layout/LayoutTestHelper.h"
-#include "core/layout/ng/ng_constraint_space.h"
-#include "core/layout/ng/ng_constraint_space_builder.h"
-#include "core/layout/ng/ng_fragment_builder.h"
-#include "core/layout/ng/ng_inline_layout_algorithm.h"
-#include "core/layout/ng/ng_physical_box_fragment.h"
-#include "core/layout/ng/ng_physical_line_box_fragment.h"
-#include "core/layout/ng/ng_physical_text_fragment.h"
-#include "core/layout/ng/ng_text_fragment.h"
-#include "core/style/ComputedStyle.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-namespace blink {
-
-class NGInlineNodeForTest : public NGInlineNode {
- public:
- using NGInlineNode::NGInlineNode;
-
- String& Text() { return text_content_; }
- Vector<NGLayoutInlineItem>& Items() { return items_; }
-
- void Append(const String& text,
- const ComputedStyle* style = nullptr,
- LayoutObject* layout_object = nullptr) {
- unsigned start = text_content_.length();
- text_content_.Append(text);
- items_.push_back(NGLayoutInlineItem(NGLayoutInlineItem::kText, start,
- start + text.length(), style,
- layout_object));
- }
-
- void Append(UChar character) {
- text_content_.Append(character);
- unsigned end = text_content_.length();
- items_.push_back(NGLayoutInlineItem(NGLayoutInlineItem::kBidiControl,
- end - 1, end, nullptr));
- is_bidi_enabled_ = true;
- }
-
- void ClearText() {
- text_content_ = String();
- items_.Clear();
- }
-
- void SegmentText() {
- is_bidi_enabled_ = true;
- NGInlineNode::SegmentText();
- }
-
- using NGInlineNode::CollectInlines;
- using NGInlineNode::ShapeText;
-};
-
-class NGInlineNodeTest : public RenderingTest {
- protected:
- void SetUp() override {
- RenderingTest::SetUp();
- style_ = ComputedStyle::Create();
- style_->GetFont().Update(nullptr);
- }
-
- void SetupHtml(const char* id, String html) {
- SetBodyInnerHTML(html);
- layout_block_flow_ = ToLayoutBlockFlow(GetLayoutObjectByElementId(id));
- layout_object_ = layout_block_flow_->FirstChild();
- style_ = layout_object_->Style();
- }
-
- void UseLayoutObjectAndAhem() {
- // Get Ahem from document. Loading "Ahem.woff" using |createTestFont| fails
- // on linux_chromium_asan_rel_ng.
- LoadAhem();
- SetupHtml("t", "<div id=t style='font:10px Ahem'>test</div>");
- }
-
- NGInlineNodeForTest* CreateInlineNode() {
- if (!layout_block_flow_)
- SetupHtml("t", "<div id=t style='font:10px'>test</div>");
- return new NGInlineNodeForTest(layout_object_, layout_block_flow_);
- }
-
- void CreateLine(NGInlineNode* node,
- Vector<RefPtr<const NGPhysicalTextFragment>>* fragments_out) {
- RefPtr<NGConstraintSpace> constraint_space =
- NGConstraintSpaceBuilder(kHorizontalTopBottom)
- .ToConstraintSpace(kHorizontalTopBottom);
- RefPtr<NGLayoutResult> result =
- NGInlineLayoutAlgorithm(node, constraint_space.Get()).Layout();
-
- const NGPhysicalBoxFragment* container =
- ToNGPhysicalBoxFragment(result->PhysicalFragment().Get());
- EXPECT_EQ(container->Children().size(), 1u);
- const NGPhysicalLineBoxFragment* line =
- ToNGPhysicalLineBoxFragment(container->Children()[0].Get());
- for (const auto& child : line->Children()) {
- fragments_out->push_back(ToNGPhysicalTextFragment(child.Get()));
- }
- }
-
- RefPtr<const ComputedStyle> style_;
- LayoutBlockFlow* layout_block_flow_ = nullptr;
- LayoutObject* layout_object_ = nullptr;
- FontCachePurgePreventer purge_preventer_;
-};
-
-#define TEST_ITEM_TYPE_OFFSET(item, type, start, end) \
- EXPECT_EQ(NGLayoutInlineItem::type, item.Type()); \
- EXPECT_EQ(start, item.StartOffset()); \
- EXPECT_EQ(end, item.EndOffset())
-
-#define TEST_ITEM_TYPE_OFFSET_LEVEL(item, type, start, end, level) \
- EXPECT_EQ(NGLayoutInlineItem::type, item.Type()); \
- EXPECT_EQ(start, item.StartOffset()); \
- EXPECT_EQ(end, item.EndOffset()); \
- EXPECT_EQ(level, item.BidiLevel())
-
-#define TEST_ITEM_OFFSET_DIR(item, start, end, direction) \
- EXPECT_EQ(start, item.StartOffset()); \
- EXPECT_EQ(end, item.EndOffset()); \
- EXPECT_EQ(direction, item.Direction())
-
-TEST_F(NGInlineNodeTest, CollectInlinesText) {
- SetupHtml("t", "<div id=t>Hello <span>inline</span> world.</div>");
- NGInlineNodeForTest* node = CreateInlineNode();
- node->CollectInlines(layout_object_, layout_block_flow_);
- Vector<NGLayoutInlineItem>& items = node->Items();
- TEST_ITEM_TYPE_OFFSET(items[0], kText, 0u, 6u);
- TEST_ITEM_TYPE_OFFSET(items[1], kOpenTag, 6u, 6u);
- TEST_ITEM_TYPE_OFFSET(items[2], kText, 6u, 12u);
- TEST_ITEM_TYPE_OFFSET(items[3], kCloseTag, 12u, 12u);
- TEST_ITEM_TYPE_OFFSET(items[4], kText, 12u, 19u);
- EXPECT_EQ(5u, items.size());
-}
-
-TEST_F(NGInlineNodeTest, CollectInlinesRtlText) {
- SetupHtml("t", u"<div id=t dir=rtl>\u05E2 <span>\u05E2</span> \u05E2</div>");
- NGInlineNodeForTest* node = CreateInlineNode();
- node->CollectInlines(layout_object_, layout_block_flow_);
- EXPECT_TRUE(node->IsBidiEnabled());
- node->SegmentText();
- EXPECT_TRUE(node->IsBidiEnabled());
- Vector<NGLayoutInlineItem>& items = node->Items();
- TEST_ITEM_TYPE_OFFSET_LEVEL(items[0], kText, 0u, 2u, 1u);
- TEST_ITEM_TYPE_OFFSET_LEVEL(items[1], kOpenTag, 2u, 2u, 1u);
- TEST_ITEM_TYPE_OFFSET_LEVEL(items[2], kText, 2u, 3u, 1u);
- TEST_ITEM_TYPE_OFFSET_LEVEL(items[3], kCloseTag, 3u, 3u, 1u);
- TEST_ITEM_TYPE_OFFSET_LEVEL(items[4], kText, 3u, 5u, 1u);
- EXPECT_EQ(5u, items.size());
-}
-
-TEST_F(NGInlineNodeTest, CollectInlinesMixedText) {
- SetupHtml("t", u"<div id=t>Hello, \u05E2 <span>\u05E2</span></div>");
- NGInlineNodeForTest* node = CreateInlineNode();
- node->CollectInlines(layout_object_, layout_block_flow_);
- EXPECT_TRUE(node->IsBidiEnabled());
- node->SegmentText();
- EXPECT_TRUE(node->IsBidiEnabled());
- Vector<NGLayoutInlineItem>& items = node->Items();
- TEST_ITEM_TYPE_OFFSET_LEVEL(items[0], kText, 0u, 7u, 0u);
- TEST_ITEM_TYPE_OFFSET_LEVEL(items[1], kText, 7u, 9u, 1u);
- TEST_ITEM_TYPE_OFFSET_LEVEL(items[2], kOpenTag, 9u, 9u, 1u);
- TEST_ITEM_TYPE_OFFSET_LEVEL(items[3], kText, 9u, 10u, 1u);
- TEST_ITEM_TYPE_OFFSET_LEVEL(items[4], kCloseTag, 10u, 10u, 1u);
- EXPECT_EQ(5u, items.size());
-}
-
-TEST_F(NGInlineNodeTest, CollectInlinesMixedTextEndWithON) {
- SetupHtml("t", u"<div id=t>Hello, \u05E2 <span>\u05E2!</span></div>");
- NGInlineNodeForTest* node = CreateInlineNode();
- node->CollectInlines(layout_object_, layout_block_flow_);
- EXPECT_TRUE(node->IsBidiEnabled());
- node->SegmentText();
- EXPECT_TRUE(node->IsBidiEnabled());
- Vector<NGLayoutInlineItem>& items = node->Items();
- TEST_ITEM_TYPE_OFFSET_LEVEL(items[0], kText, 0u, 7u, 0u);
- TEST_ITEM_TYPE_OFFSET_LEVEL(items[1], kText, 7u, 9u, 1u);
- TEST_ITEM_TYPE_OFFSET_LEVEL(items[2], kOpenTag, 9u, 9u, 1u);
- TEST_ITEM_TYPE_OFFSET_LEVEL(items[3], kText, 9u, 10u, 1u);
- TEST_ITEM_TYPE_OFFSET_LEVEL(items[4], kText, 10u, 11u, 0u);
- TEST_ITEM_TYPE_OFFSET_LEVEL(items[5], kCloseTag, 11u, 11u, 0u);
- EXPECT_EQ(6u, items.size());
-}
-
-TEST_F(NGInlineNodeTest, SegmentASCII) {
- NGInlineNodeForTest* node = CreateInlineNode();
- node->Append("Hello");
- node->SegmentText();
- Vector<NGLayoutInlineItem>& items = node->Items();
- ASSERT_EQ(1u, items.size());
- TEST_ITEM_OFFSET_DIR(items[0], 0u, 5u, TextDirection::kLtr);
-}
-
-TEST_F(NGInlineNodeTest, SegmentHebrew) {
- NGInlineNodeForTest* node = CreateInlineNode();
- node->Append(u"\u05E2\u05D1\u05E8\u05D9\u05EA");
- node->SegmentText();
- ASSERT_EQ(1u, node->Items().size());
- Vector<NGLayoutInlineItem>& items = node->Items();
- ASSERT_EQ(1u, items.size());
- TEST_ITEM_OFFSET_DIR(items[0], 0u, 5u, TextDirection::kRtl);
-}
-
-TEST_F(NGInlineNodeTest, SegmentSplit1To2) {
- NGInlineNodeForTest* node = CreateInlineNode();
- node->Append(u"Hello \u05E2\u05D1\u05E8\u05D9\u05EA");
- node->SegmentText();
- ASSERT_EQ(2u, node->Items().size());
- Vector<NGLayoutInlineItem>& items = node->Items();
- ASSERT_EQ(2u, items.size());
- TEST_ITEM_OFFSET_DIR(items[0], 0u, 6u, TextDirection::kLtr);
- TEST_ITEM_OFFSET_DIR(items[1], 6u, 11u, TextDirection::kRtl);
-}
-
-TEST_F(NGInlineNodeTest, SegmentSplit3To4) {
- NGInlineNodeForTest* node = CreateInlineNode();
- node->Append("Hel");
- node->Append(u"lo \u05E2");
- node->Append(u"\u05D1\u05E8\u05D9\u05EA");
- node->SegmentText();
- Vector<NGLayoutInlineItem>& items = node->Items();
- ASSERT_EQ(4u, items.size());
- TEST_ITEM_OFFSET_DIR(items[0], 0u, 3u, TextDirection::kLtr);
- TEST_ITEM_OFFSET_DIR(items[1], 3u, 6u, TextDirection::kLtr);
- TEST_ITEM_OFFSET_DIR(items[2], 6u, 7u, TextDirection::kRtl);
- TEST_ITEM_OFFSET_DIR(items[3], 7u, 11u, TextDirection::kRtl);
-}
-
-TEST_F(NGInlineNodeTest, SegmentBidiOverride) {
- NGInlineNodeForTest* node = CreateInlineNode();
- node->Append("Hello ");
- node->Append(kRightToLeftOverrideCharacter);
- node->Append("ABC");
- node->Append(kPopDirectionalFormattingCharacter);
- node->SegmentText();
- Vector<NGLayoutInlineItem>& items = node->Items();
- ASSERT_EQ(4u, items.size());
- TEST_ITEM_OFFSET_DIR(items[0], 0u, 6u, TextDirection::kLtr);
- TEST_ITEM_OFFSET_DIR(items[1], 6u, 7u, TextDirection::kRtl);
- TEST_ITEM_OFFSET_DIR(items[2], 7u, 10u, TextDirection::kRtl);
- TEST_ITEM_OFFSET_DIR(items[3], 10u, 11u, TextDirection::kLtr);
-}
-
-static NGInlineNodeForTest* CreateBidiIsolateNode(NGInlineNodeForTest* node,
- const ComputedStyle* style,
- LayoutObject* layout_object) {
- node->Append("Hello ", style, layout_object);
- node->Append(kRightToLeftIsolateCharacter);
- node->Append(u"\u05E2\u05D1\u05E8\u05D9\u05EA ", style, layout_object);
- node->Append(kLeftToRightIsolateCharacter);
- node->Append("A", style, layout_object);
- node->Append(kPopDirectionalIsolateCharacter);
- node->Append(u"\u05E2\u05D1\u05E8\u05D9\u05EA", style, layout_object);
- node->Append(kPopDirectionalIsolateCharacter);
- node->Append(" World", style, layout_object);
- node->SegmentText();
- return node;
-}
-
-TEST_F(NGInlineNodeTest, SegmentBidiIsolate) {
- NGInlineNodeForTest* node =
- CreateBidiIsolateNode(CreateInlineNode(), style_.Get(), layout_object_);
- Vector<NGLayoutInlineItem>& items = node->Items();
- ASSERT_EQ(9u, items.size());
- TEST_ITEM_OFFSET_DIR(items[0], 0u, 6u, TextDirection::kLtr);
- TEST_ITEM_OFFSET_DIR(items[1], 6u, 7u, TextDirection::kLtr);
- TEST_ITEM_OFFSET_DIR(items[2], 7u, 13u, TextDirection::kRtl);
- TEST_ITEM_OFFSET_DIR(items[3], 13u, 14u, TextDirection::kRtl);
- TEST_ITEM_OFFSET_DIR(items[4], 14u, 15u, TextDirection::kLtr);
- TEST_ITEM_OFFSET_DIR(items[5], 15u, 16u, TextDirection::kRtl);
- TEST_ITEM_OFFSET_DIR(items[6], 16u, 21u, TextDirection::kRtl);
- TEST_ITEM_OFFSET_DIR(items[7], 21u, 22u, TextDirection::kLtr);
- TEST_ITEM_OFFSET_DIR(items[8], 22u, 28u, TextDirection::kLtr);
-}
-
-#define TEST_TEXT_FRAGMENT(fragment, node, index, start_offset, end_offset, \
- dir) \
- EXPECT_EQ(node, fragment->Node()); \
- EXPECT_EQ(index, fragment->ItemIndex()); \
- EXPECT_EQ(start_offset, fragment->StartOffset()); \
- EXPECT_EQ(end_offset, fragment->EndOffset()); \
- EXPECT_EQ(dir, node->Items()[fragment->ItemIndex()].Direction())
-
-TEST_F(NGInlineNodeTest, CreateLineBidiIsolate) {
- UseLayoutObjectAndAhem();
- RefPtr<ComputedStyle> style = ComputedStyle::Create();
- style->SetLineHeight(Length(1, kFixed));
- style->GetFont().Update(nullptr);
- NGInlineNodeForTest* node =
- CreateBidiIsolateNode(CreateInlineNode(), style.Get(), layout_object_);
- node->ShapeText();
- Vector<RefPtr<const NGPhysicalTextFragment>> fragments;
- CreateLine(node, &fragments);
- ASSERT_EQ(5u, fragments.size());
- TEST_TEXT_FRAGMENT(fragments[0], node, 0u, 0u, 6u, TextDirection::kLtr);
- TEST_TEXT_FRAGMENT(fragments[1], node, 6u, 16u, 21u, TextDirection::kRtl);
- TEST_TEXT_FRAGMENT(fragments[2], node, 4u, 14u, 15u, TextDirection::kLtr);
- TEST_TEXT_FRAGMENT(fragments[3], node, 2u, 7u, 13u, TextDirection::kRtl);
- TEST_TEXT_FRAGMENT(fragments[4], node, 8u, 22u, 28u, TextDirection::kLtr);
-}
-
-TEST_F(NGInlineNodeTest, MinMaxContentSize) {
- UseLayoutObjectAndAhem();
- NGInlineNodeForTest* node = CreateInlineNode();
- node->Append("AB CDE", style_.Get(), layout_object_);
- node->ShapeText();
- MinMaxContentSize sizes = node->ComputeMinMaxContentSize();
- // TODO(kojii): min_content should be 20, but is 30 until
- // NGInlineLayoutAlgorithm implements trailing spaces correctly.
- EXPECT_EQ(30, sizes.min_content);
- EXPECT_EQ(60, sizes.max_content);
-}
-
-TEST_F(NGInlineNodeTest, MinMaxContentSizeElementBoundary) {
- UseLayoutObjectAndAhem();
- NGInlineNodeForTest* node = CreateInlineNode();
- node->Append("A B", style_.Get(), layout_object_);
- node->Append("C D", style_.Get(), layout_object_);
- node->ShapeText();
- MinMaxContentSize sizes = node->ComputeMinMaxContentSize();
- // |min_content| should be the width of "BC" because there is an element
- // boundary between "B" and "C" but no break opportunities.
- // TODO(kojii): min_content should be 20, but is 30 until
- // NGInlineLayoutAlgorithm implements trailing spaces correctly.
- EXPECT_EQ(30, sizes.min_content);
- EXPECT_EQ(60, sizes.max_content);
-}
-
-} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698