Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2811693003: Revert of Fix PlatformInfo variation for mime util IsCodecSupportedOnAndroidTest (Closed)

Created:
3 years, 8 months ago by Mike West
Modified:
3 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix PlatformInfo variation for mime util IsCodecSupportedOnAndroidTest (patchset #1 id:1 of https://codereview.chromium.org/2804883007/ ) Reason for revert: Broke IsCodecSupportedOnAndroidTest on https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/24644. Original issue's description: > Fix PlatformInfo variation for mime util IsCodecSupportedOnAndroidTest > > The parameterized template function RunCodecSupportTest is supposed to > invoke tested callback with different combinations of PlatformInfo settings, > but it actually used only initial values of PlatformInfo fields. > > Also it seems that H264 is always supported for non-encrypted video, so the > test IsCodecSupportedOnAndroidTest.ClearCodecBehavior should be corrected. > This has been revealed only after fixing parameter variation. > > R=chcunningham, dalecurtis > BUG=709428 > > Review-Url: https://codereview.chromium.org/2804883007 > Cr-Commit-Position: refs/heads/master@{#463213} > Committed: https://chromium.googlesource.com/chromium/src/+/1b75c4d80c9ac27428c760c727c39500d6e8c27b TBR=chcunningham@chromium.org,dalecurtis@chromium.org,pavor@yandex-team.ru # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=709428 Review-Url: https://codereview.chromium.org/2811693003 Cr-Commit-Position: refs/heads/master@{#463229} Committed: https://chromium.googlesource.com/chromium/src/+/e8172a213e56ea4862d5337c975e5d3c7ad50dfe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M media/base/mime_util_unittest.cc View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Mike West
Created Revert of Fix PlatformInfo variation for mime util IsCodecSupportedOnAndroidTest
3 years, 8 months ago (2017-04-10 12:18:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811693003/1
3 years, 8 months ago (2017-04-10 12:18:45 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 12:20:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e8172a213e56ea4862d5337c975e...

Powered by Google App Engine
This is Rietveld 408576698