Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 2804883007: Fix PlatformInfo variation for mime util IsCodecSupportedOnAndroidTest (Closed)

Created:
3 years, 8 months ago by pavor
Modified:
3 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix PlatformInfo variation for mime util IsCodecSupportedOnAndroidTest The parameterized template function RunCodecSupportTest is supposed to invoke tested callback with different combinations of PlatformInfo settings, but it actually used only initial values of PlatformInfo fields. Also it seems that H264 is always supported for non-encrypted video, so the test IsCodecSupportedOnAndroidTest.ClearCodecBehavior should be corrected. This has been revealed only after fixing parameter variation. R=chcunningham, dalecurtis BUG=709428

Patch Set 1 #

Patch Set 2 : take state by index only inside RUN_TEST_VECTOR loop #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M media/base/mime_util_unittest.cc View 1 4 chunks +18 lines, -18 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
pavor
3 years, 8 months ago (2017-04-07 12:16:07 UTC) #1
chcunningham
LGTM. Thanks for fixing it!
3 years, 8 months ago (2017-04-08 00:04:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804883007/1
3 years, 8 months ago (2017-04-10 09:12:30 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/1b75c4d80c9ac27428c760c727c39500d6e8c27b
3 years, 8 months ago (2017-04-10 10:30:26 UTC) #11
Mike West
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2811693003/ by mkwst@chromium.org. ...
3 years, 8 months ago (2017-04-10 12:18:34 UTC) #12
Mike West
On 2017/04/10 at 12:18:34, Mike West wrote: > A revert of this CL (patchset #1 ...
3 years, 8 months ago (2017-04-10 12:19:32 UTC) #13
findit-for-me
3 years, 8 months ago (2017-04-10 12:27:19 UTC) #14
Message was sent while issue was closed.
Findit identified this CL at revision 463213 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Powered by Google App Engine
This is Rietveld 408576698