Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Unified Diff: media/base/mime_util_unittest.cc

Issue 2811693003: Revert of Fix PlatformInfo variation for mime util IsCodecSupportedOnAndroidTest (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/mime_util_unittest.cc
diff --git a/media/base/mime_util_unittest.cc b/media/base/mime_util_unittest.cc
index d229db9a3e1d89a8eb9774ff684ac0c917dda2c3..5e0f598e48374e10471056d9ecb82b2e5077e7dd 100644
--- a/media/base/mime_util_unittest.cc
+++ b/media/base/mime_util_unittest.cc
@@ -65,8 +65,8 @@
MimeUtil::PlatformInfo info;
#define RUN_TEST_VECTOR(name) \
- for (size_t name##_index = 0; \
- info.name = name##_states[name##_index], \
+ size_t name##_index = 0; \
+ for (info.name = name##_states[name##_index]; \
name##_index < name##_states.size(); ++name##_index)
RUN_TEST_VECTOR(has_platform_decoders) {
@@ -333,7 +333,6 @@
// These codecs are always supported with the unified pipeline.
case MimeUtil::FLAC:
- case MimeUtil::H264:
case MimeUtil::PCM:
case MimeUtil::MPEG2_AAC:
case MimeUtil::MP3:
@@ -346,6 +345,10 @@
break;
// These codecs are only supported if platform decoders are supported.
+ case MimeUtil::H264:
+ EXPECT_EQ(info.has_platform_decoders, result);
+ break;
+
case MimeUtil::HEVC:
EXPECT_EQ(HasHevcSupport() && info.has_platform_decoders, result);
break;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698