cros: Refactor oobe LoadUsers to include non-serialized user list.

cros: Refactor oobe LoadUsers to include non-serialized user list.

UI-agnostic login code probably should not be serializing the user list
(that should be done in the *Handlers), but that is a bigger cleanup to
be done later.

BUG=623344
Review-Url: https://codereview.chromium.org/2811383002
Cr-Commit-Position: refs/heads/master@{#476086}
Committed: https://chromium.googlesource.com/chromium/src/+/8aa42069f00f64237851e549f94e49c328f1a1fc

[jdufault, 2017-04-12 18:50:13]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 18:51:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 21:17:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 21:17:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jdufault, 2017-04-12 22:37:42]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 22:39:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 23:51:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 23:51:11]

Dry run: This issue passed the CQ dry run.

[jdufault, 2017-05-11 18:25:32]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 18:26:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdufault, 2017-05-11 18:34:41]

Description was changed from

==========
cros: Refactor oobe LoadUsers to include non-serialized user list.

UI-agnostic login code probably should not be serializing the user list
(that should be done in the *Handlers), but that is a bigger cleanup to
be done later.

BUG=623344
==========

to

==========
cros: Refactor oobe LoadUsers to include non-serialized user list.

UI-agnostic login code probably should not be serializing the user list
(that should be done in the *Handlers), but that is a bigger cleanup to
be done later.

BUG=623344
==========

[jdufault, 2017-05-11 18:34:41]

jdufault@chromium.org changed reviewers:
+ alemate@chromium.org

[jdufault, 2017-05-11 18:35:04]

alemate@ PTAL

[commit-bot: I haz the power, 2017-05-11 19:17:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 19:17:27]

Dry run: This issue passed the CQ dry run.

[Alexander Alekseev, 2017-05-12 03:43:44]

https://codereview.chromium.org/2811383002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc (right):

https://codereview.chromium.org/2811383002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc:1309: const
base::ListValue& users_list) {
Why do we need |users| here?

[jdufault, 2017-05-12 16:46:41]

https://codereview.chromium.org/2811383002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc (right):

https://codereview.chromium.org/2811383002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc:1309: const
base::ListValue& users_list) {
On 2017/05/12 03:43:44, Alexander Alekseev wrote:
> Why do we need |users| here?

It gets used in a separate CL, see this[1] file.

1:
https://codereview.chromium.org/2809993004/diff/40001/chrome/browser/ui/webui...

[Alexander Alekseev, 2017-05-12 22:41:53]

lgtm

[jdufault, 2017-05-31 22:51:00]

The CQ bit was checked by jdufault@chromium.org

[commit-bot: I haz the power, 2017-05-31 22:51:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 23:19:25]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496271060508540,
"parent_rev": "e3db9988b2c7e8b41f75b9d326edad68cdb0b184", "commit_rev":
"8aa42069f00f64237851e549f94e49c328f1a1fc"}

[commit-bot: I haz the power, 2017-05-31 23:19:36]

Description was changed from

==========
cros: Refactor oobe LoadUsers to include non-serialized user list.

UI-agnostic login code probably should not be serializing the user list
(that should be done in the *Handlers), but that is a bigger cleanup to
be done later.

BUG=623344
==========

to

==========
cros: Refactor oobe LoadUsers to include non-serialized user list.

UI-agnostic login code probably should not be serializing the user list
(that should be done in the *Handlers), but that is a bigger cleanup to
be done later.

BUG=623344

Review-Url: https://codereview.chromium.org/2811383002
Cr-Commit-Position: refs/heads/master@{#476086}
Committed:
https://chromium.googlesource.com/chromium/src/+/8aa42069f00f64237851e549f94e...
==========

[commit-bot: I haz the power, 2017-05-31 23:19:37]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8aa42069f00f64237851e549f94e...