Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1680)

Unified Diff: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

Issue 2811383002: cros: Refactor oobe LoadUsers to include non-serialized user list. (Closed)
Patch Set: Initial upload Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
index 8367856ab34133fe70cb5280807022217d3ae131..c52fde6eb51ef8e314241bbca543cbb538dc0f4c 100644
--- a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
+++ b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
@@ -708,7 +708,7 @@ void SigninScreenHandler::ShowImpl() {
OnShowAddUser();
} else {
// Populates account picker. Animation is turned off for now until we
- // figure out how to make it fast enough.
+ // figure out how to make it fast enough. This will call LoadUsers.
delegate_->HandleGetUsers();
// Reset Caps Lock state when login screen is shown.
@@ -1305,8 +1305,8 @@ void SigninScreenHandler::HandleToggleKioskAutolaunchScreen() {
delegate_->ShowKioskAutolaunchScreen();
}
-void SigninScreenHandler::LoadUsers(const base::ListValue& users_list,
- bool showGuest) {
+void SigninScreenHandler::LoadUsers(const user_manager::UserList& users,
+ const base::ListValue& users_list) {
Alexander Alekseev 2017/05/12 03:43:44 Why do we need |users| here?
jdufault 2017/05/12 16:46:41 It gets used in a separate CL, see this[1] file.
CallJSOrDefer("login.AccountPickerScreen.loadUsers", users_list,
delegate_->IsShowGuest());
}
« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698