cros: Add PinStorageProvider enum which describes pin backend in use.

cros: Add PinStorageProvider enum which describes pin backend in use.

Not currently used, will be used in a follow-up CL.

This enum will probably go away after the cryptohome APIs are finished.

BUG=623344
Review-Url: https://codereview.chromium.org/2815733003
Cr-Commit-Position: refs/heads/master@{#470684}
Committed: https://chromium.googlesource.com/chromium/src/+/fccaadd4b0451db39c4ae3b61fa1b6bc24afdc2b

[jdufault, 2017-04-11 21:10:46]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 21:11:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 21:14:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 21:14:57]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jdufault, 2017-04-11 22:18:11]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 22:19:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 23:27:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 23:27:12]

Dry run: This issue passed the CQ dry run.

[jdufault, 2017-04-12 18:44:11]

Patchset #1 (id:1) has been deleted

[jdufault, 2017-04-12 18:44:30]

Description was changed from

==========
cros: Add PinStorageProvider enum which describes pin backend in use.

Not currently used, will be used in a follow-up CL.

BUG=
==========

to

==========
cros: Add PinStorageProvider enum which describes pin backend in use.

Not currently used, will be used in a follow-up CL.

BUG=623344
==========

[jdufault, 2017-04-12 18:44:30]

jdufault@chromium.org changed reviewers:
+ achuith@chromium.org

[jdufault, 2017-04-12 22:37:13]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 22:37:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 23:42:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 23:42:06]

Dry run: This issue passed the CQ dry run.

[jdufault, 2017-04-15 00:06:25]

Patchset #1 (id:20001) has been deleted

[jdufault, 2017-04-15 00:07:42]

Description was changed from

==========
cros: Add PinStorageProvider enum which describes pin backend in use.

Not currently used, will be used in a follow-up CL.

BUG=623344
==========

to

==========
cros: Add PinStorageProvider enum which describes pin backend in use.

Not currently used, will be used in a follow-up CL.

This enum will probably go away after the cryptohome APIs are finished.

BUG=623344
==========

[jdufault, 2017-04-15 00:09:06]

achuith@ PTAL

[achuithb, 2017-04-17 22:04:13]

https://codereview.chromium.org/2815733003/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/quick_unlock/quick_unlock_utils.h (right):

https://codereview.chromium.org/2815733003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/quick_unlock/quick_unlock_utils.h:40: enum class
PinStorageProvider { Prefs, Cryptohome };
newline after this line.

Is there a better name? PinStorageProvider sounds like a class, not an enum.

Shouldn't the values be kPrefs, kCryptohome?

[jdufault, 2017-04-19 23:27:16]

Patchset #3 (id:80001) has been deleted

[jdufault, 2017-04-19 23:27:30]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 23:28:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 00:40:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 00:40:46]

Dry run: This issue passed the CQ dry run.

[jdufault, 2017-04-20 01:13:34]

On 2017/04/17 22:04:13, achuithb wrote:
>
https://codereview.chromium.org/2815733003/diff/40001/chrome/browser/chromeos...
> File chrome/browser/chromeos/login/quick_unlock/quick_unlock_utils.h (right):
> 
>
https://codereview.chromium.org/2815733003/diff/40001/chrome/browser/chromeos...
> chrome/browser/chromeos/login/quick_unlock/quick_unlock_utils.h:40: enum class
> PinStorageProvider { Prefs, Cryptohome };
> newline after this line.
> 
> Is there a better name? PinStorageProvider sounds like a class, not an enum.
> 
> Shouldn't the values be kPrefs, kCryptohome?

Done

[jdufault, 2017-04-20 01:13:54]

On 2017/04/20 01:13:34, jdufault wrote:
> On 2017/04/17 22:04:13, achuithb wrote:
> >
>
https://codereview.chromium.org/2815733003/diff/40001/chrome/browser/chromeos...
> > File chrome/browser/chromeos/login/quick_unlock/quick_unlock_utils.h
(right):
> > 
> >
>
https://codereview.chromium.org/2815733003/diff/40001/chrome/browser/chromeos...
> > chrome/browser/chromeos/login/quick_unlock/quick_unlock_utils.h:40: enum
class
> > PinStorageProvider { Prefs, Cryptohome };
> > newline after this line.
> > 
> > Is there a better name? PinStorageProvider sounds like a class, not an enum.
> > 
> > Shouldn't the values be kPrefs, kCryptohome?
> 
> Done

Oops - I'll do the newline in a follow-up CL.

[jdufault, 2017-04-20 18:51:31]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 18:51:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdufault, 2017-04-20 18:51:59]

On 2017/04/20 01:13:54, jdufault wrote:
> On 2017/04/20 01:13:34, jdufault wrote:
> > On 2017/04/17 22:04:13, achuithb wrote:
> > >
> >
>
https://codereview.chromium.org/2815733003/diff/40001/chrome/browser/chromeos...
> > > File chrome/browser/chromeos/login/quick_unlock/quick_unlock_utils.h
> (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2815733003/diff/40001/chrome/browser/chromeos...
> > > chrome/browser/chromeos/login/quick_unlock/quick_unlock_utils.h:40: enum
> class
> > > PinStorageProvider { Prefs, Cryptohome };
> > > newline after this line.
> > > 
> > > Is there a better name? PinStorageProvider sounds like a class, not an
enum.
> > > 
> > > Shouldn't the values be kPrefs, kCryptohome?
> > 
> > Done
> 
> Oops - I'll do the newline in a follow-up CL.

Done - PTAL.

[commit-bot: I haz the power, 2017-04-20 19:34:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 19:34:01]

Dry run: This issue passed the CQ dry run.

[achuithb, 2017-04-26 07:41:19]

lgtm

https://codereview.chromium.org/2815733003/diff/120001/chrome/browser/chromeo...
File chrome/browser/chromeos/login/quick_unlock/fingerprint_storage_unittest.cc
(right):

https://codereview.chromium.org/2815733003/diff/120001/chrome/browser/chromeo...
chrome/browser/chromeos/login/quick_unlock/fingerprint_storage_unittest.cc:20:
FingerprintStorageUnitTest() : profile_(new TestingProfile()) {}
Maybe base::MakeUnique while you're here. Up to you. Also for the other test
files.

[jdufault, 2017-05-10 17:49:20]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2017-05-10 17:49:20]

The patchset sent to the CQ was uploaded after l-g-t-m from achuith@chromium.org
Link to the patchset: https://codereview.chromium.org/2815733003/#ps160001
(title: "Address comments")

[commit-bot: I haz the power, 2017-05-10 17:51:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 20:26:06]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1494438560224630,
"parent_rev": "fa97f9c932cf4a69a4952a3f962782906390a18e", "commit_rev":
"fccaadd4b0451db39c4ae3b61fa1b6bc24afdc2b"}

[commit-bot: I haz the power, 2017-05-10 20:26:17]

Description was changed from

==========
cros: Add PinStorageProvider enum which describes pin backend in use.

Not currently used, will be used in a follow-up CL.

This enum will probably go away after the cryptohome APIs are finished.

BUG=623344
==========

to

==========
cros: Add PinStorageProvider enum which describes pin backend in use.

Not currently used, will be used in a follow-up CL.

This enum will probably go away after the cryptohome APIs are finished.

BUG=623344

Review-Url: https://codereview.chromium.org/2815733003
Cr-Commit-Position: refs/heads/master@{#470684}
Committed:
https://chromium.googlesource.com/chromium/src/+/fccaadd4b0451db39c4ae3b61fa1...
==========

[commit-bot: I haz the power, 2017-05-10 20:26:18]

Committed patchset #6 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/fccaadd4b0451db39c4ae3b61fa1...