Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2811063002: Enable ServiceWorkerNavigationPreload by default (Closed)

Created:
3 years, 8 months ago by horo
Modified:
3 years, 8 months ago
Reviewers:
falken, tkent, rkaplow, jwd, kinuko
CC:
chromium-reviews, kenjibaheux+watch_chromium.org, tzik, apavlov+blink_chromium.org, kinuko+watch, jsbell+serviceworker_chromium.org, caseq+blink_chromium.org, jam, chasej+watch_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org, nhiroki, lushnikov+blink_chromium.org, haraken, michaeln, shimazu+serviceworker_chromium.org, iclelland+watch_chromuim.org, serviceworker-reviews, pfeldman+blink_chromium.org, kinuko+serviceworker, horo+watch_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -737 lines) Patch
M content/browser/service_worker/service_worker_dispatcher_host.cc View 3 chunks +0 lines, -42 lines 0 comments Download
M content/browser/service_worker/service_worker_fetch_dispatcher.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M content/browser/service_worker/service_worker_version.h View 2 chunks +0 lines, -43 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 3 chunks +0 lines, -38 lines 0 comments Download
M content/child/runtime_features.cc View 1 1 chunk +2 lines, -14 lines 0 comments Download
M content/public/common/content_features.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M testing/variations/fieldtrial_testing_config.json View 1 1 chunk +25 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 2 chunks +5 lines, -10 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/resources/navigation-preload-worker.js View 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/resources/navigation-preload-worker.php View 1 chunk +0 lines, -23 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-navigation-preload.html View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/navigation-preload-origin-trial-interfaces.html View 1 chunk +0 lines, -74 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/navigation-preload-origin-trial-interfaces-expected.txt View 1 chunk +0 lines, -85 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/navigation-preload-origin-trial-methods.html View 1 chunk +0 lines, -82 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/navigation-preload-origin-trial-methods-expected.txt View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/navigation-preload-origin-trial-interfaces-worker.php View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/navigation-preload-origin-trial-methods-scope.php View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/navigation-preload-origin-trial-methods-worker.php View 1 chunk +0 lines, -64 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 3 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 chunks +8 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/http/tests/serviceworker/chromium/README.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/http/tests/serviceworker/chromium/navigation-preload-origin-trial-interfaces-expected.txt View 1 chunk +0 lines, -85 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/http/tests/serviceworker/chromium/navigation-preload-origin-trial-methods-expected.txt View 1 chunk +0 lines, -31 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/http/tests/serviceworker/webexposed/README.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/README.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-dedicated-worker-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-shared-worker-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-wpt/external/wpt/service-workers/service-worker/navigation-preload/README.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 3 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt View 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt View 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp View 1 4 chunks +0 lines, -67 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/FetchEvent.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadManager.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 43 (29 generated)
horo
falken@ Could you please review this?
3 years, 8 months ago (2017-04-11 23:40:42 UTC) #19
falken
lgtm
3 years, 8 months ago (2017-04-12 01:43:10 UTC) #20
kinuko
lgtm!
3 years, 8 months ago (2017-04-12 01:59:44 UTC) #21
horo
tkent@ Could you please review global-interface-listing-*-expected.txt?
3 years, 8 months ago (2017-04-12 03:03:14 UTC) #23
horo
rkaplow@ Please review testing/variations/fieldtrial_testing_config.json.
3 years, 8 months ago (2017-04-12 03:04:06 UTC) #25
horo
jwd@ Could you please review testing/variations/fieldtrial_testing_config.json? rkaplow@ is ooo.
3 years, 8 months ago (2017-04-12 04:13:18 UTC) #27
tkent
On 2017/04/12 at 03:03:14, horo wrote: > tkent@ > Could you please review global-interface-listing-*-expected.txt? lgtm
3 years, 8 months ago (2017-04-12 13:50:04 UTC) #28
jwd
lgtm
3 years, 8 months ago (2017-04-12 19:09:13 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811063002/60001
3 years, 8 months ago (2017-04-12 23:08:29 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/246862) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 8 months ago (2017-04-12 23:14:38 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811063002/80001
3 years, 8 months ago (2017-04-12 23:42:59 UTC) #36
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/428672)
3 years, 8 months ago (2017-04-13 01:50:44 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811063002/80001
3 years, 8 months ago (2017-04-13 02:19:21 UTC) #40
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 03:30:30 UTC) #43
Message was sent while issue was closed. 
Committed patchset #2 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/23752147e6f5f7dcaf4bad1bb1c3...

Powered by Google App Engine
This is Rietveld 408576698