Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: content/browser/service_worker/service_worker_version.h

Issue 2811063002: Enable ServiceWorkerNavigationPreload by default (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_version.h
diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h
index 6325a5f30e53d049187a33a1b853bc31aac81f50..7419d1174e8343a3d5db22c7a801518a379d1f78 100644
--- a/content/browser/service_worker/service_worker_version.h
+++ b/content/browser/service_worker/service_worker_version.h
@@ -102,14 +102,6 @@ class CONTENT_EXPORT ServiceWorkerVersion
DOES_NOT_EXIST,
};
- // Navigation Preload support status of the service worker.
- enum class NavigationPreloadSupportStatus {
- SUPPORTED,
- NOT_SUPPORTED_FIELD_TRIAL_STOPPED,
- NOT_SUPPORTED_DISABLED_BY_COMMAND_LINE,
- NOT_SUPPORTED_NO_VALID_ORIGIN_TRIAL_TOKEN,
- };
-
class Listener {
public:
virtual void OnRunningStateChanged(ServiceWorkerVersion* version) {}
@@ -409,41 +401,6 @@ class CONTENT_EXPORT ServiceWorkerVersion
return max_request_expiration_time_ - tick_clock_->NowTicks();
}
- // Returns the Navigation Preload support status of the service worker.
- // - Origin Trial: Have an effective token.
- // Command line
- // Default Enable Disabled
- // Default A A B2
- // Field trial Enabled A A B2
- // Disabled B1 A B2
- //
- // - Origin Trial: No token.
- // Command line
- // Default Enable Disabled
- // Default C A C
- // Field trial Enabled C A C
- // Disabled C A C
- //
- // * A = SUPPORTED
- // B1 = NOT_SUPPORTED_FIELD_TRIAL_STOPPED
- // B2 = NOT_SUPPORTED_DISABLED_BY_COMMAND_LINE
- // C = NOT_SUPPORTED_NO_VALID_ORIGIN_TRIAL_TOKEN
- //
- // There are three types of behaviors:
- // - A: Navigation Preload related methods and attributes are available in JS
- // and work correctly.
- // - B: Navigation Preload related methods and attributes are available in
- // JS. But NavigationPreloadManager's enable, disable and setHeaderValue
- // methods always return a rejected promise. And FetchEvent's
- // preloadResponse attribute returns a promise which always resolve with
- // undefined.
- // - C: Navigation Preload related methods and attributes are not available
- // in JS.
- // This method returns SUPPORTED only for A case.
- // blink::OriginTrials::serviceWorkerNavigationPreloadEnabled() returns true
- // for both A and B case. So the methods and attributes are available in JS.
- NavigationPreloadSupportStatus GetNavigationPreloadSupportStatus() const;
-
void CountFeature(uint32_t feature);
void set_used_features(const std::set<uint32_t>& used_features) {
used_features_ = used_features;

Powered by Google App Engine
This is Rietveld 408576698