Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1503)

Unified Diff: content/child/runtime_features.cc

Issue 2811063002: Enable ServiceWorkerNavigationPreload by default (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/service_worker/service_worker_version.cc ('k') | content/public/common/content_features.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/runtime_features.cc
diff --git a/content/child/runtime_features.cc b/content/child/runtime_features.cc
index b334d5b2bc9423b05c9d96b3bb40ca12bf0fc6c0..15426d87239ae5f397283714ec87cfec65a89e4a 100644
--- a/content/child/runtime_features.cc
+++ b/content/child/runtime_features.cc
@@ -333,20 +333,8 @@ void SetRuntimeFeaturesDefaultsAndUpdateFromArgs(
base::FeatureList::IsEnabled(features::kWebPayments));
#endif
- // Sets the RuntimeEnabledFeatures for Navigation Preload feature only when
- // '--enable-features' command line flag is given. While experimenting this
- // feature using Origin-Trial, this base::Feature is enabled by default in
- // content_features.cc. So FeatureList::IsEnabled() always returns true. But,
- // unless the command line explicitly enabled the feature, this feature should
- // be available only when a valid origin trial token is set. This check is
- // done by the generated code of
- // blink::OriginTrials::serviceWorkerNavigationPreloadEnabled(). See the
- // comments in service_worker_version.h for the details.
- if (base::FeatureList::GetInstance()->IsFeatureOverriddenFromCommandLine(
- features::kServiceWorkerNavigationPreload.name,
- base::FeatureList::OVERRIDE_ENABLE_FEATURE)) {
- WebRuntimeFeatures::EnableServiceWorkerNavigationPreload(true);
- }
+ WebRuntimeFeatures::EnableServiceWorkerNavigationPreload(
+ base::FeatureList::IsEnabled(features::kServiceWorkerNavigationPreload));
if (base::FeatureList::IsEnabled(features::kGamepadExtensions))
WebRuntimeFeatures::EnableGamepadExtensions(true);
« no previous file with comments | « content/browser/service_worker/service_worker_version.cc ('k') | content/public/common/content_features.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698