Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 2810843004: MacViewsBrowser: Fix BrowserFrameMac compile after blink rename (Closed)

Created:
3 years, 8 months ago by tapted
Modified:
3 years, 8 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViewsBrowser: Fix BrowserFrameMac compile after blink rename Fixes: browser_frame_mac.mm:28:13: error: no member named 'type' in 'content::NativeWebKeyboardEvent' browser_frame_mac.mm:28:56: error: no member named 'Char' in 'content::NativeWebKeyboardEvent' BUG=425229 Review-Url: https://codereview.chromium.org/2810843004 Cr-Commit-Position: refs/heads/master@{#463544} Committed: https://chromium.googlesource.com/chromium/src/+/a69f79bc7c3c88035471592891d7d43735eacebb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/views/frame/browser_frame_mac.mm View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (10 generated)
tapted
Hi Peter, please take a look
3 years, 8 months ago (2017-04-11 05:24:10 UTC) #8
Peter Kasting
LGTM
3 years, 8 months ago (2017-04-11 05:31:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810843004/1
3 years, 8 months ago (2017-04-11 05:33:02 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 05:38:26 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a69f79bc7c3c88035471592891d7...

Powered by Google App Engine
This is Rietveld 408576698