Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2800343002:
Remove CoreServices.h from Blink's precompiled headers on Mac (Closed)
DescriptionRemove CoreServices.h from Blink's precompiled headers on Mac
Its presence is causing compile failures in non-goma builds since the
Blink identifier renames in r463139. (goma builds disable precompiled
headers, so this problem isn't appearing on the bots).
Blink Mac code doesn't seem to use anything from it. The framework
includes deprecated Carbon framework headers such as AVLTree.h which
pollute the global namespace with `kLeftToRight` which is causing
ambiguity with WTF::Unicode::kLeftToRight when it is used in
WebKit/Source/platform/text/BidiResolver.h
Note that Objective C code in blink (there is not much of it) will still
see symbols from CoreServices.h when it's included via Cocoa.h.
BUG=709850
TBR=thakis@chromium.org
Review-Url: https://codereview.chromium.org/2800343002
Cr-Commit-Position: refs/heads/master@{#463173}
Committed: https://chromium.googlesource.com/chromium/src/+/25921a3c76075db1aefb91ebceb216c0dd2556db
Patch Set 1 #
Dependent Patchsets: Messages
Total messages: 18 (13 generated)
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Remove CoreServices.h from precompiled headers on Mac BUG=709850 ========== to ========== Remove CoreServices.h from Blink's precompiled headers on Mac Its presence is causing compile failures in developer builds. Blink Mac code doesn't seem to use anything from it. The framework includes deprecated Carbon framework headers such as AVLTree.h which pollute the global namespace with `kLeftToRight` which is causing ambiguity with WTF::Unicode::kLeftToRight when it is used in WebKit/Source/platform/text/BidiResolver.h Note that Objective C code in blink (there is not much of it) will still see symbols from CoreServices.h when it's included via Cocoa.h. BUG=709850 ==========
Description was changed from ========== Remove CoreServices.h from Blink's precompiled headers on Mac Its presence is causing compile failures in developer builds. Blink Mac code doesn't seem to use anything from it. The framework includes deprecated Carbon framework headers such as AVLTree.h which pollute the global namespace with `kLeftToRight` which is causing ambiguity with WTF::Unicode::kLeftToRight when it is used in WebKit/Source/platform/text/BidiResolver.h Note that Objective C code in blink (there is not much of it) will still see symbols from CoreServices.h when it's included via Cocoa.h. BUG=709850 ========== to ========== Remove CoreServices.h from Blink's precompiled headers on Mac Its presence is causing compile failures in developer builds since the Blink identifier renames in r463139 Blink Mac code doesn't seem to use anything from it. The framework includes deprecated Carbon framework headers such as AVLTree.h which pollute the global namespace with `kLeftToRight` which is causing ambiguity with WTF::Unicode::kLeftToRight when it is used in WebKit/Source/platform/text/BidiResolver.h Note that Objective C code in blink (there is not much of it) will still see symbols from CoreServices.h when it's included via Cocoa.h. BUG=709850 ==========
tapted@chromium.org changed reviewers: + thakis@chromium.org
Description was changed from ========== Remove CoreServices.h from Blink's precompiled headers on Mac Its presence is causing compile failures in developer builds since the Blink identifier renames in r463139 Blink Mac code doesn't seem to use anything from it. The framework includes deprecated Carbon framework headers such as AVLTree.h which pollute the global namespace with `kLeftToRight` which is causing ambiguity with WTF::Unicode::kLeftToRight when it is used in WebKit/Source/platform/text/BidiResolver.h Note that Objective C code in blink (there is not much of it) will still see symbols from CoreServices.h when it's included via Cocoa.h. BUG=709850 ========== to ========== Remove CoreServices.h from Blink's precompiled headers on Mac Its presence is causing compile failures in non-goma builds since the Blink identifier renames in r463139. (goma builds disable precompile headers, so this problem isn't appearing on the bots). Blink Mac code doesn't seem to use anything from it. The framework includes deprecated Carbon framework headers such as AVLTree.h which pollute the global namespace with `kLeftToRight` which is causing ambiguity with WTF::Unicode::kLeftToRight when it is used in WebKit/Source/platform/text/BidiResolver.h Note that Objective C code in blink (there is not much of it) will still see symbols from CoreServices.h when it's included via Cocoa.h. BUG=709850 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Remove CoreServices.h from Blink's precompiled headers on Mac Its presence is causing compile failures in non-goma builds since the Blink identifier renames in r463139. (goma builds disable precompile headers, so this problem isn't appearing on the bots). Blink Mac code doesn't seem to use anything from it. The framework includes deprecated Carbon framework headers such as AVLTree.h which pollute the global namespace with `kLeftToRight` which is causing ambiguity with WTF::Unicode::kLeftToRight when it is used in WebKit/Source/platform/text/BidiResolver.h Note that Objective C code in blink (there is not much of it) will still see symbols from CoreServices.h when it's included via Cocoa.h. BUG=709850 ========== to ========== Remove CoreServices.h from Blink's precompiled headers on Mac Its presence is causing compile failures in non-goma builds since the Blink identifier renames in r463139. (goma builds disable precompile headers, so this problem isn't appearing on the bots). Blink Mac code doesn't seem to use anything from it. The framework includes deprecated Carbon framework headers such as AVLTree.h which pollute the global namespace with `kLeftToRight` which is causing ambiguity with WTF::Unicode::kLeftToRight when it is used in WebKit/Source/platform/text/BidiResolver.h Note that Objective C code in blink (there is not much of it) will still see symbols from CoreServices.h when it's included via Cocoa.h. BUG=709850 TBR=thakis@chromium.org ==========
Description was changed from ========== Remove CoreServices.h from Blink's precompiled headers on Mac Its presence is causing compile failures in non-goma builds since the Blink identifier renames in r463139. (goma builds disable precompile headers, so this problem isn't appearing on the bots). Blink Mac code doesn't seem to use anything from it. The framework includes deprecated Carbon framework headers such as AVLTree.h which pollute the global namespace with `kLeftToRight` which is causing ambiguity with WTF::Unicode::kLeftToRight when it is used in WebKit/Source/platform/text/BidiResolver.h Note that Objective C code in blink (there is not much of it) will still see symbols from CoreServices.h when it's included via Cocoa.h. BUG=709850 TBR=thakis@chromium.org ========== to ========== Remove CoreServices.h from Blink's precompiled headers on Mac Its presence is causing compile failures in non-goma builds since the Blink identifier renames in r463139. (goma builds disable precompiled headers, so this problem isn't appearing on the bots). Blink Mac code doesn't seem to use anything from it. The framework includes deprecated Carbon framework headers such as AVLTree.h which pollute the global namespace with `kLeftToRight` which is causing ambiguity with WTF::Unicode::kLeftToRight when it is used in WebKit/Source/platform/text/BidiResolver.h Note that Objective C code in blink (there is not much of it) will still see symbols from CoreServices.h when it's included via Cocoa.h. BUG=709850 TBR=thakis@chromium.org ==========
thakis: TBR to prevent others getting blocked by this.. And.. I wonder if we should strip this down a lot more, or just delete the mac-specific .pch .. This separate file probably made more sense with WebKit's Mac focus in the past, but I doubt there's many files in blink actually wanting the mac-specific symbols from system headers any more... e.g. only a ~dozen files include CoreFoundation stuff (+ another 10 or so that get it transitively via RetainPtr.h). Making the .pch smaller should make the build faster when only 20 or so files rely on the removed stuff).
The CQ bit was checked by tapted@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1491802093506530, "parent_rev":
"165039831ad0a01bcc90b66d023c9d90dcc964d1", "commit_rev":
"25921a3c76075db1aefb91ebceb216c0dd2556db"}
Message was sent while issue was closed.
Description was changed from ========== Remove CoreServices.h from Blink's precompiled headers on Mac Its presence is causing compile failures in non-goma builds since the Blink identifier renames in r463139. (goma builds disable precompiled headers, so this problem isn't appearing on the bots). Blink Mac code doesn't seem to use anything from it. The framework includes deprecated Carbon framework headers such as AVLTree.h which pollute the global namespace with `kLeftToRight` which is causing ambiguity with WTF::Unicode::kLeftToRight when it is used in WebKit/Source/platform/text/BidiResolver.h Note that Objective C code in blink (there is not much of it) will still see symbols from CoreServices.h when it's included via Cocoa.h. BUG=709850 TBR=thakis@chromium.org ========== to ========== Remove CoreServices.h from Blink's precompiled headers on Mac Its presence is causing compile failures in non-goma builds since the Blink identifier renames in r463139. (goma builds disable precompiled headers, so this problem isn't appearing on the bots). Blink Mac code doesn't seem to use anything from it. The framework includes deprecated Carbon framework headers such as AVLTree.h which pollute the global namespace with `kLeftToRight` which is causing ambiguity with WTF::Unicode::kLeftToRight when it is used in WebKit/Source/platform/text/BidiResolver.h Note that Objective C code in blink (there is not much of it) will still see symbols from CoreServices.h when it's included via Cocoa.h. BUG=709850 TBR=thakis@chromium.org Review-Url: https://codereview.chromium.org/2800343002 Cr-Commit-Position: refs/heads/master@{#463173} Committed: https://chromium.googlesource.com/chromium/src/+/25921a3c76075db1aefb91ebceb2... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/25921a3c76075db1aefb91ebceb2...
Message was sent while issue was closed.
Lgtm Huh I thought we no longer use this at all after https://codereview.chromium.org/2702363002/
Message was sent while issue was closed.
On 2017/04/10 10:13:32, Nico wrote: > Lgtm > > Huh I thought we no longer use this at all after > https://codereview.chromium.org/2702363002/ Never mind, I remembered that change wrong. I don't think we should delete the pchs though; that patch claimed a noticeable build time improvement (as did https://codereview.chromium.org/2520863002/) for people not using goma. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
