Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2815523003: Guard ui/keyboard include (which is Aura-only) in location_bar/keyword_hint_view.cc (Closed)

Created:
3 years, 8 months ago by tapted
Modified:
3 years, 8 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Guard ui/keyboard include (which is Aura-only) in location_bar/keyword_hint_view.cc This regressed in r463089 which added logic to detect when an on-screen keyboard is visible. //ui/keyboard is only added as a c/b/ui dependency with aura. (macOS does have a native "Keyboard Viewer" window, but it is not a functional keyboard replacement.) BUG=425229 Review-Url: https://codereview.chromium.org/2815523003 Cr-Commit-Position: refs/heads/master@{#463546} Committed: https://chromium.googlesource.com/chromium/src/+/311ab7707e0fe5cb6a2070420c6627d814fdc882

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M chrome/browser/ui/views/location_bar/keyword_hint_view.cc View 3 chunks +13 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (11 generated)
tapted
Hi Peter, please take a look
3 years, 8 months ago (2017-04-11 05:23:40 UTC) #9
Peter Kasting
LGTM
3 years, 8 months ago (2017-04-11 05:31:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815523003/1
3 years, 8 months ago (2017-04-11 05:50:44 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 05:55:51 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/311ab7707e0fe5cb6a2070420c66...

Powered by Google App Engine
This is Rietveld 408576698