Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2810743004: Remove the MediaPermissionStatus helper class (Closed)

Created:
3 years, 8 months ago by raymes
Modified:
3 years, 8 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, chfremer+watch_chromium.org, feature-media-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the MediaPermissionStatus helper class Originally MediaPermissionStatus was added to facilitate moving some of the permissions logic out of MediaStreamDevicesController. It turns out that it is simpler to move the permission request logic out instead, as is done in the followup CL: https://codereview.chromium.org/2811913002 This CL removes that helper class and moves the functionality back into GetContentSetting. BUG=596786 Review-Url: https://codereview.chromium.org/2810743004 Cr-Commit-Position: refs/heads/master@{#465111} Committed: https://chromium.googlesource.com/chromium/src/+/799cbeb7126756f38d29d4bdf88a2efe417ad862

Patch Set 1 #

Patch Set 2 : Remove the MediaPermissionStatus helper class #

Messages

Total messages: 14 (9 generated)
raymes
Sorry for the churn on this, but if you look at the followup CL I ...
3 years, 8 months ago (2017-04-10 23:22:17 UTC) #3
raymes
Ping :)
3 years, 8 months ago (2017-04-13 01:53:16 UTC) #8
Timothy Loh
On 2017/04/13 01:53:16, raymes wrote: > Ping :) lgtm
3 years, 8 months ago (2017-04-18 01:27:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810743004/20001
3 years, 8 months ago (2017-04-18 01:51:41 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 02:38:12 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/799cbeb7126756f38d29d4bdf88a...

Powered by Google App Engine
This is Rietveld 408576698