Remove c/b/media/webrtc/media_permission.{h,cc}

Remove c/b/media/webrtc/media_permission.{h,cc}

This class is now just basically a wrapper around PermissionManager. Remove it
and inline the calls to PermissionManager.

BUG=596786
Review-Url: https://codereview.chromium.org/2759593002
Cr-Commit-Position: refs/heads/master@{#463541}
Committed: https://chromium.googlesource.com/chromium/src/+/877f588c9768a6039eee14c50b2e8f6262e478ba

[raymes, 2017-04-04 03:23:06]

Description was changed from

==========
Remove c/b/media/webrtc/media_permission.{h,cc}

This class is now just basically a wrapper around PermissionManager.
Remove it and inline the calls to PermissionManager.

BUG=596786
==========

to

==========
Remove c/b/media/webrtc/media_permission.{h,cc}

This class is now just basically a wrapper around PermissionManager. Remove it
and inline the calls to PermissionManager.

BUG=596786
==========

[raymes, 2017-04-04 03:23:26]

raymes@chromium.org changed reviewers:
+ sergeyu@chromium.org, timloh@chromium.org

[Timothy Loh, 2017-04-05 05:34:50]

On 2017/04/04 03:23:26, raymes wrote:

lgtm!

[Sergey Ulanov, 2017-04-05 19:28:49]

lgtm

https://codereview.chromium.org/2759593002/diff/20001/chrome/browser/media/we...
File chrome/browser/media/webrtc/media_stream_devices_controller.cc (right):

https://codereview.chromium.org/2759593002/diff/20001/chrome/browser/media/we...
chrome/browser/media/webrtc/media_stream_devices_controller.cc:744:
*denial_reason = content::MEDIA_DEVICE_KILL_SWITCH_ON;
*denial_reason = (result.source == PermissionStatusSource::KILL_SWITCH) ?
       content::MEDIA_DEVICE_KILL_SWITCH_ON :
       content::MEDIA_DEVICE_PERMISSION_DENIED;

[raymes, 2017-04-09 23:55:06]

https://codereview.chromium.org/2759593002/diff/20001/chrome/browser/media/we...
File chrome/browser/media/webrtc/media_stream_devices_controller.cc (right):

https://codereview.chromium.org/2759593002/diff/20001/chrome/browser/media/we...
chrome/browser/media/webrtc/media_stream_devices_controller.cc:744:
*denial_reason = content::MEDIA_DEVICE_KILL_SWITCH_ON;
On 2017/04/05 19:28:48, Sergey Ulanov wrote:
> *denial_reason = (result.source == PermissionStatusSource::KILL_SWITCH) ?
>        content::MEDIA_DEVICE_KILL_SWITCH_ON :
>        content::MEDIA_DEVICE_PERMISSION_DENIED;

Done.

[raymes, 2017-04-09 23:55:12]

The CQ bit was checked by raymes@chromium.org

[raymes, 2017-04-09 23:55:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
sergeyu@chromium.org, timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/2759593002/#ps40001
(title: "Remove c/b/media/webrtc/media_permission.{h,cc}")

[commit-bot: I haz the power, 2017-04-09 23:55:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[raymes, 2017-04-09 23:58:55]

The CQ bit was unchecked by raymes@chromium.org

[raymes, 2017-04-10 00:39:49]

The CQ bit was checked by raymes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 00:39:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 00:42:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 00:42:11]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[raymes, 2017-04-10 22:59:03]

The CQ bit was checked by raymes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 22:59:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 23:04:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 23:04:12]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[raymes, 2017-04-11 03:00:24]

The CQ bit was checked by raymes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 03:01:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 04:10:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 04:10:56]

Dry run: This issue passed the CQ dry run.

[raymes, 2017-04-11 04:29:25]

The CQ bit was checked by raymes@chromium.org

[raymes, 2017-04-11 04:29:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
sergeyu@chromium.org, timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/2759593002/#ps100001
(title: "Remove c/b/media/webrtc/media_permission.{h,cc}")

[commit-bot: I haz the power, 2017-04-11 04:29:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 05:16:37]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1491884965287840,
"parent_rev": "78eb222b5d9fcb2585fbccff017c4bde23ad1434", "commit_rev":
"877f588c9768a6039eee14c50b2e8f6262e478ba"}

[commit-bot: I haz the power, 2017-04-11 05:17:31]

Description was changed from

==========
Remove c/b/media/webrtc/media_permission.{h,cc}

This class is now just basically a wrapper around PermissionManager. Remove it
and inline the calls to PermissionManager.

BUG=596786
==========

to

==========
Remove c/b/media/webrtc/media_permission.{h,cc}

This class is now just basically a wrapper around PermissionManager. Remove it
and inline the calls to PermissionManager.

BUG=596786

Review-Url: https://codereview.chromium.org/2759593002
Cr-Commit-Position: refs/heads/master@{#463541}
Committed:
https://chromium.googlesource.com/chromium/src/+/877f588c9768a6039eee14c50b2e...
==========

[commit-bot: I haz the power, 2017-04-11 05:17:32]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/877f588c9768a6039eee14c50b2e...