Simplify RecordPermissionAction and Android permission callback

Simplify RecordPermissionAction and Android permission callback

This simplifies RecordPermissionAction and the Android permission
callback in MediaStreamDevicesController. RecordPermissionAction is
changed to pass in whether mic/camera are being requested rather than
passing in the entire request.

The Android OS permission callback is changed in several ways:
1) The callback used to be a standalone function, which then called into
member functions in MediaStreamDevicesController. It now just calls into
a member function directly, removing a layer of indirection.
2) It used to call into PermissionGranted on success which would then call
RunCallback with the appropriate arguments. Instead we just call
RunCallback directly in that case, as no modifying of the content
settings values is needed.
3) It used to call into ForcePermissionDeniedTemporarily in the denial
case. This would call RunCallback with CONTENT_SETTING_BLOCK passed for
both mic/camera. This is actually slightly incorrect, and we only need
to change the settings that were previously CONTENT_SETTING_ALLOW to
BLOCK (as the setting may not have been requested at all). This is done
and then RunCallback is called directly.
4) set_persist() does not need to be called as settings are only
persisted when they are initially set to CONTENT_SETTING_ASK. That
cannot be the case at the point this code is reached.

BUG=596786
Review-Url: https://codereview.chromium.org/2815933003
Cr-Commit-Position: refs/heads/master@{#465440}
Committed: https://chromium.googlesource.com/chromium/src/+/6093fbaf1efb92bfde140f4dbe17e7b38c2fa39f

[raymes, 2017-04-13 01:55:49]

The CQ bit was checked by raymes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 01:56:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[raymes, 2017-04-13 01:56:41]

raymes@chromium.org changed reviewers:
+ timloh@chromium.org

[commit-bot: I haz the power, 2017-04-13 03:06:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 03:06:36]

Dry run: This issue passed the CQ dry run.

[Timothy Loh, 2017-04-18 01:47:51]

On 2017/04/13 01:56:42, raymes wrote:

lgtm

[raymes, 2017-04-18 23:29:53]

The CQ bit was checked by raymes@chromium.org

[commit-bot: I haz the power, 2017-04-18 23:30:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 00:38:17]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492558193340090, "parent_rev":
"b64df4b2b6feeebc0ae622fb2fc012cfa6b58c1a", "commit_rev":
"6093fbaf1efb92bfde140f4dbe17e7b38c2fa39f"}

[commit-bot: I haz the power, 2017-04-19 00:38:25]

Description was changed from

==========
Simplify RecordPermissionAction and Android permission callback

This simplifies RecordPermissionAction and the Android permission
callback in MediaStreamDevicesController. RecordPermissionAction is
changed to pass in whether mic/camera are being requested rather than
passing in the entire request.

The Android OS permission callback is changed in several ways:
1) The callback used to be a standalone function, which then called into
member functions in MediaStreamDevicesController. It now just calls into
a member function directly, removing a layer of indirection.
2) It used to call into PermissionGranted on success which would then call
RunCallback with the appropriate arguments. Instead we just call
RunCallback directly in that case, as no modifying of the content
settings values is needed.
3) It used to call into ForcePermissionDeniedTemporarily in the denial
case. This would call RunCallback with CONTENT_SETTING_BLOCK passed for
both mic/camera. This is actually slightly incorrect, and we only need
to change the settings that were previously CONTENT_SETTING_ALLOW to
BLOCK (as the setting may not have been requested at all). This is done
and then RunCallback is called directly.
4) set_persist() does not need to be called as settings are only
persisted when they are initially set to CONTENT_SETTING_ASK. That
cannot be the case at the point this code is reached.

BUG=596786
==========

to

==========
Simplify RecordPermissionAction and Android permission callback

This simplifies RecordPermissionAction and the Android permission
callback in MediaStreamDevicesController. RecordPermissionAction is
changed to pass in whether mic/camera are being requested rather than
passing in the entire request.

The Android OS permission callback is changed in several ways:
1) The callback used to be a standalone function, which then called into
member functions in MediaStreamDevicesController. It now just calls into
a member function directly, removing a layer of indirection.
2) It used to call into PermissionGranted on success which would then call
RunCallback with the appropriate arguments. Instead we just call
RunCallback directly in that case, as no modifying of the content
settings values is needed.
3) It used to call into ForcePermissionDeniedTemporarily in the denial
case. This would call RunCallback with CONTENT_SETTING_BLOCK passed for
both mic/camera. This is actually slightly incorrect, and we only need
to change the settings that were previously CONTENT_SETTING_ALLOW to
BLOCK (as the setting may not have been requested at all). This is done
and then RunCallback is called directly.
4) set_persist() does not need to be called as settings are only
persisted when they are initially set to CONTENT_SETTING_ASK. That
cannot be the case at the point this code is reached.

BUG=596786

Review-Url: https://codereview.chromium.org/2815933003
Cr-Commit-Position: refs/heads/master@{#465440}
Committed:
https://chromium.googlesource.com/chromium/src/+/6093fbaf1efb92bfde140f4dbe17...
==========

[commit-bot: I haz the power, 2017-04-19 00:38:26]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6093fbaf1efb92bfde140f4dbe17...