Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/filesystem

Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/filesystem

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED
with DCHECK_op, CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/modules/filesystem

BUG=707641
Review-Url: https://codereview.chromium.org/2810513002
Cr-Commit-Position: refs/heads/master@{#463160}
Committed: https://chromium.googlesource.com/chromium/src/+/cf4fb409e74c24d186de1f337221a72b4634cba6

[Hwanseung Lee, 2017-04-09 01:40:31]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-09 01:40:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hwanseung Lee, 2017-04-09 01:40:51]

Description was changed from

==========
Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/filesystem

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED
with DCHECK_op, CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/modules/filesystem

BUG=707641
==========

to

==========
Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/filesystem

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED
with DCHECK_op, CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/modules/filesystem

BUG=707641
==========

[Hwanseung Lee, 2017-04-09 01:40:51]

hs1217.lee@samsung.com changed reviewers:
+ tkent@chromium.org, tzik@chromium.org

[commit-bot: I haz the power, 2017-04-09 04:34:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-09 04:34:51]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Hwanseung Lee, 2017-04-09 08:23:04]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-09 08:23:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-09 09:44:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-09 09:44:06]

Dry run: This issue passed the CQ dry run.

[Hwanseung Lee, 2017-04-09 09:54:20]

PTAL, thank you.

[haraken, 2017-04-09 13:02:58]

LGTM

[Hwanseung Lee, 2017-04-09 22:32:08]

The CQ bit was checked by hs1217.lee@samsung.com

[commit-bot: I haz the power, 2017-04-09 22:32:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-09 22:39:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-09 22:39:11]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Hwanseung Lee, 2017-04-09 22:55:34]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-09 22:55:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-04-09 23:10:59]

tkent@chromium.org changed reviewers:
+ haraken@chromium.org

[tkent, 2017-04-09 23:11:00]

https://codereview.chromium.org/2810513002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/filesystem/DOMFileSystemBase.cpp (right):

https://codereview.chromium.org/2810513002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/filesystem/DOMFileSystemBase.cpp:353:
DCHECK(entry && entry->isDirectory());
Split this into two DCHECKs.

[Hwanseung Lee, 2017-04-09 23:14:30]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-09 23:14:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hwanseung Lee, 2017-04-09 23:14:56]

The CQ bit was unchecked by hs1217.lee@samsung.com

[Hwanseung Lee, 2017-04-09 23:15:03]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-09 23:15:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hwanseung Lee, 2017-04-09 23:15:56]

PTAL, thank you.

https://codereview.chromium.org/2810513002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/filesystem/DOMFileSystemBase.cpp (right):

https://codereview.chromium.org/2810513002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/filesystem/DOMFileSystemBase.cpp:353:
DCHECK(entry && entry->isDirectory());
On 2017/04/09 23:11:00, tkent wrote:
> Split this into two DCHECKs.

Done.

[tkent, 2017-04-09 23:18:23]

lgtm

[commit-bot: I haz the power, 2017-04-10 00:28:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 00:28:27]

Dry run: This issue passed the CQ dry run.

[Hwanseung Lee, 2017-04-10 00:35:53]

The CQ bit was checked by hs1217.lee@samsung.com

[Hwanseung Lee, 2017-04-10 00:35:53]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2810513002/#ps40001
(title: "split")

[commit-bot: I haz the power, 2017-04-10 00:36:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 00:41:10]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491784553218730,
"parent_rev": "d947824f59377a43781ea4aa3ee188a995e71734", "commit_rev":
"cf4fb409e74c24d186de1f337221a72b4634cba6"}

[commit-bot: I haz the power, 2017-04-10 00:42:24]

Description was changed from

==========
Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/filesystem

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED
with DCHECK_op, CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/modules/filesystem

BUG=707641
==========

to

==========
Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/filesystem

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED
with DCHECK_op, CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/modules/filesystem

BUG=707641

Review-Url: https://codereview.chromium.org/2810513002
Cr-Commit-Position: refs/heads/master@{#463160}
Committed:
https://chromium.googlesource.com/chromium/src/+/cf4fb409e74c24d186de1f337221...
==========

[commit-bot: I haz the power, 2017-04-10 00:42:26]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/cf4fb409e74c24d186de1f337221...