third_party/WebKit/Source/modules/filesystem/FileWriterBase.cpp - Issue 2810513002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/filesystem

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/filesystem/FileWriterBase.cpp

Issue 2810513002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/filesystem (Closed)

Patch Set: split Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/filesystem/FileWriterBase.cpp

diff --git a/third_party/WebKit/Source/modules/filesystem/FileWriterBase.cpp b/third_party/WebKit/Source/modules/filesystem/FileWriterBase.cpp

index 5c265e5f399fa4a24d6e7d027dd88ff41377a461..107bc74de9383ef32e3413b26cb0061283df3484 100644

--- a/third_party/WebKit/Source/modules/filesystem/FileWriterBase.cpp

+++ b/third_party/WebKit/Source/modules/filesystem/FileWriterBase.cpp

@@ -42,8 +42,8 @@ FileWriterBase::~FileWriterBase() {}

void FileWriterBase::Initialize(std::unique_ptr<WebFileWriter> writer,

long long length) {

- ASSERT(!writer_);

- ASSERT(length >= 0);

+ DCHECK(!writer_);

+ DCHECK_GE(length, 0);

writer_ = std::move(writer);

length_ = length;

}