Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Unified Diff: third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp

Issue 2810513002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/filesystem (Closed)
Patch Set: split Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp
diff --git a/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp b/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp
index 730cee3a7c630bfa75de7ad773236769a7f1eb79..986797282c54d29b210205647642db584ab1c200 100644
--- a/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp
+++ b/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp
@@ -120,12 +120,12 @@ void DOMFileSystem::AddPendingCallbacks() {
}
void DOMFileSystem::RemovePendingCallbacks() {
- ASSERT(number_of_pending_callbacks_ > 0);
+ DCHECK_GT(number_of_pending_callbacks_, 0);
--number_of_pending_callbacks_;
}
bool DOMFileSystem::HasPendingActivity() const {
- ASSERT(number_of_pending_callbacks_ >= 0);
+ DCHECK_GE(number_of_pending_callbacks_, 0);
return number_of_pending_callbacks_;
}
@@ -172,7 +172,7 @@ class ConvertToFileWriterCallback : public FileWriterBaseCallback {
void DOMFileSystem::CreateWriter(const FileEntry* file_entry,
FileWriterCallback* success_callback,
ErrorCallbackBase* error_callback) {
- ASSERT(file_entry);
+ DCHECK(file_entry);
if (!FileSystem()) {
ReportError(error_callback, FileError::kAbortErr);

Powered by Google App Engine
This is Rietveld 408576698